Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp2521049pxj; Mon, 10 May 2021 05:06:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz4sUWrT5uk98kLl1IHtYA6x5QuzZLxsQl9w2JUy/jTmLfKuL+F+PtABu/Z7znhJAAozw2D X-Received: by 2002:a92:ab09:: with SMTP id v9mr3423818ilh.55.1620648325937; Mon, 10 May 2021 05:05:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620648325; cv=none; d=google.com; s=arc-20160816; b=Bu4FMvNfmCHy+j+iUD6UMcFkViP02U/JVxCNIyPWC7TdFG2SEymcAk4xEVEg9mamq6 /482eDdunIvoFKbZWvsE0+LI/BC7jU/fD334enamOlavqiFUr0UlhxcLT8p4ahKISEmZ pJeCTG/DpOypu8nik5VrrGEEwsVPxXYryBlXy13xaj3jA5qh8u6U1HbzUOmeTHc1qNtv CgbR0zVg2lI4DG2Cx+e15lENT1g5sZ17aBWCFuby9BrlF84E0X6oY5qMRHjG2egLj7FS zEku4C2QHmaL8jNkRt2AqqD32kg83EuETBpdgffWcpxD5kwo6KV88jyPzea0uTlmBQZK JgKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=8WvRXSEGpSUDg3IGDbDU5C/I0KQ7VoBNfW56KR9/HXU=; b=uYYw+jJboV8IXfzjxG7NLulIiXybPJC8FVOn3KSKYuQHopOr/5zTaJ5YCHoruB39gy OBxjnFy4CANSJYRBSAR5OLk7UIX0SXapPHMyUBvSESiQ1bgolr3DWJ/6bk5dxodIVEPk eQHX9qwP71wA/12RbVd5jA08AEWWVAua1lASVKJia1cmMf8abALDQvYGrNo0b7pW56LB JGwx6hiQcVU1tEpVEDp02GcFQaDINc875dRh9q6ncTPYLHgpWDM1ho3DHt+vTpx9Td7x MDZOkleL0j1oNzvLGi07ueL2SG+1vL/zZY8dR17iRiAerzUp4nUKbUJbsoF5QmijRNkE PQVw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=DsbLVOic; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z12si15745717jao.92.2021.05.10.05.05.12; Mon, 10 May 2021 05:05:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=DsbLVOic; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244505AbhEJL7M (ORCPT + 99 others); Mon, 10 May 2021 07:59:12 -0400 Received: from mail.kernel.org ([198.145.29.99]:46088 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235912AbhEJLG6 (ORCPT ); Mon, 10 May 2021 07:06:58 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 15BDD61624; Mon, 10 May 2021 10:56:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1620644218; bh=NnXrD86QDaepdkZjCNN7ZgN4nfylby90UqM9E5K6xzI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=DsbLVOicL8H1gZhHZArK7OEqaMdsF96mmROqTSTbf9BgANpbpNgWhFQXXOXuAD1Mu CVRwqxaknT1bikwo9leBdJShK4sI2QG4JZGplJXgxOOhGQZc6+LCxPA1XaTIGq0e8W d8LyLYCMGVP63mbqJiK+bYMd5nitbIzrzO9jQkgk= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Joe Thornber , Ming-Hung Tsai , Mike Snitzer Subject: [PATCH 5.11 336/342] dm space map common: fix division bug in sm_ll_find_free_block() Date: Mon, 10 May 2021 12:22:06 +0200 Message-Id: <20210510102021.211736963@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210510102010.096403571@linuxfoundation.org> References: <20210510102010.096403571@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Joe Thornber commit 5208692e80a1f3c8ce2063a22b675dd5589d1d80 upstream. This division bug meant the search for free metadata space could skip the final allocation bitmap's worth of entries. Fix affects DM thinp, cache and era targets. Cc: stable@vger.kernel.org Signed-off-by: Joe Thornber Tested-by: Ming-Hung Tsai Signed-off-by: Mike Snitzer Signed-off-by: Greg Kroah-Hartman --- drivers/md/persistent-data/dm-space-map-common.c | 2 ++ 1 file changed, 2 insertions(+) --- a/drivers/md/persistent-data/dm-space-map-common.c +++ b/drivers/md/persistent-data/dm-space-map-common.c @@ -339,6 +339,8 @@ int sm_ll_find_free_block(struct ll_disk */ begin = do_div(index_begin, ll->entries_per_block); end = do_div(end, ll->entries_per_block); + if (end == 0) + end = ll->entries_per_block; for (i = index_begin; i < index_end; i++, begin = 0) { struct dm_block *blk;