Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp2521155pxj; Mon, 10 May 2021 05:06:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxTtLPF8J6FoLTv1b1iTsPUbqFS9im7v+5AnkdybKSu2WPA2f1eYT+PeIseCCzL5JJi2lk9 X-Received: by 2002:a05:6e02:1b06:: with SMTP id i6mr7396070ilv.139.1620648325917; Mon, 10 May 2021 05:05:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620648325; cv=none; d=google.com; s=arc-20160816; b=QgYHJESuS6uxzs5vYaLMhiF+Pnzv08qtFigizGPfiyW78/gNiyPQNWwGlTR2VujEIX x0i3uGO9GDAhKhVkz1Ym7yTgaoTC6CfR3KRzAyOrdIZDhbNfgd6fP8IsIV1onh9iuv6K V5gKvi5AVRgFn5Yk7sr3mx8uMZA97fiqxVFLV7Yot7K97hpx8k10Xzc1NlRDCNgxyatL 1xhFnJxPrn7rbWQ+4KgBo0j8I1hHYDi3+cwx19irHdNRuOSnLd4PEOOp44jLOr/GPMuN zh0jkcopZCth+pEOD0zN9alBx1Adjm5ej0j4G/e95V+AzlbXP999nLMrNM8vbYXqn+rn JSXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=+rRvaC4cH2EqxKIUTV+uJLnMn706AQxsRsciOpYFR9k=; b=MHXvy/CnzUtECkzYzlgfLK6thlatSkL3YiLV7X9y0SBH8/PjPFwQFDHSDEDQbAV6DG iLzWwmok9Q/KJXehEWP5aSEh7cNGcze2+Qk+KszszZQBRnJGpzr6AGyD2lucUgyQDmc0 9g/zHvSkYSyTP7CU5glLZ3iuMqONVDpO6fahgdluge2tjWxPiuk2gUxaOw5FXGM15wuI 9MW+EB/gSAxgCjrTwBnQujrK7Nk0m8uGgC8D1spov4y8pqbpozvFnWD6WG4VoCLEOuCx EtSO+7UtlTAB33JWNGE8wGmUeztMjWnbYHSvfFsnC/FiVgf584J1bPOFwqrSHgLOyQ+V Uohw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=DPTjDIrH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k7si15324366ili.130.2021.05.10.05.05.12; Mon, 10 May 2021 05:05:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=DPTjDIrH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244350AbhEJL6y (ORCPT + 99 others); Mon, 10 May 2021 07:58:54 -0400 Received: from mail.kernel.org ([198.145.29.99]:45966 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235897AbhEJLGx (ORCPT ); Mon, 10 May 2021 07:06:53 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8E31261629; Mon, 10 May 2021 10:56:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1620644216; bh=Ll8FqHKYmyisncPLSUPpnG4ut9uGKguVRFBpQkyUufk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=DPTjDIrHeXVePPeWEWk62bgslod/cy9Aextx+4OH5sRsUSBm1apIRXRwErCAMCw8E X2I4Z5s2tYd2sMuc3l3SJr6t5f/vL7gAUzt0f6IsvfcbAsKVkuKx6e5/ULgOsfFMeV +y3zBsH72V5cts9Hhi9Ti8UvVxf+1RePA2UinN8Q= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Joe Thornber , Mike Snitzer Subject: [PATCH 5.11 335/342] dm persistent data: packed struct should have an aligned() attribute too Date: Mon, 10 May 2021 12:22:05 +0200 Message-Id: <20210510102021.181198108@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210510102010.096403571@linuxfoundation.org> References: <20210510102010.096403571@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Joe Thornber commit a88b2358f1da2c9f9fcc432f2e0a79617fea397c upstream. Otherwise most non-x86 architectures (e.g. riscv, arm) will resort to byte-by-byte access. Cc: stable@vger.kernel.org Signed-off-by: Joe Thornber Signed-off-by: Mike Snitzer Signed-off-by: Greg Kroah-Hartman --- drivers/md/persistent-data/dm-btree-internal.h | 4 ++-- drivers/md/persistent-data/dm-space-map-common.h | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-) --- a/drivers/md/persistent-data/dm-btree-internal.h +++ b/drivers/md/persistent-data/dm-btree-internal.h @@ -34,12 +34,12 @@ struct node_header { __le32 max_entries; __le32 value_size; __le32 padding; -} __packed; +} __attribute__((packed, aligned(8))); struct btree_node { struct node_header header; __le64 keys[]; -} __packed; +} __attribute__((packed, aligned(8))); /* --- a/drivers/md/persistent-data/dm-space-map-common.h +++ b/drivers/md/persistent-data/dm-space-map-common.h @@ -33,7 +33,7 @@ struct disk_index_entry { __le64 blocknr; __le32 nr_free; __le32 none_free_before; -} __packed; +} __attribute__ ((packed, aligned(8))); #define MAX_METADATA_BITMAPS 255 @@ -43,7 +43,7 @@ struct disk_metadata_index { __le64 blocknr; struct disk_index_entry index[MAX_METADATA_BITMAPS]; -} __packed; +} __attribute__ ((packed, aligned(8))); struct ll_disk; @@ -86,7 +86,7 @@ struct disk_sm_root { __le64 nr_allocated; __le64 bitmap_root; __le64 ref_count_root; -} __packed; +} __attribute__ ((packed, aligned(8))); #define ENTRIES_PER_BYTE 4 @@ -94,7 +94,7 @@ struct disk_bitmap_header { __le32 csum; __le32 not_used; __le64 blocknr; -} __packed; +} __attribute__ ((packed, aligned(8))); enum allocation_event { SM_NONE,