Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp2521849pxj; Mon, 10 May 2021 05:07:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyYdT9iKWPnoqMuyFPJniPVI+Qq1j86D1UO8uGpI2EmGI5L4UPxpoL5Sm9P//PWDlud2l/8 X-Received: by 2002:a17:906:11cc:: with SMTP id o12mr25609479eja.85.1620648338061; Mon, 10 May 2021 05:05:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620648338; cv=none; d=google.com; s=arc-20160816; b=sl7JS22+ned0wuJJmkkCuxUUObBnYxwMRSe8euTM+E4cpTnJV9iwl2zuZr9OycZLea otVaFfWU3+IqE5FcNofnNex8CV1focBYE6DgmjzE4etTKkq+Q85mntbwglBeTi6AF5dF AfP+Lgwbfq+jipjSNxI/12rTV6g2KGx+TwgcLlGeuLS+leOzMadq7DnGUOc4GejYLNzi Yr3uh7qH2gzQkK2uv5BtfHHJURa8vJGvjfHi6HfJhqJ8H3fud1/Kyghh57mYJVkHNl0w B3xkhGIvhRQv1hYNVYZ5A5U430tkNd/Tl82EihINhboyHoQVFh2bhdvJVlbyYwDDgTct tttw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=+91fx94ydy610uKDEJBxyKFm+wthB3YVc33fAkg60Ws=; b=xxZHTPpa9RlJN8oCvY3vORL/kwSpnQ/P/QZbE/9Aw0Mw8OjQik2MKdpi/gnYqUNuTh ZgbAZNiAT6xMVnxpY76gvLNoq3eggiUZmXyvtyLcIR7/C9C1J2WSoqS7XFoy6SHIpep8 8Wr8j4cz9qypPe5NL9JFgP9wwmYlIMxEzdt2tTS50JyzJ8QbJIEbq4DYpIsPu1PyVBBO p5if8scPAJbpEjedaeWb+lv456FuHNrDf4AxJJww3e1QKjeNNtsMnZ0P537+ODKBtoy5 KltkoV3D5IzJuaHXr7cBRiylQDh7IhE2WBfFw460m8PkA16kZeQXf2bobEr1ltqZVDK0 fOWw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=uBfxkZLM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ch13si7905233ejb.419.2021.05.10.05.05.12; Mon, 10 May 2021 05:05:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=uBfxkZLM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244320AbhEJL6r (ORCPT + 99 others); Mon, 10 May 2021 07:58:47 -0400 Received: from mail.kernel.org ([198.145.29.99]:45604 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235869AbhEJLGk (ORCPT ); Mon, 10 May 2021 07:06:40 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id CAF786157E; Mon, 10 May 2021 10:56:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1620644206; bh=Ga0GcZJ15+mCFyWQygC1n0QxlS2LBSHB5Xti+h6bYng=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uBfxkZLMa6T01w1HOGMxelaGbxFSm6gDSePY5FPpPrVxWKM9EGc31S0/V6ACiwep4 xanm7uz5yGWYYfNToVT7N5whjI/GJUhD//QEQE4U4pz9gLNjzKlM/8VIuDZJ7zA5Lj gSuNnWP9b9ruT+Ko1B9ooWOQYAhnE6bv32q22+6I= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Marek Vasut , Amitkumar Karwar , Angus Ainslie , "David S. Miller" , Jakub Kicinski , Kalle Valo , Karun Eagalapati , Martin Kepplinger , Sebastian Krzyszkowiak , Siva Rebbagondla , netdev@vger.kernel.org Subject: [PATCH 5.11 331/342] rsi: Use resume_noirq for SDIO Date: Mon, 10 May 2021 12:22:01 +0200 Message-Id: <20210510102021.038993300@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210510102010.096403571@linuxfoundation.org> References: <20210510102010.096403571@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Marek Vasut commit c434e5e48dc4e626364491455f97e2db0aa137b1 upstream. The rsi_resume() does access the bus to enable interrupts on the RSI SDIO WiFi card, however when calling sdio_claim_host() in the resume path, it is possible the bus is already claimed and sdio_claim_host() spins indefinitelly. Enable the SDIO card interrupts in resume_noirq instead to prevent anything else from claiming the SDIO bus first. Fixes: 20db07332736 ("rsi: sdio suspend and resume support") Signed-off-by: Marek Vasut Cc: Amitkumar Karwar Cc: Angus Ainslie Cc: David S. Miller Cc: Jakub Kicinski Cc: Kalle Valo Cc: Karun Eagalapati Cc: Martin Kepplinger Cc: Sebastian Krzyszkowiak Cc: Siva Rebbagondla Cc: netdev@vger.kernel.org Cc: stable@vger.kernel.org Signed-off-by: Kalle Valo Link: https://lore.kernel.org/r/20210327235932.175896-1-marex@denx.de Signed-off-by: Greg Kroah-Hartman --- drivers/net/wireless/rsi/rsi_91x_sdio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/wireless/rsi/rsi_91x_sdio.c +++ b/drivers/net/wireless/rsi/rsi_91x_sdio.c @@ -1513,7 +1513,7 @@ static int rsi_restore(struct device *de } static const struct dev_pm_ops rsi_pm_ops = { .suspend = rsi_suspend, - .resume = rsi_resume, + .resume_noirq = rsi_resume, .freeze = rsi_freeze, .thaw = rsi_thaw, .restore = rsi_restore,