Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932144AbWJWQcG (ORCPT ); Mon, 23 Oct 2006 12:32:06 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932169AbWJWQcF (ORCPT ); Mon, 23 Oct 2006 12:32:05 -0400 Received: from smtp.osdl.org ([65.172.181.4]:13277 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S932144AbWJWQcD (ORCPT ); Mon, 23 Oct 2006 12:32:03 -0400 Date: Mon, 23 Oct 2006 09:31:34 -0700 (PDT) From: Linus Torvalds To: Geert Uytterhoeven cc: Andi Kleen , Randy Dunlap , Stefan Richter , Al Viro , Alexey Dobriyan , Linux Kernel Development , linux-arch@vger.kernel.org Subject: Re: dealing with excessive includes In-Reply-To: Message-ID: References: <20061017005025.GF29920@ftp.linux.org.uk> <20061020091302.a2a85fb1.rdunlap@xenotime.net> <200610230059.23806.ak@suse.de> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1201 Lines: 36 On Mon, 23 Oct 2006, Geert Uytterhoeven wrote: > > > > We have tons of issues that depend on config variables and architecture > > details. > > Indeed, so the config variables and architecture details should be handled in > the include files, not in the (multiple) users of those include files. The point is - _verifying_ that is actually hard. If some inline function depends on a particular header, you'll have a hard time checking for that if there's an #ifdef around it. Which is not uncommon, we have things like: #ifdef CONFIG_PROCFS .. number of inline functions .. #else #define function1(a,b,c) do { } while (0) ... #endif so I'm just saying that "just compile it" is _not_ a way of verifying that the header file is complete - because it may well be complete for the particular config you're testing, but not for some other. So this is a hard problem. If it was easy, we'd not _have_ the problem in the first place. Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/