Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp2532442pxj; Mon, 10 May 2021 05:20:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyNHE1Fh5r/ApD8a3RKpaRY8qdbDypBhjbU1ADpIq9PQdjpb23dJCN8bp9Y2suiL/TPFEyH X-Received: by 2002:a05:6402:1357:: with SMTP id y23mr30299028edw.235.1620649103633; Mon, 10 May 2021 05:18:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620649103; cv=none; d=google.com; s=arc-20160816; b=RfOWm4Ti/cpg7c2aQlAD5iNeGGmDj5+iWgIRfBp5s9vuVPS6HlWTZrbCG8yNpXJbH5 FkuNeXIjDkVkfwRFTdVLciHbFuQ2ZkNylZ9kyxBmbuAwE8fg6orGhVt9Fuj2yZggKcy2 zogULWVGXkUtCRu9+NRcbVj0oPzxvMt5NsKmlyMjCD8j/1Wk7MeTV4Eb91arInZt02QE +0XNcScYXLVs/hMjNes8E5NwH/tTQjQ8LXF6GshAMf9PSJRAlN8EoMorfvFlohiqOO+s I5TONInLwihk1Z62drQ5VB/4lx9T0K385ddT3foni2nbPIyeslta7Ive1pTgA6hkZFtg fjdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=0af+DrcyOtMwVZcxYEm++jtYxYvnDM5/6xyzTJ0Hckw=; b=CjCBLT378Q4WhP/rb7gVL8dT+l2xOb9tZ+iZcLD3m0kaVTbZ5PqyzMi+yvhtnLuAr/ Vzdpc9igX4t+8/iO2zVUW/T9qawcf5UjvsFUlyRgcGzm1YvU5vuAsryLO0c+6+n030Pc H/MftflWkEGz7aOay+0uoKMgMdPDCC1fMc1YRwcuxhUpiRyFWmg22ret+4Is1HnCfNm9 +9GkSYlJMxNHYcSJEMVkSP87AvpdDNX1Fjp9Rs1TztfcsZxtQsjY/4xurJ8rtYbjTuRo BluDzc3p2qYHyEhYuh5ofQ9CGPV+0PgOkNg1xBImZTFuBuXCYuAW8/YZCU8LqI81N1GP gdLw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=wQfKzAhC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o8si3723652eji.749.2021.05.10.05.17.59; Mon, 10 May 2021 05:18:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=wQfKzAhC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344407AbhEJMPm (ORCPT + 99 others); Mon, 10 May 2021 08:15:42 -0400 Received: from mail.kernel.org ([198.145.29.99]:45870 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236229AbhEJLHn (ORCPT ); Mon, 10 May 2021 07:07:43 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 4A57661947; Mon, 10 May 2021 10:59:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1620644344; bh=9fjXaZfRHR0w5zmCUCwj7jr4vA5nsz+tF7A7OFdC44U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=wQfKzAhC4PQjUKxFnfR5nKIfXTJ77rsUk4EV6EUVtlx53t0W0V0dtECiR1uwELBIT tO7eoJheae9Fq5SfmI6A6JnfJ2OzHIZ/lxD7LjvlWDQ5tJb6vD/uL6wU1fOcQcP7jJ IMuZY1PkkhLB0zJXwVYO/jsHAGPYQ+0k40x+NkBw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Avri Altman , Adrian Hunter , Ulf Hansson Subject: [PATCH 5.12 045/384] mmc: block: Update ext_csd.cache_ctrl if it was written Date: Mon, 10 May 2021 12:17:14 +0200 Message-Id: <20210510102016.359604707@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210510102014.849075526@linuxfoundation.org> References: <20210510102014.849075526@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Avri Altman commit aea0440ad023ab0662299326f941214b0d7480bd upstream. The cache function can be turned ON and OFF by writing to the CACHE_CTRL byte (EXT_CSD byte [33]). However, card->ext_csd.cache_ctrl is only set on init if cache size > 0. Fix that by explicitly setting ext_csd.cache_ctrl on ext-csd write. Signed-off-by: Avri Altman Acked-by: Adrian Hunter Cc: stable@vger.kernel.org Link: https://lore.kernel.org/r/20210420134641.57343-3-avri.altman@wdc.com Signed-off-by: Ulf Hansson Signed-off-by: Greg Kroah-Hartman --- drivers/mmc/core/block.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) --- a/drivers/mmc/core/block.c +++ b/drivers/mmc/core/block.c @@ -573,6 +573,18 @@ static int __mmc_blk_ioctl_cmd(struct mm } /* + * Make sure to update CACHE_CTRL in case it was changed. The cache + * will get turned back on if the card is re-initialized, e.g. + * suspend/resume or hw reset in recovery. + */ + if ((MMC_EXTRACT_INDEX_FROM_ARG(cmd.arg) == EXT_CSD_CACHE_CTRL) && + (cmd.opcode == MMC_SWITCH)) { + u8 value = MMC_EXTRACT_VALUE_FROM_ARG(cmd.arg) & 1; + + card->ext_csd.cache_ctrl = value; + } + + /* * According to the SD specs, some commands require a delay after * issuing the command. */