Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp2538034pxj; Mon, 10 May 2021 05:27:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyMeA727bgxaAZ8FdEMYYYD0pHn1YllNEANwVOIf21PktkZC6cR70s5mcw2KGmx3w3V24K2 X-Received: by 2002:a50:fc91:: with SMTP id f17mr29163390edq.23.1620649656361; Mon, 10 May 2021 05:27:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620649656; cv=none; d=google.com; s=arc-20160816; b=zqarajuVBktdfQChfNN68ami8D+i7NoJ7SE54HW2Pzhi2X/AwfvZnYjpHNQXFwdsFA eVilag15qxGroIDaSMpKs+93xow6BWvrV/o3IVI7b2DZugKoKxvkGRoHOLn4ZvVYmXVA KOPUfdaIbV8VHf8x2gtpFuaYQT3SkuE0BlH1tRrWuZyFXeCURrsDZC0UemODl0rmffVs 3sWL6erwSIAKz8s67XQVAAt+ddV8e5oF50GCa497bUwppqjBid7sSMTNJs8eqWRSLUOQ 5EzdLNDnRF3GPcEla3WdrZY6oZx2fk36rP0Y6QRHctkw5LfbTODZc4Xwl5bWG/ZukhPa 3cIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=zml40eBnHnG3GEs2LzgOQxXHD9EEDelhmoqKgX2fGkQ=; b=g44gQG2sMbdLKsCxLt89QHpVHXsfMk7VsKcdCahAiJbgF8sWBVdCfpyhkw0qLOGCC4 QLoqyoLILawlhQZY27P946m9ZNWX6FFBfdWpsO7nN7Hf8Brb/4iTpTkfJId2DBGZimSX wzezLZfYX0xq+v98T4wFi6YGj2cxgmjxDaAolARUkEUK2bGZ1ThMWxCdB1dbzu3gkDap QVnQ9Xtsm1WfwKZlWBLt737KfMWJSq38cpJW8lxhAbFXjFg3XzYeD0DsmQQlaRMHleXb VyCn51kz3uIJh1NbBLLCaletqJ0XBhQTi5Dl9iMAMAXdYMOxbYZ/oGjlLYcbVK7mHtEH BgUQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=sUYm8r69; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id lo25si12836331ejb.456.2021.05.10.05.27.12; Mon, 10 May 2021 05:27:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=sUYm8r69; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344763AbhEJMRO (ORCPT + 99 others); Mon, 10 May 2021 08:17:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:44344 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230295AbhEJLIo (ORCPT ); Mon, 10 May 2021 07:08:44 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id EC139613C9; Mon, 10 May 2021 11:04:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1620644643; bh=797DPJgBYy0V1f03bvCENeGmNyA/WI0T8ZcsrmlXkx4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=sUYm8r69mF/TSqPeW4u/6FJ+J/daMcLIIDORRDYWbpUm7EawoOxkp0Nmc/+L/MydR n/T8Myy4r8mgu9ctH2hkzXHwoqJHujO6GqD652mD8dxczjHyuVU6720N6O7YnFHn3D XpPdzbPaDrkJFEWlyG5H5Cnev3y83h2U6ea7RkFE= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Mike Christie , Johannes Thumshirn , Chaitanya Kulkarni , "Martin K. Petersen" , Sasha Levin Subject: [PATCH 5.12 166/384] scsi: target: pscsi: Fix warning in pscsi_complete_cmd() Date: Mon, 10 May 2021 12:19:15 +0200 Message-Id: <20210510102020.354842301@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210510102014.849075526@linuxfoundation.org> References: <20210510102014.849075526@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Chaitanya Kulkarni [ Upstream commit fd48c056a32ed6e7754c7c475490f3bed54ed378 ] This fixes a compilation warning in pscsi_complete_cmd(): drivers/target/target_core_pscsi.c: In function ‘pscsi_complete_cmd’: drivers/target/target_core_pscsi.c:624:5: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body] ; /* XXX: TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE */ Link: https://lore.kernel.org/r/20210228055645.22253-5-chaitanya.kulkarni@wdc.com Reviewed-by: Mike Christie Reviewed-by: Johannes Thumshirn Signed-off-by: Chaitanya Kulkarni Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/target/target_core_pscsi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/target/target_core_pscsi.c b/drivers/target/target_core_pscsi.c index 9ee797b8cb7e..508b49b0eaf5 100644 --- a/drivers/target/target_core_pscsi.c +++ b/drivers/target/target_core_pscsi.c @@ -620,8 +620,9 @@ static void pscsi_complete_cmd(struct se_cmd *cmd, u8 scsi_status, unsigned char *buf; buf = transport_kmap_data_sg(cmd); - if (!buf) + if (!buf) { ; /* XXX: TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE */ + } if (cdb[0] == MODE_SENSE_10) { if (!(buf[3] & 0x80)) -- 2.30.2