Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp2538036pxj; Mon, 10 May 2021 05:27:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxUFtUxzZZdy/oOIO6IzOIxakEwJTEQwzITHB5OYQrgOVQgSujUeumxa7QOUpqinlPldM/n X-Received: by 2002:a17:906:158c:: with SMTP id k12mr2971700ejd.274.1620649656411; Mon, 10 May 2021 05:27:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620649656; cv=none; d=google.com; s=arc-20160816; b=VZ4zAg1e3JpW4L/PK+4BZZLrcs+w49UBFNJb8PEC3zKAMJXOwRiwRHrKneIfWppYbp ITA42xUUJdexpVy2t/kJ2BG09UHqfGi4epl0N2aK6ik7JwdVqd/Vts0G0JbK2+e+MXfG gbx8TY7Ihs0PSW+ayTe6Cbq7B30hMuNl11sEAx9NqgZQ7vMACfvFEq2v9Fv+hMvsKrfU zcIeCKBs0knBl1sMCcpFNiRRHMz8p7C9rUyfR75cvjw/+OEisHbOwXe6bnWnNQ8Zfrrs BjHlROzk/w6orHkr57dZmY8SJi7l0IL5b25LfEJO33TQCHveICDXIyx28ApsrkuikBh/ Kzkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=mDc5wWYpu3LUYoyNl2mHbAXSjUOpE858ozc2FvCt/b0=; b=fnwfMrxsurjR/87Qhxrjkm2qaaLlI0qsUM5wstk0EPAQ/wy02jPD7o2/ofnXt8k0Z3 +AY71XTPWpINGhRbT8zSCs8PnY0ymKQmHUrZt0q49BHYPQ+hcVuvK83tnlJ2go6smQ4c EcfBIL7Hfayqq+yWl2UxlpA77A4sYYDm3ZaFbb9l15x0fWtUYUtEE67/MXcZQW6SjG6W M3Zkq/zONcIAJKTVx3KHY+lzM7IUrEm5yB6CsBQMCgQEDZwKH/94P0FM0hg/Ez/x03Kk 23+l16AEsyhf9DfHjbJg1DxNR6B4r9YS+6inLIkcPDTdHwG+KTy1mdpqWkEXmBdmwNIE QHJg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=iaVVeZQw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ka25si7259266ejc.204.2021.05.10.05.27.12; Mon, 10 May 2021 05:27:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=iaVVeZQw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234393AbhEJMXi (ORCPT + 99 others); Mon, 10 May 2021 08:23:38 -0400 Received: from mail.kernel.org ([198.145.29.99]:48686 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236995AbhEJLLI (ORCPT ); Mon, 10 May 2021 07:11:08 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 1AD89613CA; Mon, 10 May 2021 11:06:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1620644773; bh=4+PkIHY2y6oqKlC6HY2EbZ4VSkUTCZHr2F48zrTGS6I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=iaVVeZQwBKZNLudrgsgd2c8VVNdK9OgMihSjKQWjBqsVpxDDPLE60ornyXr4wh2qC sg/KPxkPrG0kngkF1WHAs50L3UAclYHoMBQfOGHT4K9r4zGAttShB0eTEiD5hSaYw4 O87nXjj00YVil3/G0rk9imSqfQkqFRE/j9Rb7WKA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Scott Teel , Scott Benesh , Kevin Barnett , Murthy Bhat , Don Brace , "Martin K. Petersen" , Sasha Levin Subject: [PATCH 5.12 217/384] scsi: smartpqi: Correct request leakage during reset operations Date: Mon, 10 May 2021 12:20:06 +0200 Message-Id: <20210510102022.049209088@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210510102014.849075526@linuxfoundation.org> References: <20210510102014.849075526@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Murthy Bhat [ Upstream commit b622a601a13ae5974c5b0aeecb990c224b8db0d9 ] While failing queued I/Os in TMF path, there was a request leak and hence stale entries in request pool with ref count being non-zero. In shutdown path we have a BUG_ON to catch stuck I/O either in firmware or in the driver. The stale requests caused a system crash. The I/O request pool leakage also lead to a significant performance drop. Link: https://lore.kernel.org/r/161549370379.25025.12793264112620796062.stgit@brunhilda Reviewed-by: Scott Teel Reviewed-by: Scott Benesh Reviewed-by: Kevin Barnett Signed-off-by: Murthy Bhat Signed-off-by: Don Brace Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/smartpqi/smartpqi_init.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/scsi/smartpqi/smartpqi_init.c b/drivers/scsi/smartpqi/smartpqi_init.c index 3795804ea869..52e4d5618dc7 100644 --- a/drivers/scsi/smartpqi/smartpqi_init.c +++ b/drivers/scsi/smartpqi/smartpqi_init.c @@ -5488,6 +5488,8 @@ static void pqi_fail_io_queued_for_device(struct pqi_ctrl_info *ctrl_info, list_del(&io_request->request_list_entry); set_host_byte(scmd, DID_RESET); + pqi_free_io_request(io_request); + scsi_dma_unmap(scmd); pqi_scsi_done(scmd); } @@ -5524,6 +5526,8 @@ static void pqi_fail_io_queued_for_all_devices(struct pqi_ctrl_info *ctrl_info) list_del(&io_request->request_list_entry); set_host_byte(scmd, DID_RESET); + pqi_free_io_request(io_request); + scsi_dma_unmap(scmd); pqi_scsi_done(scmd); } -- 2.30.2