Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp2538176pxj; Mon, 10 May 2021 05:27:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx6q3gwWKfgJLxd+1GklT8JQPqI2vWftN38rcI33J44Im4zCH/uhTkWfVirkGNFolF2Zw+k X-Received: by 2002:a05:6602:70d:: with SMTP id f13mr18642639iox.16.1620649668188; Mon, 10 May 2021 05:27:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620649668; cv=none; d=google.com; s=arc-20160816; b=lZLM80qv8BEVTsa5TTXID1Rb4pxhaygDsZNFbCw1akUYa1Oq+cFA1pdVCnBPhN4unW jDl87Ea5tx8YiMCls9DEHmF0spINvpMvQ2+sLM9Jro4jVsJeQ8ApQvT2pnNr2BjeXzjk XAxb5n0TMHFl6b+Ys2aeazmoJOC/p/nhVy7OzRy3A9o0ecR+o2vnADTzXj9643BY/Msw blkX6kkOSgA8x0MHHSFeahg5D4IGdQIqOQDyjt5skAG7ohwc19PYdI8MsefGJh5uzDqT n5Bwq85vOSInYz7VIeuZmt1ez63HYjOJGfl7XbsfneLbRLw1BSXkOdO79HO7PxXP1NQp QD9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=gUOMwZqNlmYDjCDuNI2oaERQO/PeEz7djNFwiugYc04=; b=ckumKYN/YeS2jsRYr4PXGcebLX/bmhWrzsxwqyMqrEexzMFcwaP/VEF6kdzqIiS6AQ 3AKkTwxkEmxAW1HIKmUIqzQXmAcnarGjWcRkU68MdiS5tlFPKRz3glJJRikJ+7m6ZGA7 DBv9j3oyxSslqIXhzAyKNRVwmqDiwpFDW/T3Gdjga/4pLiS5vCX3Bf4Oi3mOvj/w1srJ 9ECFtIbA+DTls7oBqBubLeHsuZF/IQzD5P/brZiFhBxI4g5Wry0MBTfcQvetioX4uh3X NPcIqN7kWaWql3Y6s5aD1Di2c8ePCbFVndauMwnbNYXF1oDhkUsphglxYuEQ52R6t8Pz mAZA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=A8YLpQsB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o21si10808571jat.63.2021.05.10.05.27.36; Mon, 10 May 2021 05:27:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=A8YLpQsB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345004AbhEJMVG (ORCPT + 99 others); Mon, 10 May 2021 08:21:06 -0400 Received: from mail.kernel.org ([198.145.29.99]:46276 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235086AbhEJLKF (ORCPT ); Mon, 10 May 2021 07:10:05 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 0E08E613C5; Mon, 10 May 2021 11:05:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1620644719; bh=vhNdZITQLLu1Vqwt/HaWW/3rsi9z4orMusNDvuWFim8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=A8YLpQsBWjlUk0FeOLrGLo0HBJNAXvHnR/z0XXgY4/B/hvDW+Apx/mHRzAjkjJfLT WMyXTqHO2hASkRbX0OwWjG9jVfrBn5XCxKMt0/Zq3cVH9vC9Srmey2FZ0a+JxGhaP2 RMuPEWl73CQUA9wuD8WfK0IMKOpELLnsbxdMOd50= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dmitry Vyukov , syzbot+4fc21a003c8332eb0bdd@syzkaller.appspotmail.com, Rodrigo Siqueira , Melissa Wen , Haneen Mohammed , Daniel Vetter , David Airlie , dri-devel@lists.freedesktop.org, Sasha Levin Subject: [PATCH 5.12 197/384] drm/vkms: fix misuse of WARN_ON Date: Mon, 10 May 2021 12:19:46 +0200 Message-Id: <20210510102021.375864953@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210510102014.849075526@linuxfoundation.org> References: <20210510102014.849075526@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dmitry Vyukov [ Upstream commit b4142fc4d52d051d4d8df1fb6c569e5b445d369e ] vkms_vblank_simulate() uses WARN_ON for timing-dependent condition (timer overrun). This is a mis-use of WARN_ON, WARN_ON must be used to denote kernel bugs. Use pr_warn() instead. Signed-off-by: Dmitry Vyukov Reported-by: syzbot+4fc21a003c8332eb0bdd@syzkaller.appspotmail.com Cc: Rodrigo Siqueira Cc: Melissa Wen Cc: Haneen Mohammed Cc: Daniel Vetter Cc: David Airlie Cc: dri-devel@lists.freedesktop.org Cc: linux-kernel@vger.kernel.org Acked-by: Melissa Wen Signed-off-by: Melissa Wen Link: https://patchwork.freedesktop.org/patch/msgid/20210320132840.1315853-1-dvyukov@google.com Signed-off-by: Sasha Levin --- drivers/gpu/drm/vkms/vkms_crtc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/vkms/vkms_crtc.c b/drivers/gpu/drm/vkms/vkms_crtc.c index 0443b7deeaef..758d8a98d96b 100644 --- a/drivers/gpu/drm/vkms/vkms_crtc.c +++ b/drivers/gpu/drm/vkms/vkms_crtc.c @@ -18,7 +18,8 @@ static enum hrtimer_restart vkms_vblank_simulate(struct hrtimer *timer) ret_overrun = hrtimer_forward_now(&output->vblank_hrtimer, output->period_ns); - WARN_ON(ret_overrun != 1); + if (ret_overrun != 1) + pr_warn("%s: vblank timer overrun\n", __func__); spin_lock(&output->lock); ret = drm_crtc_handle_vblank(crtc); -- 2.30.2