Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp2543088pxj; Mon, 10 May 2021 05:34:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy45lAkL/okWEuvKFiE2pLVT+kZBRAwHJLNFEmh3KFrhe6nKmToqnn3ueszcxNiMVul5lzc X-Received: by 2002:aa7:c2d2:: with SMTP id m18mr28323587edp.96.1620650049327; Mon, 10 May 2021 05:34:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620650049; cv=none; d=google.com; s=arc-20160816; b=dOKjLlIojjBcwEMg7WwLplevVNndzC1lXYKWMbn5WtM0sjiBDCNTAwBZjhbs95CAkH eIWU1XaYQj5EU2m7zRpfnEtrQgc6iW41EHG9Op3H4v022oGh+LKmAh8Xh5knQlRdZYIP Qa4sCNVYEVbxk9fzxv0cqqVhaV/Gn1XkNiISWst0bwk+PfpDpwCmcXRsZ2R5IEaFS6gR MEmSSX/lE/lXUR0VYUvDYQ3ju66kQvmn+3udN6xf6I5ZaoxTddVwAPQ40sy4CEnOWmWZ iN9Q0jU2MUScU9A+hUqI1rSoxkp7lu8G9E/8jsFsh+OoIXGtsGVmlI6anDNpISCDI7sg ctFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=daNLMkbsUL9hC4nlEbV89i6Jx03xK12BxglS3OupnXw=; b=wv/pZ792muDv4QatN6uxFOfe/MXhTa/B0zOUmsQpaP1Gfrn5C6zX3GBiZFfEH28RpM sEdaj9AbWoW5WvZZjLpCJdIrlabUoZuqkpRPB6NULFsdq/zcs3ge84W4BoeuCTpxmISD 5z8z/PZlX2XUyIcguGf3cxylF0lLMN6Wd3R0Oq/QKuLZYPzG4CJ1Nk6zPeyEeaODYuEZ l/vS2xbv+iWULvWL9HvgGq4mUD6DLe7GUCtIc4S52oI0c0AtXstpq22zc+q5w6jZkm+L TlkNCR6ZRfPveUT356Dw7kjSlQpa0s2oFb83QHAEexlTRIjpf180qYuOyK4yvK/Oclju 41Fw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="lcY1/q/B"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u12si14264671eda.121.2021.05.10.05.33.23; Mon, 10 May 2021 05:34:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="lcY1/q/B"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344909AbhEJMUz (ORCPT + 99 others); Mon, 10 May 2021 08:20:55 -0400 Received: from mail.kernel.org ([198.145.29.99]:46846 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233708AbhEJLJW (ORCPT ); Mon, 10 May 2021 07:09:22 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 478E4610C9; Mon, 10 May 2021 11:05:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1620644702; bh=7srYcspVMaQu6rWVBDD2fDnGG5ZgedcliWdsa+JRC5U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lcY1/q/BHQyr7KuwPRAnRt3dqDhBB+bFXVRGvAv1XFtwrX/v5gKWJd+kL7x3VQboR 0qyGRHNQ+VMYlKSxGe2/Iw5eMBgfu0Z6BfqoQxhVZiKwGBagu5SeICrmktChIYqSo1 Jm8j2skGReUxEyy2AHgDoBYyXS1O/0gTAxEaTec8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dick Kennedy , James Smart , "Martin K. Petersen" , Sasha Levin Subject: [PATCH 5.12 154/384] scsi: lpfc: Fix incorrect dbde assignment when building target abts wqe Date: Mon, 10 May 2021 12:19:03 +0200 Message-Id: <20210510102019.962226249@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210510102014.849075526@linuxfoundation.org> References: <20210510102014.849075526@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: James Smart [ Upstream commit 9302154c07bff4e7f7f43c506a1ac84540303d06 ] The wqe_dbde field indicates whether a Data BDE is present in Words 0:2 and should therefore should be clear in the abts request wqe. By setting the bit we can be misleading fw into error cases. Clear the wqe_dbde field. Link: https://lore.kernel.org/r/20210301171821.3427-2-jsmart2021@gmail.com Co-developed-by: Dick Kennedy Signed-off-by: Dick Kennedy Signed-off-by: James Smart Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/lpfc/lpfc_nvmet.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_nvmet.c b/drivers/scsi/lpfc/lpfc_nvmet.c index bb2a4a0d1295..a3fd959f7431 100644 --- a/drivers/scsi/lpfc/lpfc_nvmet.c +++ b/drivers/scsi/lpfc/lpfc_nvmet.c @@ -3304,7 +3304,6 @@ lpfc_nvmet_unsol_issue_abort(struct lpfc_hba *phba, bf_set(wqe_rcvoxid, &wqe_abts->xmit_sequence.wqe_com, xri); /* Word 10 */ - bf_set(wqe_dbde, &wqe_abts->xmit_sequence.wqe_com, 1); bf_set(wqe_iod, &wqe_abts->xmit_sequence.wqe_com, LPFC_WQE_IOD_WRITE); bf_set(wqe_lenloc, &wqe_abts->xmit_sequence.wqe_com, LPFC_WQE_LENLOC_WORD12); -- 2.30.2