Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp2548601pxj; Mon, 10 May 2021 05:41:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwiVqPWXkV32GdEwqaEfwVdWdJhFEhjjb3t5D2q3gaQjgCPA6Wx5s3q4G5uJDV1W/wiUrPV X-Received: by 2002:a17:906:7fd2:: with SMTP id r18mr21370767ejs.78.1620650501975; Mon, 10 May 2021 05:41:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620650501; cv=none; d=google.com; s=arc-20160816; b=ClXWFn4wXuJ1Wrm5bdRFuv9GM9FNE33p8eUxamTUlWQRJE/37OTujzzVeBPZz3VPEK PZiTkDSPHOJ3PC10yqT4u0F4/MROLzKe+5qDmyJJF3xPpdW/H/TpPUASautw7vOFi0z3 ys96T+i9X8A0FcTRiDnrGZxK6XtEsc4Y8BF1x8525WxQyZOrRxrnEqcusUF8KgfFWFMu Jlz6dMP0YddrAUrjfdfuI6PClKnMWQG5jeXkdeaKtTavaAM4s6tMbfPOrU+mkSEuKD2q 8daoztkOa219vDKWmp/TH0SdO3r/ykZow6GP6zXi8+P3NX2Enu62vN6pwKuRunZpxx2P g5Nw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=jnqwtEPfnxQmD7TtiBC83cExiJnxlHKBC3zqopS5YkI=; b=K0HNJByeXb/23/9S++KtnKDXF399GJqS0P3UoOU+XVlnbQ9L5+jRdYk7Gg8Bp2nJPv ZJq0AOorkuIRIpD3KQ6Hs4Cq59HSMSvu8XyOTeIbmULYYoT8PMb3EgHMXjGabOWB6tj0 bZVZtRQnu0Rr3KBFkHhsLljR4QEL8Y7Lmvgm3DOdGgFg/4XoD3HyITvIPSAXksmGumwe oLVF3znqPuG+LXJUUlxccEq37MMCELA6swAGUOHkCYSQ6lSGllbOuorsL0DdkbCMtWyL OzllSXaQc1bbQjUR6riOgBHroPO8TeGw6pyzog5gSwxosULZxwpRTteRK3jTd/7L4N1C H/uQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Sg7Zes22; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w24si12900846ejb.752.2021.05.10.05.41.18; Mon, 10 May 2021 05:41:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Sg7Zes22; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346952AbhEJMdD (ORCPT + 99 others); Mon, 10 May 2021 08:33:03 -0400 Received: from mail.kernel.org ([198.145.29.99]:54928 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230465AbhEJLLu (ORCPT ); Mon, 10 May 2021 07:11:50 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id E191561627; Mon, 10 May 2021 11:09:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1620644949; bh=HYu738Z9hfd84mR0bu7eMoQor2MK106Intwa8Fm57JE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Sg7Zes22tgXtCl1CA0bLcYsR8yoIBqHuKlyPY739AMdahuKoR4F1YrkIE4BQGv4rs 69fpPZuPyaHIUv+0plfe0qRq0qeLrkT8ul+wtkmfliN97Qr0Q6a9OqA0vzmT+BLNXL fo/smD4okNwrMtqvuD06SBxDjvDkVJpRH0UDqVRA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Luis Henriques , Stefan Hajnoczi , Vivek Goyal , Miklos Szeredi Subject: [PATCH 5.12 289/384] virtiofs: fix memory leak in virtio_fs_probe() Date: Mon, 10 May 2021 12:21:18 +0200 Message-Id: <20210510102024.335554759@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210510102014.849075526@linuxfoundation.org> References: <20210510102014.849075526@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Luis Henriques commit c79c5e0178922a9e092ec8fed026750f39dcaef4 upstream. When accidentally passing twice the same tag to qemu, kmemleak ended up reporting a memory leak in virtiofs. Also, looking at the log I saw the following error (that's when I realised the duplicated tag): virtiofs: probe of virtio5 failed with error -17 Here's the kmemleak log for reference: unreferenced object 0xffff888103d47800 (size 1024): comm "systemd-udevd", pid 118, jiffies 4294893780 (age 18.340s) hex dump (first 32 bytes): 00 00 00 00 ad 4e ad de ff ff ff ff 00 00 00 00 .....N.......... ff ff ff ff ff ff ff ff 80 90 02 a0 ff ff ff ff ................ backtrace: [<000000000ebb87c1>] virtio_fs_probe+0x171/0x7ae [virtiofs] [<00000000f8aca419>] virtio_dev_probe+0x15f/0x210 [<000000004d6baf3c>] really_probe+0xea/0x430 [<00000000a6ceeac8>] device_driver_attach+0xa8/0xb0 [<00000000196f47a7>] __driver_attach+0x98/0x140 [<000000000b20601d>] bus_for_each_dev+0x7b/0xc0 [<00000000399c7b7f>] bus_add_driver+0x11b/0x1f0 [<0000000032b09ba7>] driver_register+0x8f/0xe0 [<00000000cdd55998>] 0xffffffffa002c013 [<000000000ea196a2>] do_one_initcall+0x64/0x2e0 [<0000000008f727ce>] do_init_module+0x5c/0x260 [<000000003cdedab6>] __do_sys_finit_module+0xb5/0x120 [<00000000ad2f48c6>] do_syscall_64+0x33/0x40 [<00000000809526b5>] entry_SYSCALL_64_after_hwframe+0x44/0xae Cc: stable@vger.kernel.org Signed-off-by: Luis Henriques Fixes: a62a8ef9d97d ("virtio-fs: add virtiofs filesystem") Reviewed-by: Stefan Hajnoczi Reviewed-by: Vivek Goyal Signed-off-by: Miklos Szeredi Signed-off-by: Greg Kroah-Hartman --- fs/fuse/virtio_fs.c | 1 + 1 file changed, 1 insertion(+) --- a/fs/fuse/virtio_fs.c +++ b/fs/fuse/virtio_fs.c @@ -896,6 +896,7 @@ static int virtio_fs_probe(struct virtio out_vqs: vdev->config->reset(vdev); virtio_fs_cleanup_vqs(vdev, fs); + kfree(fs->vqs); out: vdev->priv = NULL;