Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp2554551pxj; Mon, 10 May 2021 05:49:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxBG44snUgtWe4VbHx1aIYsEhSljXXUZhhZSz7xuyRLdBiXSUSveYmneEkpQcDAQv8aZ/pZ X-Received: by 2002:a17:906:48d2:: with SMTP id d18mr26004134ejt.9.1620650986284; Mon, 10 May 2021 05:49:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620650986; cv=none; d=google.com; s=arc-20160816; b=bWOA5WPk4eA9G/Dbmc19jzsjv+u7jQKM/vydo8UH7dmQ3ogmxLAQrjXa/c5M3P+ApI DaI4TsODF3rwGOIDxTEP39HjXOL+rW6pLnHEwKr69n7tjS8mqTtKpJxRSHebx5zknyOi 6iXVHo6qKZ2J9b7ogyLZHOM89sDTJegbkNktLESQmLvV+Z+3ZT/8/KO9CTO42Wn8Bj9W BMLrH7Fk2Dl4CsyxzUCZjj+X/SY+KnQ3GoJi07ECgwJR8B+j3c86MH1iH6dZ1TNRP3tD fH1Ye7EToB633m5TcXAmbFIVb3y3XVBb4zRcRk0wUuYvW+6SQHHIHUrG5tcFWClZbRL6 vR3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=+91fx94ydy610uKDEJBxyKFm+wthB3YVc33fAkg60Ws=; b=LgWhgfx0s2WEXaDelOrQcHFy/BgMpsPvP37fdCZQustEhwdRZ7+qo7Mb1qEPzuMgZT gRPOEzlYQosQh1iYDgsjH34h+GjF4GtxNEzILdX6ztApjcjdI4Ds72y/2lHAz0o5vWN8 S1d424vttaJul++8XMKdIc5HMNwPuSA72WjwmvRgSgLY237bTvWap79o1MPaTk9THs6j HZJn4oFMEWNbKHYqHLzcwshEPLF+wAkZ26fVvpgIDe3gK4niVJKqmPc+i3vXkUDGrXZO xcvwfbvfi/cm0AqIIz1JOa6hMWaqKpSSbkNZlsBRdecRmJTiGfkVi+JpZ8V2fWkiuhPG JSkg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=E8MWQ5lo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id gs19si12900453ejc.707.2021.05.10.05.49.16; Mon, 10 May 2021 05:49:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=E8MWQ5lo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241340AbhEJMoO (ORCPT + 99 others); Mon, 10 May 2021 08:44:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:56146 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238089AbhEJLRB (ORCPT ); Mon, 10 May 2021 07:17:01 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 6EACF61628; Mon, 10 May 2021 11:12:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1620645150; bh=Ga0GcZJ15+mCFyWQygC1n0QxlS2LBSHB5Xti+h6bYng=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=E8MWQ5loY0cr3fVcfFPxgMwbjwtk2NishDWyFIzty1O8VlQVyq1ZTwYzqieSXPQkS G21OHGwfbVnsN9Ip6BuYS0xVjOg090xU9QZ4nBnP9+Bc8n4uDD39ie7RijNujqhnNR 31OC2g7KaicmGEauY8k9Aanuc6gq+P4LyLIrs1w4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Marek Vasut , Amitkumar Karwar , Angus Ainslie , "David S. Miller" , Jakub Kicinski , Kalle Valo , Karun Eagalapati , Martin Kepplinger , Sebastian Krzyszkowiak , Siva Rebbagondla , netdev@vger.kernel.org Subject: [PATCH 5.12 372/384] rsi: Use resume_noirq for SDIO Date: Mon, 10 May 2021 12:22:41 +0200 Message-Id: <20210510102027.031476939@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210510102014.849075526@linuxfoundation.org> References: <20210510102014.849075526@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Marek Vasut commit c434e5e48dc4e626364491455f97e2db0aa137b1 upstream. The rsi_resume() does access the bus to enable interrupts on the RSI SDIO WiFi card, however when calling sdio_claim_host() in the resume path, it is possible the bus is already claimed and sdio_claim_host() spins indefinitelly. Enable the SDIO card interrupts in resume_noirq instead to prevent anything else from claiming the SDIO bus first. Fixes: 20db07332736 ("rsi: sdio suspend and resume support") Signed-off-by: Marek Vasut Cc: Amitkumar Karwar Cc: Angus Ainslie Cc: David S. Miller Cc: Jakub Kicinski Cc: Kalle Valo Cc: Karun Eagalapati Cc: Martin Kepplinger Cc: Sebastian Krzyszkowiak Cc: Siva Rebbagondla Cc: netdev@vger.kernel.org Cc: stable@vger.kernel.org Signed-off-by: Kalle Valo Link: https://lore.kernel.org/r/20210327235932.175896-1-marex@denx.de Signed-off-by: Greg Kroah-Hartman --- drivers/net/wireless/rsi/rsi_91x_sdio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/wireless/rsi/rsi_91x_sdio.c +++ b/drivers/net/wireless/rsi/rsi_91x_sdio.c @@ -1513,7 +1513,7 @@ static int rsi_restore(struct device *de } static const struct dev_pm_ops rsi_pm_ops = { .suspend = rsi_suspend, - .resume = rsi_resume, + .resume_noirq = rsi_resume, .freeze = rsi_freeze, .thaw = rsi_thaw, .restore = rsi_restore,