Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp2555355pxj; Mon, 10 May 2021 05:50:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz32ngr9uu23jBT58pNASUKyTRQkXiib9Q+Wgoel3u1t/vtOE3x8XE6kxs5FYEmqw/g3ubU X-Received: by 2002:a17:906:a44d:: with SMTP id cb13mr25132874ejb.107.1620651053469; Mon, 10 May 2021 05:50:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620651053; cv=none; d=google.com; s=arc-20160816; b=YKFt1dpR15vhHTemYWMbG2YfjYxzr4ayUvIKDUoB5rPER66Vy5WueW9P0E6OvgAkVh E54WJjDkkSQwMI55myfv9xZzr4t655vrkEzkGQ8foHopSyWYkVwRQkRZO2dW0hH4ufp5 ziK6kYF3MT6qTnIAqTCMWqCGKkZFXmPG4q8mDaFE61Y8YLTcATZ7xKPt3DDvgeZJ9Ntc DC1Of2p026xA53R3EFVM2b4zxET9gVa69oy2aixOyIOSukzPxooiF+OAyrfAVQbj/KHh FMCtvpFE1C5/RiW+Lb6a0FOzwam/hvAiV0WjAnaN0xXZKk9Arb7el64K/z8NmarKGQSR AfjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=jBqxMd/LcJTtKC8/aRjCyge/btKiy18ZBIf7QL4QpxE=; b=c3uJkqy1DYvS5LTQ/oMuth/8K+nfP/wwalhlrfjA0D4+dCSR7QVDNQg9ZbLItikXez h3/WX85OZoc8bhRbBHJw3xlqgV+p96IrSj0LPiehgl8xNB6ctMuu0k50lY9yamB3OQHk Bpbx6EENbdOPW/w27oJnTDKd2KNowVUQ7gysDYJTzT5aSXrXLCesniy9ocJCrQjSVlgj JPppqANhP8tiFz/uiDmhfWOhINtxj7yshGgER/cLbjq6toOTtyX7WaHlGV5L6TAWppWw nK5NlXnapf07vKEaVEW/itnyh0pVL12Wv1yXxbXYxBKg5XOJARDEGx8KzsrMzZQxwRIr xOqQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=pl3s8Kv9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e14si10658461edz.320.2021.05.10.05.50.30; Mon, 10 May 2021 05:50:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=pl3s8Kv9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346420AbhEJMpM (ORCPT + 99 others); Mon, 10 May 2021 08:45:12 -0400 Received: from mail.kernel.org ([198.145.29.99]:34962 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238200AbhEJLRN (ORCPT ); Mon, 10 May 2021 07:17:13 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 94F906186A; Mon, 10 May 2021 11:12:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1620645170; bh=L4Z/lavsAkh015cOpILC8zaDta2Yugo6DqHJ9fBvJK8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=pl3s8Kv9BOD4gNjVOJmUfGakismcGd8zF+fFuIVyG6ReJRoNUYINalNqJSwMNfP8q VjIZYMjdJnw91cDQJ+0UJbE1HEXVpLMtI5ceP9XUtMDzhEtbi3iP0FN57DPBc6ZiuO n8YawntZ6mON3jx9T5+AcaZVzJgOG9D4ygJxpDbc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, syzbot+7f09440acc069a0d38ac@syzkaller.appspotmail.com, Peilin Ye , Mauro Carvalho Chehab Subject: [PATCH 5.12 346/384] media: dvbdev: Fix memory leak in dvb_media_device_free() Date: Mon, 10 May 2021 12:22:15 +0200 Message-Id: <20210510102026.174681853@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210510102014.849075526@linuxfoundation.org> References: <20210510102014.849075526@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Peilin Ye commit bf9a40ae8d722f281a2721779595d6df1c33a0bf upstream. dvb_media_device_free() is leaking memory. Free `dvbdev->adapter->conn` before setting it to NULL, as documented in include/media/media-device.h: "The media_entity instance itself must be freed explicitly by the driver if required." Link: https://syzkaller.appspot.com/bug?id=9bbe4b842c98f0ed05c5eed77a226e9de33bf298 Link: https://lore.kernel.org/linux-media/20201211083039.521617-1-yepeilin.cs@gmail.com Cc: stable@vger.kernel.org Fixes: 0230d60e4661 ("[media] dvbdev: Add RF connector if needed") Reported-by: syzbot+7f09440acc069a0d38ac@syzkaller.appspotmail.com Signed-off-by: Peilin Ye Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Greg Kroah-Hartman --- drivers/media/dvb-core/dvbdev.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/media/dvb-core/dvbdev.c +++ b/drivers/media/dvb-core/dvbdev.c @@ -241,6 +241,7 @@ static void dvb_media_device_free(struct if (dvbdev->adapter->conn) { media_device_unregister_entity(dvbdev->adapter->conn); + kfree(dvbdev->adapter->conn); dvbdev->adapter->conn = NULL; kfree(dvbdev->adapter->conn_pads); dvbdev->adapter->conn_pads = NULL;