Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp2556507pxj; Mon, 10 May 2021 05:52:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyBuHeFfLurHbU1PXJQp9qPhKcAs+q0sAdIxwm3LfiC4CpInKbro/IMSFjSmwmNCIma/enk X-Received: by 2002:a05:6402:d05:: with SMTP id eb5mr29027015edb.6.1620651150961; Mon, 10 May 2021 05:52:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620651150; cv=none; d=google.com; s=arc-20160816; b=G7rfu+l5rri1PL5DkLOMd8dGTG4Sx4DQwtHjLxx1zU0mbMb+Lc/MiipEYJlGR10oXj CbnY0V8eMacZyHFiod7iKVpR83GSsO1OnXYcckj1AYxKS5yW88MY1JZqjqanJLjUI5gs NKxEedMiHkPAvM/d0IUl1LztkXmv8jzsIZoNnHE+D944yFCMGD6nUN8xxw4x8bjxeha7 pNdyYlIX9SQeYsp4a9vP6trqvr71oRInGXCik85TzgV2eELhYavGEEbvUqT/N/7udIoe wBHF2MOuiGs135mpXoQgNZ0G22Vuyy37byKtjBlABZ9I7dCrR93T6fXHy0UXjM6fiAWf awEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=7c3+a1F/grGR0f5O3z+eeyowTjAW5u+JC74bflvNTfk=; b=h+KDq0jmUxj30rneDpswK1XMmllDU/GbofA8uD9E9ZmfULTFtjd+Mk4mrse5LAb4Z+ h+I7oWhAnZlZRTOrAX9+WPJixfJoezE05ZY1aHPM6pWWyyEutlcclQuYRn33QanNd/Ki ze+xZbiRyLyrHu5gD0wwiT0RzK67dYX9RA6YmkADJH6j/573CVufcYfcaLb2kZZmNena 9BFUlBuDL+rLw1W1JyvrYqUdgc7OzOg7a8dSsYw8RfKcB9YegXOmGQh7xtsMX13rtq0a Q4rcbv8jAqr+5VsbS5qSOfY7WTLuC52eAC+HUxSUIODBCScmVVuHelyYlNB2z5fR/hR4 puVw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id se25si13494124ejb.310.2021.05.10.05.52.07; Mon, 10 May 2021 05:52:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239908AbhEJMwO (ORCPT + 99 others); Mon, 10 May 2021 08:52:14 -0400 Received: from jabberwock.ucw.cz ([46.255.230.98]:55146 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343499AbhEJMNq (ORCPT ); Mon, 10 May 2021 08:13:46 -0400 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 806821C0B79; Mon, 10 May 2021 14:12:40 +0200 (CEST) Date: Mon, 10 May 2021 14:12:40 +0200 From: Pavel Machek To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, "David E. Box" , Hans de Goede , Rajneesh Bhardwaj , Sasha Levin Subject: Re: [PATCH 5.10 108/299] platform/x86: intel_pmc_core: Dont use global pmcdev in quirks Message-ID: <20210510121240.GD3547@duo.ucw.cz> References: <20210510102004.821838356@linuxfoundation.org> <20210510102008.507160403@linuxfoundation.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="EY/WZ/HvNxOox07X" Content-Disposition: inline In-Reply-To: <20210510102008.507160403@linuxfoundation.org> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --EY/WZ/HvNxOox07X Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > From: David E. Box >=20 > [ Upstream commit c9f86d6ca6b5e23d30d16ade4b9fff5b922a610a ] >=20 > The DMI callbacks, used for quirks, currently access the PMC by getting > the address a global pmc_dev struct. Instead, have the callbacks set a > global quirk specific variable. In probe, after calling dmi_check_system(= ), > pass pmc_dev to a function that will handle each quirk if its variable > condition is met. This allows removing the global pmc_dev later. This does not fix a bug.. it is preparation for further cleanups that are not queued to 5.10 stable. So this should not be in 5.10 either. Best regards, Pavel --=20 DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany --EY/WZ/HvNxOox07X Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCYJkjOAAKCRAw5/Bqldv6 8pDnAJ9gKppI4pC9TTb4erKtW2Z4q5ES+gCgwHYngmR60ODKvSO4uoBGpmQ4X3M= =IF1o -----END PGP SIGNATURE----- --EY/WZ/HvNxOox07X--