Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Mon, 10 May 2021 13:52:22 +0200
From:   Michael Walle <michael@walle.cc>
To:     Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc:     Mark Brown <broonie@kernel.org>,
        Guillaume Tucker <guillaume.tucker@collabora.com>,
        kernelci-results@groups.io, Heiko Thiery <heiko.thiery@gmail.com>,
        alsa-devel@alsa-project.org, Jaroslav Kysela <perex@perex.cz>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Takashi Iwai <tiwai@suse.com>,
        Stephan Gerhold <stephan@gerhold.net>,
        Thierry Reding <treding@nvidia.com>,
        Jon Hunter <jonathanh@nvidia.com>, linux-kernel@vger.kernel.org
Subject: Re: broonie-sound/for-next bisection:
 baseline.bootrr.asoc-simple-card-probed on kontron-sl28-var3-ads2
In-Reply-To: <87o8djcxas.wl-kuninori.morimoto.gx@renesas.com>
References: <6080e82c.1c69fb81.cd60c.2a13@mx.google.com>
 <3ca62063-41b4-c25b-a7bc-8a8160e7b684@collabora.com>
 <877dkp5141.wl-kuninori.morimoto.gx@renesas.com>
 <20210426144242.GF4590@sirena.org.uk>
 <8735vc4r59.wl-kuninori.morimoto.gx@renesas.com>
 <20210427101926.GA4605@sirena.org.uk>
 <ea2b6dae-3087-67d3-8473-410255a51e23@collabora.com>
 <e20b9c8a2715b5d091a8d1f37ba890b4@walle.cc>
 <20210427135703.GH4605@sirena.org.uk>
 <cc9a39f977c3765d1060ab1b0038bc79@walle.cc>
 <a1ec388def4febd9af6ef477245ef2d3@walle.cc>
 <1aa3a8716d2416f0cc127737dcff092a@walle.cc>
 <87o8djcxas.wl-kuninori.morimoto.gx@renesas.com>
User-Agent: Roundcube Webmail/1.4.11
Message-ID: <99b3cd8db134d9682c16784f75f40bae@walle.cc>
Precedence: bulk

Hi,

Am 2021-05-10 01:16, schrieb Kuninori Morimoto:
> I'm sorry for my late response. Japan was holiday
> 
>>  _But_ later
>> asoc_simple_canonicalize_cpu() will reset the dai_name pointer to
>> NULL in simple_parse_node() if "single" is 1 and then we end up
>> having two links with the same name.
> 
> Ahh, OK thanks.
> I think understand that why my posted patch
> (= 59c35c44a9cf89a83a9 "ASoC: simple-card: add simple_parse_node()")
> breaks your board.
> 
> I will try to fixup the issue.
> 
> Thank you for your help !!

I've just tested your new patches. Unfortunately, it was very
successful. I've also traced the is_single_links and it is still
1 for this board. Is this correct?

Still these two questions are open:
>> Which begs the two questions:
>> (1) What is "single" actually and when should it be 1?
>> (2) If single is 1, then the sysfs file will be named 
>> "(null)-codec-name".
>>     Do we want that?

-michael