Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp2564411pxj; Mon, 10 May 2021 06:02:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxpYEvLLGlTZLK46KuGlkZ86uWbjAihlMJeTf2r0znUMd+rf40NtUNq+wEfK402auD1xcD1 X-Received: by 2002:a05:651c:612:: with SMTP id k18mr20127721lje.339.1620651777025; Mon, 10 May 2021 06:02:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620651776; cv=none; d=google.com; s=arc-20160816; b=EuiHSvMfAR6ZqYKAhAuqORMfF+w4hneCRfM1g/pSoux5vZxYJfKuekPdmZqZETS7xh ZMK+EtoRx2scLaYSYvGKgZRMQwuvCXkM3j31Pl6ucs5VYBfpvnEiB66PdiCZ8GQs56vI nxE1TYIvW/s93TOpusYtZM6AUMrEgGuJad3u9LZwHaKPuCNLH8d7VEN/5efv5D2Xt1HX dpjC/IN7VncamiwYX0vqk6TpMEOamCnCyT1Kj2kdhvHPMFMvMR4gWSgwTD0Rs0SkBOjM /HoA+h32VWRnCaVQzxM72LK3r6l0+SYakTv6xz6AY8CQ2gscd0Fyp4c9w3NL34Q99X99 9prA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=+zsEJ4L+z9vJxI0V4paLrrx5W+Pzh3MjHKM79Satl+4=; b=HjyEXqhHuwsaEObumUZiE0J7LcIxbC6LZUoKsXb3XFCxcloxgC3Xa2qnMOAwkKR4J2 LI9RVycsqGR98nVh36q7vuHKFxes2d6h/ukd9dhRxamH0p4Us29oXGtN0hNNPbtEiqrt hHo5WSdjstFy4ocOGPGbGlffnvCI4qTnB8BQNODi+A1vB2EiZqJw0wkfd4Msd9wSQHRl i6HqtSLqPm2cMDhHjkRrYKo/Bqrwot/GxJ4zsp3HWdqVJGT6XfCTxbJbZOwmIcqJ0S4u JVQRNB37pneYYMb+IIoMCMhsvhqZoa9nvw4i0AlAqLr9cyUVRy+am4j9VksrhP/0xKwB cOqA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=jYU+hRJM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d2si10918693ejd.638.2021.05.10.06.02.28; Mon, 10 May 2021 06:02:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=jYU+hRJM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347573AbhEJMpu (ORCPT + 99 others); Mon, 10 May 2021 08:45:50 -0400 Received: from mail.kernel.org ([198.145.29.99]:35706 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238353AbhEJLR1 (ORCPT ); Mon, 10 May 2021 07:17:27 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id D36F6610A7; Mon, 10 May 2021 11:13:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1620645191; bh=hxDuvgYgndIuc1Trws/f6HVdTUeXT7I2O83D97wdqIA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jYU+hRJMmgJKKHMCCgY0w3PYqffUMojwIBaUIIkoTD6nIoIm6ZriowQuL2NNkkTJq sNyxrKlgFgnyK6JYhqMuyhe3TVHsEWMRfApDIC1PImErzmt3HErdZWXURzSSPvEjcd jRutYY23zQ6c/eR+FFqdQIdXfjKYLVEKAEVwgwmA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, brian-sy yang , Michael Kao , Lukasz Luba , Daniel Lezcano Subject: [PATCH 5.12 383/384] thermal/drivers/cpufreq_cooling: Fix slab OOB issue Date: Mon, 10 May 2021 12:22:52 +0200 Message-Id: <20210510102027.414616497@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210510102014.849075526@linuxfoundation.org> References: <20210510102014.849075526@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: brian-sy yang commit 34ab17cc6c2c1ac93d7e5d53bb972df9a968f085 upstream. Slab OOB issue is scanned by KASAN in cpu_power_to_freq(). If power is limited below the power of OPP0 in EM table, it will cause slab out-of-bound issue with negative array index. Return the lowest frequency if limited power cannot found a suitable OPP in EM table to fix this issue. Backtrace: [] die+0x104/0x5ac [] bug_handler+0x64/0xd0 [] brk_handler+0x160/0x258 [] do_debug_exception+0x248/0x3f0 [] el1_dbg+0x14/0xbc [] __kasan_report+0x1dc/0x1e0 [] kasan_report+0x10/0x20 [] __asan_report_load8_noabort+0x18/0x28 [] cpufreq_power2state+0x180/0x43c [] power_actor_set_power+0x114/0x1d4 [] allocate_power+0xaec/0xde0 [] power_allocator_throttle+0x3ec/0x5a4 [] handle_thermal_trip+0x160/0x294 [] thermal_zone_device_check+0xe4/0x154 [] process_one_work+0x5e4/0xe28 [] worker_thread+0xa4c/0xfac [] kthread+0x33c/0x358 [] ret_from_fork+0xc/0x18 Fixes: 371a3bc79c11b ("thermal/drivers/cpufreq_cooling: Fix wrong frequency converted from power") Signed-off-by: brian-sy yang Signed-off-by: Michael Kao Reviewed-by: Lukasz Luba Cc: stable@vger.kernel.org #v5.7 Signed-off-by: Daniel Lezcano Link: https://lore.kernel.org/r/20201229050831.19493-1-michael.kao@mediatek.com Signed-off-by: Greg Kroah-Hartman --- drivers/thermal/cpufreq_cooling.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/thermal/cpufreq_cooling.c +++ b/drivers/thermal/cpufreq_cooling.c @@ -125,7 +125,7 @@ static u32 cpu_power_to_freq(struct cpuf { int i; - for (i = cpufreq_cdev->max_level; i >= 0; i--) { + for (i = cpufreq_cdev->max_level; i > 0; i--) { if (power >= cpufreq_cdev->em->table[i].power) break; }