Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp2564870pxj; Mon, 10 May 2021 06:03:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwLevvNLA6237B78lwe79So5o+xCDCmsjZ4D2bgMXyvpIu+Wt8gBUjg9bD/Zmefu/g0Witu X-Received: by 2002:a05:6602:3426:: with SMTP id n38mr4819587ioz.3.1620651803986; Mon, 10 May 2021 06:03:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620651803; cv=none; d=google.com; s=arc-20160816; b=HkqxPOVzh7P1mRKjRJM54FGWWYY/B3sjekNtoPxw3juxwXh23vWi8HqM7bpeRn9vaa oo6bdQWQWtydNGG1TcFvyAW4foafb0UVOC+Vk77NMLdP3jx1B+8neHXeVbpE2ihXnwrG tAeKd4TaxRWcJOGvdjdjTsaHiU/8soavjEoapFZoO0ikMkcRjEEuIVXYdm5aDJYq/RHI H9I9zsi4NnTDeL8Xkm9GpKWrRxEvVv9uTi+gp/tZPR2HUckjPaZVUdN71gzNshy6ZdJM bDmi1eM9+gDtU8ERY0HCJjLiio4lvp5TkKZxtIe50qhRbTBa4Hv3buZkK/dc8r6lByuu 9+9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :ironport-sdr:ironport-sdr; bh=KKB24NmvUY7jWmOW1IhSQl8t0TA8H7UpM6y2/P02dBo=; b=m4K/CkIJuqXs8S3EJXoMLjp1SS5xUsZYAH9BsspdZFBCUnBbFTl2LmVL/arrQ1bzcU p/FbXxO3rp3v/252PS9rl/ApijrTMgySIbrqFoumoxd8tsQZ5SyyJla1uL+HUW8ksl39 26LgsD9OJ3ynvRTdeN0vxFpBg0xP+kz5/7gKyPEy2TIC4159HyMZdTA7y6leUpFuw3nK Y4U7qysz8F+7er2AEwm9WLn48MKkrHtA4PjxmrhZyMvkRLu9L0H/Jgs3EViQRcHPJTtO O7N7HZsFMRg/M0ta6SNgV/xYg2TVtbEWkxX5jVUE2P1FvncXk77/aCnNU5BxMOAij4RS M4HQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o4si15643592jas.4.2021.05.10.06.03.05; Mon, 10 May 2021 06:03:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350313AbhEJM5H (ORCPT + 99 others); Mon, 10 May 2021 08:57:07 -0400 Received: from mga18.intel.com ([134.134.136.126]:62648 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348133AbhEJMkQ (ORCPT ); Mon, 10 May 2021 08:40:16 -0400 IronPort-SDR: /F+7haN7w14ep2tcd6GrwJ4ObO1r0XvmEHJuEQAt/Lm6cPAwEdvcvnPsdsodpdr5MERlIlWhYR JwvLzMI3BvLA== X-IronPort-AV: E=McAfee;i="6200,9189,9979"; a="186630435" X-IronPort-AV: E=Sophos;i="5.82,287,1613462400"; d="scan'208";a="186630435" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 May 2021 05:39:11 -0700 IronPort-SDR: qr+vKfhFFOxuAriRn/h1VWiMb0tXm1Qu5IZa5twkTj1uqIaFfwLl8EDw5CS3NBEwX2Poquub4Y Pgla+J4ZgJjA== X-IronPort-AV: E=Sophos;i="5.82,287,1613462400"; d="scan'208";a="470782756" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 May 2021 05:39:00 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1lg5BY-00BAPk-PH; Mon, 10 May 2021 15:38:56 +0300 Date: Mon, 10 May 2021 15:38:56 +0300 From: Andy Shevchenko To: Mark Brown Cc: linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, Takashi Iwai , Liam Girdwood , Haojian Zhuang , Robert Jarzmik , Daniel Mack Subject: Re: [PATCH v2 07/14] spi: pxa2xx: Introduce int_stop_and_reset() helper Message-ID: References: <20210423182441.50272-1-andriy.shevchenko@linux.intel.com> <20210423182441.50272-8-andriy.shevchenko@linux.intel.com> <20210510120953.GA15173@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210510120953.GA15173@sirena.org.uk> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 10, 2021 at 01:09:53PM +0100, Mark Brown wrote: > On Fri, Apr 23, 2021 at 09:24:34PM +0300, Andy Shevchenko wrote: > > Currently we have three times the same few lines repeated in the code. > > Deduplicate them by newly introduced int_stop_and_reset() helper. > > This doesn't apply against current code, please check and resend. Hmm... Can you, please, point out, what branch should I use? It seems good against v5.13-rc1 and spi/for-5.14. Okay, I will resend against spi/for-5.14, but I don't see the issue here. -- With Best Regards, Andy Shevchenko