Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp2604271pxj; Mon, 10 May 2021 06:51:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwzR6k1mmzNkZHn1K5PSlF3yicdxzV0gQJ8nMRfJXl466D52dc2Zu4lSszP1thBbWYbyVRZ X-Received: by 2002:a17:906:3e42:: with SMTP id t2mr25676712eji.508.1620654685680; Mon, 10 May 2021 06:51:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620654685; cv=none; d=google.com; s=arc-20160816; b=zHHOtzk7TskwZni4sTBu6INQ7BVF6CrZuDepY+KVJYTQm05Puwzfjh3AGDKUd0dwbm R4KyiupcZRc7s9XpAHUd7wQsfRocoIhKn63n9k3QPiMnK3C2h7uv0W9tXzV9GZcs5ZtT ts5ir5CSvlKSTncykCn5QjG6UiRxGw+GQedsTgGRoVQfZWIdKj8OxtcZw+F0Enl2fBVh x62XnpTIyfbfO3wRGGB02W5xhIGy3IIMr9soxcIZ4k4wfxwzZtffqXMQSHvZE1gaeLyJ s3/JNHN2uzj0KkSpkC0zNYZGnDB0LXjXFlydWV1RS53nHREprXG06CeTMQ4J6w0QgtRT Y99A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :mime-version:accept-language:in-reply-to:references:message-id:date :thread-index:thread-topic:subject:cc:to:from; bh=nMZy5npGk8+RfldRNPKkfz8bdhgyxlLSJhO3uTmjggc=; b=avlZnQQrY4Z0ifMWVVrPN3zeYvm6tojbeY3jP5J4OF9NbeZI6cLBcAZO7FGLs6hnnX OqBz8pXdipY7ytMUca9GI49AT0GoKzyot4wCTWCUFfpQYfFfl4RmRbYhK2ZOIyxIJVW/ SSXs1yD//pju0Km8Lqjp+FeKiCazzwSPL+ka+Izcorv3UznREeY6CZ54/JOdZzjvFF7O DaX08gNvjsmGhudkvWC8Ht+QgJPJtPoRy2UjT/P3OPq1o7QUZxqUXU5NBxdSBedbGQxT cUnnRwTJ4j/R8EFNdOe+sHZaashjITG2xSKwZ/RQa/jGUd8l8+V/KB/qp/DwqL5OZcTU IJ2Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=aculab.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bq19si14263227edb.311.2021.05.10.06.51.01; Mon, 10 May 2021 06:51:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=aculab.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237889AbhEJNtQ convert rfc822-to-8bit (ORCPT + 99 others); Mon, 10 May 2021 09:49:16 -0400 Received: from eu-smtp-delivery-151.mimecast.com ([185.58.86.151]:43517 "EHLO eu-smtp-delivery-151.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233973AbhEJNkT (ORCPT ); Mon, 10 May 2021 09:40:19 -0400 Received: from AcuMS.aculab.com (156.67.243.121 [156.67.243.121]) (Using TLS) by relay.mimecast.com with ESMTP id uk-mta-27-bBycmq91M5C3TfJHA3srvw-1; Mon, 10 May 2021 14:38:53 +0100 X-MC-Unique: bBycmq91M5C3TfJHA3srvw-1 Received: from AcuMS.Aculab.com (fd9f:af1c:a25b:0:994c:f5c2:35d6:9b65) by AcuMS.aculab.com (fd9f:af1c:a25b:0:994c:f5c2:35d6:9b65) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 10 May 2021 14:38:50 +0100 Received: from AcuMS.Aculab.com ([fe80::994c:f5c2:35d6:9b65]) by AcuMS.aculab.com ([fe80::994c:f5c2:35d6:9b65%12]) with mapi id 15.00.1497.015; Mon, 10 May 2021 14:38:49 +0100 From: David Laight To: 'Fabio Aiuto' , "gregkh@linuxfoundation.org" CC: "linux-staging@lists.linux.dev" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH v2 1/2] staging: rtl8723bs: replace private CRC-32 routines with in-kernel ones Thread-Topic: [PATCH v2 1/2] staging: rtl8723bs: replace private CRC-32 routines with in-kernel ones Thread-Index: AQHXRaBE0Vec4dAP60OcHOZcBIBf86rcuAwA Date: Mon, 10 May 2021 13:38:49 +0000 Message-ID: <29938747c82e4cf1837be5f1cdb803b7@AcuMS.aculab.com> References: In-Reply-To: Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=C51A453 smtp.mailfrom=david.laight@aculab.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: aculab.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > replace private CRC-32 routines with in-kernel ones. Have you verified that they compute the same CRC? There are all sorts of subtle reasons why the outputs can differ. David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)