Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 10 May 2021 15:28:54 +0200
From:   Marc Kleine-Budde <mkl@pengutronix.de>
To:     Dario Binacchi <dariobin@libero.it>
Cc:     linux-kernel@vger.kernel.org,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Oliver Hartkopp <socketcan@hartkopp.net>,
        Tong Zhang <ztong0001@gmail.com>,
        Vincent Mailhol <mailhol.vincent@wanadoo.fr>,
        Wolfgang Grandegger <wg@grandegger.com>,
        Zhang Qilong <zhangqilong3@huawei.com>,
        linux-can@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 2/3] can: c_can: add ethtool support
Message-ID: <20210510132854.mrqag7vjzqdvfh7j@pengutronix.de>
References: <20210509124309.30024-1-dariobin@libero.it>
 <20210509124309.30024-3-dariobin@libero.it>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="ombjtqvc7trra5hf"
Content-Disposition: inline
In-Reply-To: <20210509124309.30024-3-dariobin@libero.it>
Precedence: bulk


--ombjtqvc7trra5hf
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 09.05.2021 14:43:08, Dario Binacchi wrote:
> With commit 132f2d45fb23 ("can: c_can: add support to 64 message objects")
> the number of message objects used for reception / transmission depends
> on FIFO size.
> The ethtools API support allows you to retrieve this info. Driver info
> has been added too.

> +static const struct ethtool_ops c_can_ethtool_ops =3D {
> +	.get_drvinfo =3D c_can_get_drvinfo,
> +	.get_channels =3D c_can_get_channels,
> +};

I think you're filling the wrong information here. I think channels is
for independent RX/TX channels. I think you want to implement
get_ringparam.

regards,
Marc

--=20
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

--ombjtqvc7trra5hf
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEK3kIWJt9yTYMP3ehqclaivrt76kFAmCZNRMACgkQqclaivrt
76lfqAf9HARu8Ohru3bnD+mX1WDpmANN9GJkTmFclbth4mZR1+g6Y7TabDYnSzPK
hSmf5Q90pg/M7of+r8//chVZ9s9wTwJg7vh0ZPJfS2C7GzPMTpV2BoDrV0J5Tj8i
qIappCKonVowqiODLp+9yGwB3W91uiFjWPzcqo6fU8gEdvCHUpp1tvSy2OqGyTwQ
zcIaLCQ+cJPIMaaaZXi6XSTIxv2SYo/aqepuLu+iNu7/GaoR7jr+R4L7gzTEuADb
mYyrC6fpEa2S6O35oHnasGujAob2r9LeMm9obMX6/jK/HINdTOn929vlwXippx+w
oSe/9yrBVBAImSRaktpIu6EyBmBM3Q==
=qxxQ
-----END PGP SIGNATURE-----

--ombjtqvc7trra5hf--