Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Yejune Deng <yejune.deng@gmail.com>
To:     mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com,
        vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
        rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de,
        bristot@redhat.com, tglx@linutronix.de, valentin.schneider@arm.com
Cc:     linux-kernel@vger.kernel.org, Yejune Deng <yejunedeng@gmail.com>
Subject: [PATCH v2] lib/smp_processor_id: Use is_percpu_thread() check affinity
Date:   Mon, 10 May 2021 21:43:58 +0800
Message-Id: <1620654238-1410-1-git-send-email-yejunedeng@gmail.com>
In-Reply-To: <87pmxyj1tr.mognet@arm.com>
References: <87pmxyj1tr.mognet@arm.com>
Precedence: bulk

Use is_percpu_thread() instead of 'current->nr_cpus_allowed == 1',
and add PF_NO_SETAFFINITY flag in init_idle().This would be nice to
the sched_setaffinity(), and it also more readable.

v1->v2:
  - add PF_NO_SETAFFINITY flag in init_idle().

Signed-off-by: Yejune Deng <yejunedeng@gmail.com>
---
 kernel/sched/core.c    | 2 +-
 lib/smp_processor_id.c | 6 +-----
 2 files changed, 2 insertions(+), 6 deletions(-)

diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 9143163..82e21ea 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -7446,7 +7446,7 @@ void init_idle(struct task_struct *idle, int cpu)
 
 	idle->state = TASK_RUNNING;
 	idle->se.exec_start = sched_clock();
-	idle->flags |= PF_IDLE;
+	idle->flags |= PF_IDLE | PF_NO_SETAFFINITY;
 
 	scs_task_reset(idle);
 	kasan_unpoison_task_stack(idle);
diff --git a/lib/smp_processor_id.c b/lib/smp_processor_id.c
index 1c1dbd3..046ac62 100644
--- a/lib/smp_processor_id.c
+++ b/lib/smp_processor_id.c
@@ -19,11 +19,7 @@ unsigned int check_preemption_disabled(const char *what1, const char *what2)
 	if (irqs_disabled())
 		goto out;
 
-	/*
-	 * Kernel threads bound to a single CPU can safely use
-	 * smp_processor_id():
-	 */
-	if (current->nr_cpus_allowed == 1)
+	if (is_percpu_thread())
 		goto out;
 
 #ifdef CONFIG_SMP
-- 
2.7.4