Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Juerg Haefliger <juerg.haefliger@canonical.com>
Date:   Mon, 10 May 2021 16:14:06 +0200
To:     Guenter Roeck <linux@roeck-us.net>
Cc:     Juerg Haefliger <juerg.haefliger@canonical.com>,
        wim@linux-watchdog.org, linux-watchdog@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] watchdog: Add {min,max}_timeout sysfs nodes
Message-ID: <20210510161406.1b32debd@gollum>
In-Reply-To: <695dfd0f-f090-653e-7580-e45484228781@roeck-us.net>
References: <20210510131625.21506-1-juergh@canonical.com>
        <695dfd0f-f090-653e-7580-e45484228781@roeck-us.net>
Organization: Canonical Ltd
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_/ryNewuZSjVJeL.p+oeOWUl2";
 protocol="application/pgp-signature"; micalg=pgp-sha512
Precedence: bulk

--Sig_/ryNewuZSjVJeL.p+oeOWUl2
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

On Mon, 10 May 2021 06:45:15 -0700
Guenter Roeck <linux@roeck-us.net> wrote:

> On 5/10/21 6:16 AM, Juerg Haefliger wrote:
> > The valid range for the 'timeout' value is useful information so expose
> > the min and max timeout values via sysfs.
> >=20
> > Signed-off-by: Juerg Haefliger <juergh@canonical.com>
> > ---
> >   drivers/watchdog/watchdog_dev.c | 20 ++++++++++++++++++++
> >   1 file changed, 20 insertions(+)
> >=20
> > diff --git a/drivers/watchdog/watchdog_dev.c b/drivers/watchdog/watchdo=
g_dev.c
> > index 2946f3a63110..b84d53a79618 100644
> > --- a/drivers/watchdog/watchdog_dev.c
> > +++ b/drivers/watchdog/watchdog_dev.c
> > @@ -525,6 +525,24 @@ static ssize_t timeout_show(struct device *dev, st=
ruct device_attribute *attr,
> >   }
> >   static DEVICE_ATTR_RO(timeout);
> >  =20
> > +static ssize_t min_timeout_show(struct device *dev,
> > +				struct device_attribute *attr, char *buf)
> > +{
> > +	struct watchdog_device *wdd =3D dev_get_drvdata(dev);
> > +
> > +	return sprintf(buf, "%u\n", wdd->min_timeout);
> > +}
> > +static DEVICE_ATTR_RO(min_timeout);
> > +
> > +static ssize_t max_timeout_show(struct device *dev,
> > +				struct device_attribute *attr, char *buf)
> > +{
> > +	struct watchdog_device *wdd =3D dev_get_drvdata(dev);
> > +
> > +	return sprintf(buf, "%u\n", wdd->max_timeout); =20
>=20
> Makes sense, but please use sysfs_emit().

OK. And maybe I should send a patch to convert the other occurrences of
sprintf as well?

...Juerg


> Guenter
>=20
> > +}
> > +static DEVICE_ATTR_RO(max_timeout);
> > +
> >   static ssize_t pretimeout_show(struct device *dev,
> >   			       struct device_attribute *attr, char *buf)
> >   {
> > @@ -609,6 +627,8 @@ static struct attribute *wdt_attrs[] =3D {
> >   	&dev_attr_state.attr,
> >   	&dev_attr_identity.attr,
> >   	&dev_attr_timeout.attr,
> > +	&dev_attr_min_timeout.attr,
> > +	&dev_attr_max_timeout.attr,
> >   	&dev_attr_pretimeout.attr,
> >   	&dev_attr_timeleft.attr,
> >   	&dev_attr_bootstatus.attr,
> >  =20
>=20


--Sig_/ryNewuZSjVJeL.p+oeOWUl2
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEhZfU96IuprviLdeLD9OLCQumQrcFAmCZP64ACgkQD9OLCQum
QreCZA//WV4QDVPBwEjUkBJk1mhwNSpVnnXN+KP9wLFeHqf6zIBu+LFdULXUNvc5
lJKoGEXdouTk7Zp7Tfa4GMNJ+sL3AfCuToUpQmKDJaR9Hq27HF1BptBtRAPhP5rQ
hkQFc00bRyD7aG/MC1xh53R4AGIu97Wn40ZocCZh3EZk0jJnInlhR/gGqUmvqxyX
ZimWBAFP6gQt9P2HXanB5488tenH9FbbTXjPUzOJY3QcKLTh5rXmF8l2HMqE+B8K
meM43PFGuDyWK4+2O4VRkY725wrWxqpbNa9VhxYK1gjutteAaCI829ePAOt/fMG3
Wir2uH8QP7eN4Hc1AaAaPq2QEXIjW9PlMWDTfsCN9FtXMWA1nVr5hx345M0TCaN5
FQe+w2gD4yvi2aBo29xg93yHO2HXwDhHxDAq+KvHm2raf4OO/17R5KSFDy9ZTdq6
e63SSs0o1fId9TA0GE5+7x12Wlr6sQyt4HtejGqoC/NQW7u13dakwjdt23Wb2g97
S89wl5guRHVcheTtDTrmFWoVx4qOKMZfxCI8Ybp4EDPS/L9pqqQupl2P69Flpevn
p57VQG1dMLIfO8g2P2+vokrqOy3+wRVkml9W9ol6HGkQgghXGDDnRSr0T2ebEZBW
I/RfTeV9XyQ8xB2LWwpoNmNgVldjfzFJgf6lDImZSnaxXmn37Tc=
=0plC
-----END PGP SIGNATURE-----

--Sig_/ryNewuZSjVJeL.p+oeOWUl2--