Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp2638359pxj; Mon, 10 May 2021 07:32:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzk++tZWlPtJIm3i7seYhhwOhkWUKW26D/hCgN8FF9PhN0A8qRxQxHDI7dnyVRioqf8uGoa X-Received: by 2002:a17:906:b10e:: with SMTP id u14mr25851229ejy.546.1620657120042; Mon, 10 May 2021 07:32:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620657120; cv=none; d=google.com; s=arc-20160816; b=sux4bczPnZJWJJNgh6l5UMOmP9GER8J7PDkCtahjPZsJBTJfW4tL4zLXtwjM2I9moQ 7zIg13m6SWYZnRlA8T4IKTwG8jfRoAIIiZzwu2tN0bhTdYuSU8tagOp3ni2e4whEZxuI uCHE9Og+6xToLHrbqJEoJJmj0GDL12EJQK2B7MEtoTvlkXdsi06DwRjU7QyAcI2WSltW a5/nRehRWcbkMU33uouC805DEyPL6hvuTmmZdyNjWAKTv1Y10i4Di9Mz54s93ydaCgIk pq6BKM3wQatiV4ergAVGnMeU83bWFAaf2l0qBxLMNJA8XWq2RtVwMX3fC+BSOVUeB9op f+ig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=fq1b+Isl5+gYnWSx7qYVRyoUAr9cXF9uxU922Q4uDU8=; b=Mv6w8v70WXYLReMZsWT23mfp/mWRaFmCTxbYNoZA3iaUGLF+NRhREITxe3cA8VcUR1 tWyBh70kwV8dW6wIU4SO+fm7Nv7+kFUvsixkhsHMrgnGuNVmLp+3QhNcYZr2b15Y0Fzt ysIdb4zurx/ZJ2Qy271kZuWLVFFmyp3dXYmIanOn4goEdx6zVlOMtN8k2QGF0kW1el79 NhkrrZw4QYvmJaAl+jmgnigPtb/pcFI60nVCGBj1T/hJATYKdWHAeqTTXLLdP7JRvkoh NMwu0Z72kiKMJsuC7rRM3gkPHhukhlFMnqKZlT9QCf4Y/UpnBM9IeebkErWp4rW1MEIQ 7ekQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=n7DQ+ePe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k9si16008035edv.206.2021.05.10.07.31.35; Mon, 10 May 2021 07:32:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=n7DQ+ePe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232800AbhEJObo (ORCPT + 99 others); Mon, 10 May 2021 10:31:44 -0400 Received: from mail.kernel.org ([198.145.29.99]:38494 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243495AbhEJO3P (ORCPT ); Mon, 10 May 2021 10:29:15 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id B2091611F0; Mon, 10 May 2021 14:28:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1620656890; bh=5Qx2wMQY09P/jiz+QyXoXliDQV06oKwVi44Sr9uGsVA=; h=From:To:Cc:Subject:Date:From; b=n7DQ+ePe8MZ/W7CimYXZFPNzOE2FndNoWEPR8x0U22UVREFxJqX/XHbh1VJDAfNkg 3DqJom5OmACR5RAparxHCl1akePyOJy5N+T2ywJeG83VMXW6c4KLpe8H3KXCG3DbNP NRVLHKM+Vavik1dfRoR5AfBZrZQT/P64EfFpunNiZh4oXoNkfNizJsdI9kbPfAmW9r krRxiPrxLc+AYkGspZm9ZjIrRQ1C80XqDOvTD+hsYIpKct/KYFOLvM5+98t1zllQq4 LcmVGOUCyoXQinz2z2EpF7Be5pbOuizu1JpEoIiYNTYvugS1KgPq13oHI2j5rqSp2l DRFddyGFb2SUQ== From: Jaegeuk Kim To: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Cc: Jaegeuk Kim Subject: [PATCH] f2fs: avoid null pointer access when handling IPU error Date: Mon, 10 May 2021 07:28:04 -0700 Message-Id: <20210510142804.511265-1-jaegeuk@kernel.org> X-Mailer: git-send-email 2.31.1.607.g51e8a6a459-goog MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Unable to handle kernel NULL pointer dereference at virtual address 000000000000001a pc : f2fs_inplace_write_data+0x144/0x208 lr : f2fs_inplace_write_data+0x134/0x208 Call trace: f2fs_inplace_write_data+0x144/0x208 f2fs_do_write_data_page+0x270/0x770 f2fs_write_single_data_page+0x47c/0x830 __f2fs_write_data_pages+0x444/0x98c f2fs_write_data_pages.llvm.16514453770497736882+0x2c/0x38 do_writepages+0x58/0x118 __writeback_single_inode+0x44/0x300 writeback_sb_inodes+0x4b8/0x9c8 wb_writeback+0x148/0x42c wb_do_writeback+0xc8/0x390 wb_workfn+0xb0/0x2f4 process_one_work+0x1fc/0x444 worker_thread+0x268/0x4b4 kthread+0x13c/0x158 ret_from_fork+0x10/0x18 Fixes: 955772787667 ("f2fs: drop inplace IO if fs status is abnormal") Signed-off-by: Jaegeuk Kim --- fs/f2fs/segment.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c index c605415840b5..ae875557d693 100644 --- a/fs/f2fs/segment.c +++ b/fs/f2fs/segment.c @@ -3577,9 +3577,11 @@ int f2fs_inplace_write_data(struct f2fs_io_info *fio) if (fio->bio) { struct bio *bio = *(fio->bio); - bio->bi_status = BLK_STS_IOERR; - bio_endio(bio); - fio->bio = NULL; + if (bio) { + bio->bi_status = BLK_STS_IOERR; + bio_endio(bio); + fio->bio = NULL; + } } return err; } -- 2.31.1.607.g51e8a6a459-goog