Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp2705829pxj; Mon, 10 May 2021 08:57:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzf/1XS/cY8xGIQ65mekC+ZTlt+yfkcJy+U7nLDHjfAnbzp6/EETbfIzmGXxAT9wQH+Zi3U X-Received: by 2002:a05:6402:406:: with SMTP id q6mr28065327edv.110.1620662264032; Mon, 10 May 2021 08:57:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620662264; cv=none; d=google.com; s=arc-20160816; b=NUnwLOrR4Rn5kJA4Z2QFngky3hCIUzcR+iOSamhBerREboyQB584Pp9BONM15QahVv /edK5y1UMyapMTxln/EhriW/0eEPVcZek+Rl24mHA4brtnk49S6H7NoWHiggcRqsznIJ OPa5q6LyHw3/G/8yG5L8+/JyXtbPpwrSdYTdl6tMzn7qXCXfeaHpleU31wXMZ2Fa0GQQ 3mT+eMOSKciSKt80OTdQejUWqWZ4uJF5d7tp+kaPViWBVQr0k+BuDsKw5cY/6e8fJHdG JebMpMV04C8N9KH0M8aPzN6vs1SdUWwVi73VGLla16D1EGVEPdeWFFx427UdMPEwS6I7 o2UA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=JHyuQMdg1cfMUXlAjhofPj/Y7ZKtyCD1MVN/vX+H71E=; b=uscXqTehuoJtNmh9+BUc1KtD6f52L7j0GYqu8pvq+TZ/+sCBxC7VTme/TrG20BqRip KOEr7N7JdLHr45toZEe4py6VEz2POAAzLy8eNC+dUd2PoFUAgj6r5B/6kdj6i09S+Azd /tz5sIalxBTn2SKMiuR2NOeLra7e7y2t87kkCoD7HLU2xfUsnzHlFMWo/CeBtK2jYGLq IpQYL7goZsQ/vd9gAKVPJTpG5k2R97WZEqu9uSNn5iBp6/tp1aM09ysU4CtpqI3ltgj5 +acDhHVr9CSE9E00kWZtQsz3D0ZAkuPq4S/3wH6kl6ure8oeIq5sV2TMHSEiyZAlWm2h Kw7g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=z8KvnUhR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 8si16803013ejx.447.2021.05.10.08.57.19; Mon, 10 May 2021 08:57:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=z8KvnUhR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237979AbhEJLaf (ORCPT + 99 others); Mon, 10 May 2021 07:30:35 -0400 Received: from mail.kernel.org ([198.145.29.99]:52794 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234818AbhEJK5I (ORCPT ); Mon, 10 May 2021 06:57:08 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id DCFD361606; Mon, 10 May 2021 10:49:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1620643768; bh=8wfxU4t98busu7Cl51jcJgRn3v9dTEgdy2f8bw1cl68=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=z8KvnUhRixJF4083zfX39D0cGKq2jtM46mkoptzxwR3exAohri6KXeUGZMqUx20+n sxalAc44b6UFSdrDJ/x5fyPC0wC8WUKmrIFPqoxxDkBpb3MbTw/BL4GSpO5rwmNF09 grYXYsiZ7jhaYrYqVT3JtDKRq/NHlL1Bfwzd8Riw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Mike Christie , Johannes Thumshirn , Chaitanya Kulkarni , "Martin K. Petersen" , Sasha Levin Subject: [PATCH 5.11 151/342] scsi: target: pscsi: Fix warning in pscsi_complete_cmd() Date: Mon, 10 May 2021 12:19:01 +0200 Message-Id: <20210510102015.080753413@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210510102010.096403571@linuxfoundation.org> References: <20210510102010.096403571@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Chaitanya Kulkarni [ Upstream commit fd48c056a32ed6e7754c7c475490f3bed54ed378 ] This fixes a compilation warning in pscsi_complete_cmd(): drivers/target/target_core_pscsi.c: In function ‘pscsi_complete_cmd’: drivers/target/target_core_pscsi.c:624:5: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body] ; /* XXX: TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE */ Link: https://lore.kernel.org/r/20210228055645.22253-5-chaitanya.kulkarni@wdc.com Reviewed-by: Mike Christie Reviewed-by: Johannes Thumshirn Signed-off-by: Chaitanya Kulkarni Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/target/target_core_pscsi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/target/target_core_pscsi.c b/drivers/target/target_core_pscsi.c index 0689d550c37a..328ed12e2d59 100644 --- a/drivers/target/target_core_pscsi.c +++ b/drivers/target/target_core_pscsi.c @@ -620,8 +620,9 @@ static void pscsi_complete_cmd(struct se_cmd *cmd, u8 scsi_status, unsigned char *buf; buf = transport_kmap_data_sg(cmd); - if (!buf) + if (!buf) { ; /* XXX: TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE */ + } if (cdb[0] == MODE_SENSE_10) { if (!(buf[3] & 0x80)) -- 2.30.2