Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp2707369pxj; Mon, 10 May 2021 08:59:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzMgo8sZKKN5Dkic6Jw5uq/5iO2sjeFMJQReYDKEh4L0ORF5SLjyzSAAI2kZgSOZ06PfjTo X-Received: by 2002:a92:280b:: with SMTP id l11mr21942959ilf.111.1620662386076; Mon, 10 May 2021 08:59:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620662386; cv=none; d=google.com; s=arc-20160816; b=RHrHK5CnlMGyRRWEhdXu5RLmOBCTiAPPb4+g5Y05Kpk5zlFCaDSGYaOGy7osT35kuA ytClCBfLFLyrmKnRXCUfr9i4nOgtEi+lPviiUcirMhrVUYDEX/5UqC3k7ARDuom1Rhts rN0lAII/PZCqnfs82TBL/+8ifIcOIRM4C3KxhUW6xxYr6rFJvOIp2fz7tvJtxawBw1GW Nc5lWcLnsp0I09tdDyV2JxbP6rDQ2cccOJYS5mN87p6fqiGnVNyMeVL3bZTeGTydpsGh n2OGYs7mAXm4RD4T3aPkXoErctmZCeC2zPS0ctnRseYdU7xsFHZvs8DsogisduChaMVU qUZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=WzXntg5bvu9qT2VgPEsYi9UfBMF7Vbi3QLLEHATdpdc=; b=zLvZ+55aUfX70R2B3bVWefmkDSVSfG/0D9VANgmLp0VU1ofUE8NRvGYb9p873KI9Pp +F6Qb2tEVWH7LOYgLIQS/T6N4GCALEglGHVSnmecRwESH7LzqxVuD+su9Q7kZBTM+sz+ zcOQfrpUsCZEDPK+IpqfAaZaikobozubuPrM0yAWUXVxOtxzCgfhkaB+mFz86vx4hqc+ lSzhQ+j5BEllYJSPdXvYKJVDJxLJYUtvrNkx6WglSqzc/1GPpZwfiAP2LLLVO76M4JIW 8C90t66zOTRLATfaJ08MsddifZyVX6qb/4qwu8x4zuaUVH/vN/yyyb6MNoDpZ9MfYBbk YLsg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=H82KjC6j; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u4si12916234jad.12.2021.05.10.08.59.33; Mon, 10 May 2021 08:59:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=H82KjC6j; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238404AbhEJLfF (ORCPT + 99 others); Mon, 10 May 2021 07:35:05 -0400 Received: from mail.kernel.org ([198.145.29.99]:52982 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234931AbhEJK5Q (ORCPT ); Mon, 10 May 2021 06:57:16 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 87BB261A0F; Mon, 10 May 2021 10:50:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1620643830; bh=k9ChT4BgUSBEEY477nIRp8U+YSJQjA/6ihvjRNoeAUI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=H82KjC6j7Ifz3+BxLahbrjDywOxOCbHaYIMNPXEn0Q4ZqYmD8kmvMG0XuRslNAHJT y9g6aK48NUC7m625iXf9qEm0juegSSSxesz8iF2LG0Wtvqk/QfPkGE5TYJX0P47EDe Z3+w+dSlvTsBzXFKKO01r9K2z6ohkjZYfM6nXMy0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dick Kennedy , James Smart , "Martin K. Petersen" , Sasha Levin Subject: [PATCH 5.11 141/342] scsi: lpfc: Fix incorrect dbde assignment when building target abts wqe Date: Mon, 10 May 2021 12:18:51 +0200 Message-Id: <20210510102014.736779957@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210510102010.096403571@linuxfoundation.org> References: <20210510102010.096403571@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: James Smart [ Upstream commit 9302154c07bff4e7f7f43c506a1ac84540303d06 ] The wqe_dbde field indicates whether a Data BDE is present in Words 0:2 and should therefore should be clear in the abts request wqe. By setting the bit we can be misleading fw into error cases. Clear the wqe_dbde field. Link: https://lore.kernel.org/r/20210301171821.3427-2-jsmart2021@gmail.com Co-developed-by: Dick Kennedy Signed-off-by: Dick Kennedy Signed-off-by: James Smart Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/lpfc/lpfc_nvmet.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_nvmet.c b/drivers/scsi/lpfc/lpfc_nvmet.c index a71df8788fff..0dbe1d399378 100644 --- a/drivers/scsi/lpfc/lpfc_nvmet.c +++ b/drivers/scsi/lpfc/lpfc_nvmet.c @@ -3299,7 +3299,6 @@ lpfc_nvmet_unsol_issue_abort(struct lpfc_hba *phba, bf_set(wqe_rcvoxid, &wqe_abts->xmit_sequence.wqe_com, xri); /* Word 10 */ - bf_set(wqe_dbde, &wqe_abts->xmit_sequence.wqe_com, 1); bf_set(wqe_iod, &wqe_abts->xmit_sequence.wqe_com, LPFC_WQE_IOD_WRITE); bf_set(wqe_lenloc, &wqe_abts->xmit_sequence.wqe_com, LPFC_WQE_LENLOC_WORD12); -- 2.30.2