Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <6a589bf720c5420e09bcc3c40b812bf6822d3a3d.camel@perches.com>
Subject: Re: [PATCH v2] HID: ft260: fix format type warning in
 ft260_word_show()
From:   Joe Perches <joe@perches.com>
To:     Michael Zaidman <michael.zaidman@gmail.com>, lkp@intel.com
Cc:     kbuild-all@lists.01.org, clang-built-linux@googlegroups.com,
        linux-kernel@vger.kernel.org, jikos@kernel.org,
        dan.carpenter@oracle.com, linux-input@vger.kernel.org
Date:   Mon, 10 May 2021 09:41:57 -0700
In-Reply-To: <20210510163029.2217-1-michael.zaidman@gmail.com>
References: <202105060637.LeEC6ztp-lkp@intel.com>
         <20210510163029.2217-1-michael.zaidman@gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.38.1-1 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Mon, 2021-05-10 at 19:30 +0300, Michael Zaidman wrote:
> Fixes: 6a82582d9fa4 ("HID: ft260: add usb hid to i2c host bridge driver")
> 
> Fix warning reported by static analysis when built with W=1 for arm64 by
> clang version 13.0.0
> 
> > > drivers/hid/hid-ft260.c:794:44: warning: format specifies type 'short' but
> ???the argument has type 'int' [-Wformat]
[]
> diff --git a/drivers/hid/hid-ft260.c b/drivers/hid/hid-ft260.c
[]
> @@ -791,7 +791,7 @@ static int ft260_word_show(struct hid_device *hdev, int id, u8 *cfg, int len,
> ?	if (ret != len && ret >= 0)
> ?		return -EIO;
> ?
> 
> -	return scnprintf(buf, PAGE_SIZE, "%hi\n", le16_to_cpu(*field));
> +	return scnprintf(buf, PAGE_SIZE, "%d\n", le16_to_cpu(*field));
> ?}

This is likely a clang defect and not an actual problem.
If you are going to convert one of these, convert both.