Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
In-Reply-To: <a7535a82925f6f4c1f062abaa294f3ae6e54bdd2.1620560310.git.leonro@nvidia.com>
Subject: Re: [PATCH rdma-rc] RDMA/siw: Properly check send and receive CQ pointers
From:   "Bernard Metzler" <BMT@zurich.ibm.com>
To:     "Leon Romanovsky" <leon@kernel.org>
Cc:     "Doug Ledford" <dledford@redhat.com>,
        "Jason Gunthorpe" <jgg@nvidia.com>,
        "Leon Romanovsky" <leonro@nvidia.com>,
        "linux-kernel" <linux-kernel@vger.kernel.org>,
        "linux-rdma" <linux-rdma@vger.kernel.org>
Date:   Mon, 10 May 2021 17:30:45 +0000
MIME-Version: 1.0
Sensitivity: 
Importance: Normal
References: <a7535a82925f6f4c1f062abaa294f3ae6e54bdd2.1620560310.git.leonro@nvidia.com>
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Message-Id: <OF52748745.A17A3172-ON002586D1.0060334D-002586D1.00603353@notes.na.collabserv.com>
Precedence: bulk

-----"Leon Romanovsky" <leon@kernel.org> wrote: -----

>To: "Doug Ledford" <dledford@redhat.com>, "Jason Gunthorpe"
><jgg@nvidia.com>
>From: "Leon Romanovsky" <leon@kernel.org>
>Date: 05/09/2021 01:39PM
>Cc: "Leon Romanovsky" <leonro@nvidia.com>, "Bernard Metzler"
><bmt@zurich.ibm.com>, linux-kernel@vger.kernel.org,
>linux-rdma@vger.kernel.org
>Subject: [EXTERNAL] [PATCH rdma-rc] RDMA/siw: Properly check send and
>receive CQ pointers
>
>From: Leon Romanovsky <leonro@nvidia.com>
>
>The check for the NULL of pointer received from container=5Fof is
>incorrect by definition as it points to some random memory.
>
>Change such check with proper NULL check of SIW QP attributes.
>
>Fixes: 303ae1cdfdf7 ("rdma/siw: application interface")
>Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
>---
> drivers/infiniband/sw/siw/siw=5Fverbs.c | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
>diff --git a/drivers/infiniband/sw/siw/siw=5Fverbs.c
>b/drivers/infiniband/sw/siw/siw=5Fverbs.c
>index d2313efb26db..917c8a919f38 100644
>--- a/drivers/infiniband/sw/siw/siw=5Fverbs.c
>+++ b/drivers/infiniband/sw/siw/siw=5Fverbs.c
>@@ -300,7 +300,6 @@ struct ib=5Fqp *siw=5Fcreate=5Fqp(struct ib=5Fpd *pd,
> 	struct siw=5Fucontext *uctx =3D
> 		rdma=5Fudata=5Fto=5Fdrv=5Fcontext(udata, struct siw=5Fucontext,
> 					  base=5Fucontext);
>-	struct siw=5Fcq *scq =3D NULL, *rcq =3D NULL;
> 	unsigned long flags;
> 	int num=5Fsqe, num=5Frqe, rv =3D 0;
> 	size=5Ft length;
>@@ -343,10 +342,8 @@ struct ib=5Fqp *siw=5Fcreate=5Fqp(struct ib=5Fpd *pd,
> 		rv =3D -EINVAL;
> 		goto err=5Fout;
> 	}
>-	scq =3D to=5Fsiw=5Fcq(attrs->send=5Fcq);
>-	rcq =3D to=5Fsiw=5Fcq(attrs->recv=5Fcq);
>=20
>-	if (!scq || (!rcq && !attrs->srq)) {
>+	if (!attrs->send=5Fcq || (!attrs->recv=5Fcq && !attrs->srq)) {
> 		siw=5Fdbg(base=5Fdev, "send CQ or receive CQ invalid\n");
> 		rv =3D -EINVAL;
> 		goto err=5Fout;
>@@ -401,8 +398,8 @@ struct ib=5Fqp *siw=5Fcreate=5Fqp(struct ib=5Fpd *pd,
> 		}
> 	}
> 	qp->pd =3D pd;
>-	qp->scq =3D scq;
>-	qp->rcq =3D rcq;
>+	qp->scq =3D to=5Fsiw=5Fcq(attrs->send=5Fcq);
>+	qp->rcq =3D to=5Fsiw=5Fcq(attrs->recv=5Fcq);
>=20
> 	if (attrs->srq) {
> 		/*
>--=20
>2.31.1
>
>

Many thanks Leon!

Reviewed-by: Bernard Metzler <bmt@zurich.ibm.com>