Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: Tejun Heo <htejun@gmail.com>
Date:   Mon, 10 May 2021 14:54:31 -0400
From:   Tejun Heo <tj@kernel.org>
To:     Roman Gushchin <guro@fb.com>
Cc:     cgroups@vger.kernel.org, Zefan Li <lizefan.x@bytedance.com>,
        Johannes Weiner <hannes@cmpxchg.org>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cgroup: inline cgroup_task_freeze()
Message-ID: <YJmBZ3IVCiAK7WF+@slm.duckdns.org>
References: <20210510184556.946798-1-guro@fb.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210510184556.946798-1-guro@fb.com>
Precedence: bulk

On Mon, May 10, 2021 at 11:45:56AM -0700, Roman Gushchin wrote:
> After the introduction of the cgroup.kill there is only one call site
> of cgroup_task_freeze() left: cgroup_exit(). cgroup_task_freeze() is
> currently taking rcu_read_lock() to read task's cgroup flags, but
> because it's always called with css_set_lock locked, the rcu protection
> is excessive.
> 
> Simplify the code by inlining cgroup_task_freeze().
> 
> Signed-off-by: Roman Gushchin <guro@fb.com>

Applied to cgroup/for-5.14.

Thanks.

-- 
tejun