Message-ID: <453D27F8.8020509@qumranet.com>
Date: Mon, 23 Oct 2006 22:37:12 +0200
From: Avi Kivity <avi@qumranet.com>
User-Agent: Thunderbird 1.5.0.7 (X11/20061008)
MIME-Version: 1.0
To: Arnd Bergmann <arnd@arndb.de>
CC: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 8/13] KVM: vcpu execution loop
References: <453CC390.9080508@qumranet.com> <200610232141.45802.arnd@arndb.de> <453D230D.7070403@qumranet.com> <200610232229.41934.arnd@arndb.de>
In-Reply-To: <200610232229.41934.arnd@arndb.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 969
Lines: 31

Arnd Bergmann wrote:
> On Monday 23 October 2006 22:16, Avi Kivity wrote:
>   
>>> This looks like you should simply put it into a .S file.
>>>
>>>  
>>>       
>> Then I lose all the offsetof constants down the line.  Sure, I could do
>> the asm-offsets dance but it seems to me like needless obfuscation.
>>     
>
> Ok, I see.
>
> How if you pass &vcpu->regs and &vcpu->cr2 to the functions instead of 
> kvm_vcpu?
>
>   

I could do that, but I feel that's more brittle.  I might need more (or 
other) fields later on.  It will also cost me more  pushes on the stack 
(no real performance or space impact, just C64-era frugality).


-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/