Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp2875153pxj; Mon, 10 May 2021 12:45:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwe9mcLJ+w+/eulKoTabhM/kp2koWIqZmCdOeq3e/lnn87DoIwIzw0Jvj2alM5l3+LUEqIC X-Received: by 2002:a05:6402:120c:: with SMTP id c12mr31226385edw.98.1620675925489; Mon, 10 May 2021 12:45:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620675925; cv=none; d=google.com; s=arc-20160816; b=nBUno0iVuJnI8pMECFyYN/rjryEYVj+xweIVfCztocHgz5JE6+r2USX2uXENUzPJfb NAu2EMz0iAgrPz6d6+vyNL4Z8v+ZBaj+hAur0NL/leciO5805AWVqhag1qZ0MHGYx8H/ 7CXN4AdQy58dN8CbG4kNK6wYFn7k4b3FCBaky5QroZh6JyH1qA3LTWpFznKDuTqdX11P ntm3faXDdnxAA7rJbrOdpLAX+yzcAEFDf2GQ6KbIQ9MwUuZZ6+hDySddXlE0xIZ5vJv4 boMGkUjOxaVVpxeuZP8O6IKIK8hBhntmcr2lzbpOv4KqE+MVryPLzamk/fZrFT4qh0OI oyEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:mime-version:user-agent:date :message-id:subject:from:references:cc:to; bh=he3RD9BXp2Fkkm6Co2YwkvVxUEZ7nBKVn1K9TUWSbRc=; b=VK6IVPyYXgLi5n7nmG3ipXnBHIrU8eOT7I2oMKE44NSAGx8sdprgcf/JOLUvrWjlHN 346nOZGxIkS5eD5E4ISmxkLm8pZ9niVc6Hvqef4U/BelqFK1TnOGehBOWXSxBA0FVDbz 9Tpp7v6sY0NXPgRW1zq52iqjPydvhuzSENOOGkGD6xSoiI8Uj01ocfDta/Zi/vk9+yoR Djlp2ROM6R7aedKJ7dSFTdKUY08Lv+I0/24VE7fyPoQGM4Lxzwe+t+NV9BV2lmuNGONZ DJ614JG15BmWJ6Un5WcwCcMzaeIFkhYtcgdSXvhNTtihd7Sjp/Qq9vhmRpLwGG4IL6Qj UXsg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n20si14716071edr.379.2021.05.10.12.45.00; Mon, 10 May 2021 12:45:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231168AbhEJToX (ORCPT + 99 others); Mon, 10 May 2021 15:44:23 -0400 Received: from antares.kleine-koenig.org ([94.130.110.236]:37988 "EHLO antares.kleine-koenig.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230045AbhEJToW (ORCPT ); Mon, 10 May 2021 15:44:22 -0400 Received: from antares.kleine-koenig.org (localhost [127.0.0.1]) by antares.kleine-koenig.org (Postfix) with ESMTP id 698F4B92B2A; Mon, 10 May 2021 21:43:16 +0200 (CEST) Received: from antares.kleine-koenig.org ([94.130.110.236]) by antares.kleine-koenig.org (antares.kleine-koenig.org [94.130.110.236]) (amavisd-new, port 10024) with ESMTP id FQOmxRin8T3E; Mon, 10 May 2021 21:43:15 +0200 (CEST) Received: from taurus.defre.kleine-koenig.org (unknown [IPv6:2a02:8071:b5c8:7bfc:751d:682d:7359:e261]) by antares.kleine-koenig.org (Postfix) with ESMTPSA; Mon, 10 May 2021 21:43:15 +0200 (CEST) To: Jiri Kosina , Srinivas Pandruvada Cc: Benjamin Tissoires , Enric Balletbo i Serra , Guenter Roeck , Greg Kroah-Hartman , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210206151348.14530-1-uwe@kleine-koenig.org> <31028f589e27e246bb3b4b693caeb0b8eae3a285.camel@linux.intel.com> From: =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= Subject: Re: [PATCH v1 1/3] HID: intel-ish-hid: Drop if block with an always false condition Message-ID: Date: Mon, 10 May 2021 21:43:10 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="qGHuWGV0fsZU0BWAdzrJRAn3J4AVipvAq" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --qGHuWGV0fsZU0BWAdzrJRAn3J4AVipvAq Content-Type: multipart/mixed; boundary="ZS2vNPexYSXxqk5nVV4GkR8xH11UrMQ9T"; protected-headers="v1" From: =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= To: Jiri Kosina , Srinivas Pandruvada Cc: Benjamin Tissoires , Enric Balletbo i Serra , Guenter Roeck , Greg Kroah-Hartman , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID: Subject: Re: [PATCH v1 1/3] HID: intel-ish-hid: Drop if block with an always false condition References: <20210206151348.14530-1-uwe@kleine-koenig.org> <31028f589e27e246bb3b4b693caeb0b8eae3a285.camel@linux.intel.com> In-Reply-To: --ZS2vNPexYSXxqk5nVV4GkR8xH11UrMQ9T Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable Hello Jiri, On 3/8/21 5:16 PM, Jiri Kosina wrote: > On Mon, 8 Mar 2021, Srinivas Pandruvada wrote: >=20 >>>> A remove callback is only ever called for a bound device. So there >>>> is no >>>> need to check for device or driver being NULL. >>> >>> Srinivas, any objections to this patchset? The cleanups look good to >>> me. >> Sorry, I missed this series. >> No objection for taking these patches. >=20 > Thanks. Applied with your Acked-by: > If you disagree with that interpretation of your statement above, pleas= e > holler :) I expected these patches to go in during the 5.13 merge window, but they = didn't. I found your pull request for 5.13=20 (https://lore.kernel.org/lkml/nycvar.YFH.7.76.2104292151220.18270@cbobk.f= hfr.pm/)=20 and they were not included there even though the patches were in next=20 since at least next-20210310. Looking at git log --oneline --cherry=20 v5.13-rc1...dce6a0d56a7719efcad438f5c46a9d192fd36a89 (where dce.. was the tip of your for-next for next-20210506 (i.e. before = 5.13-rc1 was cut)) and it seems there are quite a few more commits that=20 didn't make it into your pull request. What am I missing? Best regards Uwe --ZS2vNPexYSXxqk5nVV4GkR8xH11UrMQ9T-- --qGHuWGV0fsZU0BWAdzrJRAn3J4AVipvAq Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmCZjM8ACgkQwfwUeK3K 7Anuwgf+JSHxB7za9i0xL9t5R1j1A2RAAiGuuTFd+yTRWWFy1j3Loq4jCfxnd5HQ MhaLy8+0ZxBMzCJJnbTRJohgkBq6odjBePtSmyG+KTk42vA+uvVWv67jVpmbbXd1 5dQqQ5zduKcN/1TEwyFaMwSd6WxDjX4Yrwg0APsJ3z34QvHgLFzKVWjaFJ33u81I vkma5rq504gKF0ronu4nbwFHxKyt+PXGydvG6vq10Hmhyuj6hpnSCPDtiiXwxONH U6ATH90TXJ4LFnc0UXwl9OPkrnbw9YucadhVq+xv9v7naLuNzBp/91Vxr5f868aW 8MTQuhedMa6TqvjR13s9Ahaevmsi9A== =gNoi -----END PGP SIGNATURE----- --qGHuWGV0fsZU0BWAdzrJRAn3J4AVipvAq--