Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp2885276pxj; Mon, 10 May 2021 13:00:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwvGeg4fo5+NNxM1kDsHpXTNBvzWvqrrWek6WpjuUzWXKeTuDHKFxf1G7fiMndN8Lnm6/Ot X-Received: by 2002:aa7:d996:: with SMTP id u22mr31875240eds.342.1620676846297; Mon, 10 May 2021 13:00:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620676846; cv=none; d=google.com; s=arc-20160816; b=USJ3McyIbttUM6D6VzQa/XAgVmUc+/qBQoxCX2Haoiyi/EmsUVcfFw2fN6rUVwxHfF a4XLdxt/S1Xkn8TUlVXSD0lZdR+FyhjLo0knspD7+hYyXV+QtDOhjHBjwrQuMkkXPDe4 UiD+OtKyjLFgfZD+4RNjUW8vjghz7cIT6nAHw8SGOvxICrFnwHows+xrglMMn0zIITQO h9uobPrHy3IjyQZMf7EY4mPquiAXrDZP7r99WFG/2RQBkUNY4AFXRNL6/jcBsVtDEYJq STNAr+0YhNgi55ykEEJ7xaCQLX4gKhbXg3QD/y2R4E1yLT8hCvNSnTVu04+KEacDmgpz NR6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=1Kb38thZlbl33NciqGP4Ww1F/3vhXvHqKbnItEFr8wc=; b=VQusEfVG4hMX2mHjt1lv9OkzdG5sstigNLnQkXWnJz3lBTM0PTrfmrzb1Wtx0i9oWH 1X/nGUppH8KjpDnoX2h80/OncH31l9P6QhOnnyPPuJnFFTAU0aqytq9eMBCUOyP+/U5Q qNZJ/8K8PEATmeg4Insl7qtgJYer8rC1sc9oj0rDO8rHXfRafNLDBZvMsrEHH8b5ilSg QTjF6ABJYDl3QhXDE1OPqbEZLEMszZvy0y1lKRuEvHZeDGJ6BYv1pkviHfIyQtPpozBp D5pKXcsrxD5tENFN9fZ9QI66BeiF5I8Zof3cH4mFlQQgBtpWnSP4gozhYPsIoMORUTFT QBcg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=XfONCcyx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b1si16992545ejb.102.2021.05.10.13.00.21; Mon, 10 May 2021 13:00:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=XfONCcyx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231977AbhEJT6e (ORCPT + 99 others); Mon, 10 May 2021 15:58:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53184 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231628AbhEJT6d (ORCPT ); Mon, 10 May 2021 15:58:33 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AEFEFC061574 for ; Mon, 10 May 2021 12:57:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=1Kb38thZlbl33NciqGP4Ww1F/3vhXvHqKbnItEFr8wc=; b=XfONCcyx7NKtkbmdJHx54H0AvU GdvfPFweatTjTbhL2RbxGz15j87DKjGy3BmPobPwOcZNR0/TV5MrKlI8RGNVUCT8EnpSGyS17mY1Z MIiXBxYDMWGrUuCyONvBgOVKMZoTWDOpy7TgXXVuebLQ0EwXBLmk0fKK2AOLLHZJV7Yi74WHMoWHM 3vwoXH2YLZQQMvkxCTvO/vdXXEt85Hj4JJp59V/hlaPyri7fDtjTXTKnLBMWCILxAvVBRB1hsfG0q P+RAqHsQhm397mc3JyTwlqE6jGaslwy+cOnCrQS0eXqZK+eH1F2HxHsYRh1d81VCVoWwmXI/wYBsd JcGtNrrw==; Received: from willy by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lgC1O-006WlH-V3; Mon, 10 May 2021 19:57:00 +0000 Date: Mon, 10 May 2021 20:56:54 +0100 From: Matthew Wilcox To: Liam Howlett Cc: "maple-tree@lists.infradead.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Andrew Morton , Song Liu , Davidlohr Bueso , "Paul E . McKenney" , Laurent Dufour , David Rientjes , Axel Rasmussen , Suren Baghdasaryan , Vlastimil Babka , Michel Lespinasse Subject: Re: [PATCH] mm/mmap: Introduce unlock_range() for code cleanup Message-ID: References: <20210510195020.2778501-1-Liam.Howlett@Oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210510195020.2778501-1-Liam.Howlett@Oracle.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 10, 2021 at 07:50:22PM +0000, Liam Howlett wrote: > Both __do_munmap() and exit_mmap() unlock a range of VMAs using almost > identical code blocks. Replace both blocks by a static inline function. > > Signed-off-by: Liam R. Howlett Reviewed-by: Matthew Wilcox (Oracle) > +static inline void unlock_range(struct vm_area_struct *start, unsigned long limit) Seems like an unnecessary >80 column line ... static inline void unlock_range(struct vm_area_struct *start, unsigned long limit)