Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751175AbWJWUqm (ORCPT ); Mon, 23 Oct 2006 16:46:42 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751359AbWJWUql (ORCPT ); Mon, 23 Oct 2006 16:46:41 -0400 Received: from zeus1.kernel.org ([204.152.191.4]:9965 "EHLO zeus1.kernel.org") by vger.kernel.org with ESMTP id S1751175AbWJWUql (ORCPT ); Mon, 23 Oct 2006 16:46:41 -0400 Date: Mon, 23 Oct 2006 22:45:19 +0200 From: Adrian Bunk To: "Eric W. Biederman" Cc: Yinghai Lu , Andi Kleen , Muli Ben-Yehuda , Linux Kernel Mailing List , Andrew Morton Subject: Re: [PATCH] x86_64 irq: reuse vector for set_xxx_irq_affinity in phys flat mode Message-ID: <20061023204519.GJ3502@stusta.de> References: <86802c440610230002x340e3f95pa8ee98caa02e7e@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1676 Lines: 42 On Mon, Oct 23, 2006 at 09:32:57AM -0600, Eric W. Biederman wrote: > "Yinghai Lu" writes: > > > in phys flat mode, when using set_xxx_irq_affinity to irq balance from > > one cpu to another, _assign_irq_vector will get to increase last used > > vector and get new vector. this will use up the vector if enough > > set_xxx_irq_affintiy are called. and end with using same vector in > > different cpu for different irq. (that is not what we want, we only > > want to use same vector in different cpu for different irq when more > > than 0x240 irq needed). To keep it simple, the vector should be resued > > from one cpu to another instead of getting new vector. > > > > Signed-off-by: Yinghai Lu > > YH. I think the concept is sound. I don't think this is a bug fix, just > an optimization so this may not be 2.6.19 material. But we are thrashing > things so much it may make sense to include it, and it likely to keeps > us from running into problems, so it can be called a bug preventative :) >... Is this patch intended as fix for the 2.6.19-rc regression described in [1]? > Eric cu Adrian [1] http://lkml.org/lkml/2006/10/21/227 -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/