Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp2921052pxj; Mon, 10 May 2021 13:56:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzbQxH2CH8cuM0V2C2/sP3kPAWSWvB43I2QoQgiqYyb74u28NnTDNTeTHlxkLURA4XOwUWG X-Received: by 2002:a17:906:11d4:: with SMTP id o20mr27821700eja.247.1620680206485; Mon, 10 May 2021 13:56:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620680206; cv=none; d=google.com; s=arc-20160816; b=kilf2LZYnTNh3HhznwtTuRqUJH7CW7nNnS0ry/FQZyZ7BwOzHXq2ZMHlXNlw3paBd9 suR2aBC00rW7UvZ76bEsdu/iqd2hyU3lOKpjZ3FspDhWei2W6EABtKGYv7rFdd/ZXNPT YVb7FTtuwotbSqGApvPyaTVN17cJ1tvHQGjD4vUtsUe1LSP0fID7k4OJ2nbX6WZdvgTy 65/KxPYm7cT5BGsOwUbOtXyWAKKuWsqeesQgIeWdt+jIdlLf+62q0m3s7e4Lia6ccHTx 5MrbdkSOAgA4bdjkEXaey0xjfLKFgb+kKesKK+5rFGKuDcVPoIWegL9tEYN+23e9ZEBW Vnbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=9u1bWm+wMG0wleduKDsfRD/ISspIfmoacCqdbEduS70=; b=m3D6QBfTTAvCyLV+J9xp39T4Ro5cNYDtyul71oYHA9/5BuwkidxN31tLdfZm7xlqG/ hE08xiQVlYtX7MCYtqgo6uwmSPkVlb7u220+mSAN2M5s7a5FYhaMigg5i82tKTJCw765 zQJ5hBeT2KkWDvj9tc7Fd+o7agNr2sSIn7FBU9y/SQCbIBNDgLcfQpEGheggjivYVFm+ IQ0OwS+SpfpKc+o9YcEqQmdUWZhJUnGe/1aQokNZ7i8hjejSy+Wkbtzpe0cc3zbvs+io fSrDMUQE+EW/RHpOJSklDek3S89xu6weDGTkqdPHrsks729+YQx/g6N8k0SUxTVpCmnO +dJQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@landley-net.20150623.gappssmtp.com header.s=20150623 header.b=07VWv3bG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r5si1054014edm.3.2021.05.10.13.56.22; Mon, 10 May 2021 13:56:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@landley-net.20150623.gappssmtp.com header.s=20150623 header.b=07VWv3bG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232481AbhEJU4W (ORCPT + 99 others); Mon, 10 May 2021 16:56:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37836 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232345AbhEJU4V (ORCPT ); Mon, 10 May 2021 16:56:21 -0400 Received: from mail-oi1-x232.google.com (mail-oi1-x232.google.com [IPv6:2607:f8b0:4864:20::232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 47E1EC061760 for ; Mon, 10 May 2021 13:55:16 -0700 (PDT) Received: by mail-oi1-x232.google.com with SMTP id w22so3171934oiw.9 for ; Mon, 10 May 2021 13:55:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=landley-net.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=9u1bWm+wMG0wleduKDsfRD/ISspIfmoacCqdbEduS70=; b=07VWv3bG3mqPHl9O5DXepUYWpD3EvEfNY28LK1KB/UH2Kwt0GjhNrqdbJkHRvWPjJM hWx4RDSwmmwIS/oBRuTkVfA+khJ21cY7Cult/tXugu2B9aa1P2q8WsPpePMq5r6cy1PB yIsSaO6Deosd2gedOK7qUjMnGDR3Z1Ull7qY/0vGXgPfqoT1Few0vCD9k1rqzfpX6Ymq E9MCLGiKtTflzLg1xHy6+tRe8QXRyxfKg7nmGmA6sLOCp383eEOk625RCGdh4k5MI0Gv N9UrdmdmlwtsB78O0Z/6LtER9DuDgzBGsRiWATjw85lGWG8M3N9C63eoOkpshD22lxeU Zwcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=9u1bWm+wMG0wleduKDsfRD/ISspIfmoacCqdbEduS70=; b=iI8kQTjtzMkEqZCRGeLGY9E/fNYncHA+3LtomWzQlqURmu47iDT116ajWzVVFcyTUh LM/nKHEfQcgObmRk0t/g0rm6uiHVObUEwztswgc6JGJgZ/8rCYKKbzlj4s4UcEsDo87u 77cMlrW6KaJDrCvA1s+ZUtdcCvc0LuPJHD0LbGN6AD+sOFtFpit3oiVMLr6fjdYHAP/P QHUmHyHEDx6juXC0xotL1dg3F6DVlkMCXIz1GHwf1QyzIwmkF2gtL90ltysPfIhZTGjw v9MGE6sjzaYTS4XhhTvB3EmdZ2R4XfEtE7CWiKweJGgnrDdmd+cIRfChzGsZ1N3EAgzw KCWg== X-Gm-Message-State: AOAM531lOSEqfPfBAo5MuW9vW3a9BAWPwnJ2qCHTOFhGE0PpGMfZdctx iITNOhu+CeJ31x2/gKuOqLUBZSNs5QNNwPP6 X-Received: by 2002:aca:5b86:: with SMTP id p128mr19761737oib.127.1620680115142; Mon, 10 May 2021 13:55:15 -0700 (PDT) Received: from [192.168.86.122] ([136.62.4.88]) by smtp.gmail.com with ESMTPSA id c65sm2799334oia.47.2021.05.10.13.55.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 May 2021 13:55:14 -0700 (PDT) Subject: Re: [RFC 03/12] sh: remove unaligned access for sh4a To: Arnd Bergmann , linux-arch@vger.kernel.org Cc: Linus Torvalds , Vineet Gupta , Arnd Bergmann , Yoshinori Sato , Rich Felker , linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210507220813.365382-1-arnd@kernel.org> <20210507220813.365382-4-arnd@kernel.org> From: Rob Landley Message-ID: <1b1d34a8-d170-7287-1c99-40d2af83d1b9@landley.net> Date: Mon, 10 May 2021 16:11:03 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20210507220813.365382-4-arnd@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/7/21 5:07 PM, Arnd Bergmann wrote: > From: Arnd Bergmann > > Unlike every other architecture, sh4a uses an inline asm implementation > for get_unaligned(). I have shown that this produces better object > code than the asm-generic version. However, there are very few users of > arch/sh/ overall, and most of those seem to use sh4 rather than sh4a CPU Hitachi's sh4, sh3, and sh2 are all out of patent, and have been cloned as open hardware. (Modulo the sh4 clone uses a different mmu design, but lots of regression testing gets done against qemu-system-sh4 and sh4 hardware using the original mmu.) Plus superh was the bestselling CPU architecture in the world for 3 years back in the 1990s, and there's a remaining userbase from that. sh5 and the "a" designs like sh4a were created by renesas after hitachi spun off the IP to them, and are not out of patent. I do not have access to an sh4a test system. > Signed-off-by: Arnd Bergmann > --- > arch/sh/include/asm/unaligned-sh4a.h | 199 --------------------------- > arch/sh/include/asm/unaligned.h | 13 -- All I can test is that it didn't cause regressions on my sh4 and j-core systems, which it (unsurprisingly) did not. Acked-by: Rob Landley Rob