Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Liam Howlett <liam.howlett@oracle.com>
To:     Matthew Wilcox <willy@infradead.org>
CC:     "maple-tree@lists.infradead.org" <maple-tree@lists.infradead.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Song Liu <songliubraving@fb.com>,
        Davidlohr Bueso <dave@stgolabs.net>,
        "Paul E . McKenney" <paulmck@kernel.org>,
        Laurent Dufour <ldufour@linux.ibm.com>,
        David Rientjes <rientjes@google.com>,
        Axel Rasmussen <axelrasmussen@google.com>,
        Suren Baghdasaryan <surenb@google.com>,
        Vlastimil Babka <vbabka@suse.cz>,
        Michel Lespinasse <michel@lespinasse.org>
Subject: Re: [PATCH] mm/mmap: Introduce unlock_range() for code cleanup
Thread-Topic: [PATCH] mm/mmap: Introduce unlock_range() for code cleanup
Thread-Index: AQHXRdW2cmhwkET57kappKEjcFfu8qrdIZQAgAAR5YA=
Date:   Mon, 10 May 2021 21:01:16 +0000
Message-ID: <20210510210057.mk7hgtdrxa5c5wt6@revolver>
References: <20210510195020.2778501-1-Liam.Howlett@Oracle.com>
 <YJmQBp9r5UgvQiWr@casper.infradead.org>
In-Reply-To: <YJmQBp9r5UgvQiWr@casper.infradead.org>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-ID: <7444805AE6186C40933C8489E07D2EF8@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 294b7cfe-3bbe-466a-ea7b-08d913f6c0a3
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 May 2021 21:01:16.3326
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 2Z/ObJcYSWTYmI24g72ADcVovKaEuZxlwcbptuNL6qQKOFdJ7W4gp+EClU3sLowxgm/SOiBDjD3qb9Czrg7G7A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR10MB1309
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9980 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 phishscore=0
 adultscore=0 bulkscore=0 mlxscore=0 suspectscore=0 malwarescore=0
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2104190000 definitions=main-2105100144
X-Proofpoint-GUID: eIFwCES94S_Agei69HDhXFRThSErXFg9
X-Proofpoint-ORIG-GUID: eIFwCES94S_Agei69HDhXFRThSErXFg9
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9980 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 priorityscore=1501
 suspectscore=0 clxscore=1015 bulkscore=0 adultscore=0 impostorscore=0
 spamscore=0 phishscore=0 mlxlogscore=999 mlxscore=0 lowpriorityscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000
 definitions=main-2105100144
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

* Matthew Wilcox <willy@infradead.org> [210510 15:57]:
> On Mon, May 10, 2021 at 07:50:22PM +0000, Liam Howlett wrote:
> > Both __do_munmap() and exit_mmap() unlock a range of VMAs using almost
> > identical code blocks.  Replace both blocks by a static inline function=
.
> >=20
> > Signed-off-by: Liam R. Howlett <Liam.Howlett@Oracle.com>
>=20
> Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>
>=20
> > +static inline void unlock_range(struct vm_area_struct *start, unsigned=
 long limit)
>=20
> Seems like an unnecessary >80 column line ...
>=20
> static inline
> void unlock_range(struct vm_area_struct *start, unsigned long limit)
>=20

Sorry about that, checkpatch also did not see this.  I will send a v2.=