Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 10 May 2021 23:14:30 +0200
From:   Andrea Parri <parri.andrea@gmail.com>
To:     Wei Liu <wei.liu@kernel.org>
Cc:     Michael Kelley <mikelley@microsoft.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        KY Srinivasan <kys@microsoft.com>,
        Haiyang Zhang <haiyangz@microsoft.com>,
        Stephen Hemminger <sthemmin@microsoft.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "jejb@linux.ibm.com" <jejb@linux.ibm.com>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
        "linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH hyperv-next] scsi: storvsc: Use blk_mq_unique_tag() to
 generate requestIDs
Message-ID: <20210510211430.GA370521@anparri>
References: <20210415105926.3688-1-parri.andrea@gmail.com>
 <MWHPR21MB15936B2FBD1C1FE91C654F3DD74D9@MWHPR21MB1593.namprd21.prod.outlook.com>
 <20210506174516.aiuuhu7oediqozv4@liuwe-devbox-debian-v2>
 <20210510173321.lfw4nha7wrzfgkkd@liuwe-devbox-debian-v2>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210510173321.lfw4nha7wrzfgkkd@liuwe-devbox-debian-v2>
Precedence: bulk

On Mon, May 10, 2021 at 05:33:21PM +0000, Wei Liu wrote:
> On Thu, May 06, 2021 at 05:45:16PM +0000, Wei Liu wrote:
> > On Thu, Apr 15, 2021 at 01:22:32PM +0000, Michael Kelley wrote:
> > > From: Andrea Parri (Microsoft) <parri.andrea@gmail.com> Sent: Thursday, April 15, 2021 3:59 AM
> > > > 
> > > > Use blk_mq_unique_tag() to generate requestIDs for StorVSC, avoiding
> > > > all issues with allocating enough entries in the VMbus requestor.
> > > > 
> > > > Suggested-by: Michael Kelley <mikelley@microsoft.com>
> > > > Signed-off-by: Andrea Parri (Microsoft) <parri.andrea@gmail.com>
> > > > ---
> > > > Changes since RFC:
> > > >   - pass sentinel values for {init,reset}_request in vmbus_sendpacket()
> > > >   - remove/inline the storvsc_request_addr() callback
> > > >   - make storvsc_next_request_id() 'static'
> > > >   - add code to handle the case of an unsolicited message from Hyper-V
> > > >   - other minor/style changes
> > > > 
> > > > [1] https://lore.kernel.org/linux-hyperv/20210408161315.341888-1-parri.andrea@gmail.com/
> > > > 
> > > >  drivers/hv/channel.c              | 14 ++---
> > > >  drivers/hv/ring_buffer.c          | 13 +++--
> > > >  drivers/net/hyperv/netvsc.c       |  8 ++-
> > > >  drivers/net/hyperv/rndis_filter.c |  2 +
> > > >  drivers/scsi/storvsc_drv.c        | 94 +++++++++++++++++++++----------
> > > >  include/linux/hyperv.h            | 13 ++++-
> > > >  6 files changed, 95 insertions(+), 49 deletions(-)
> > > 
> > > LGTM
> > > 
> > > Reviewed-by: Michael Kelley <mikelley@microsoft.com>
> > 
> > Although this patch is tagged with SCSI, I think it would be better if
> > this goes through the hyperv tree. Let me know if there is any
> > objection.
> 
> Andrea, please rebase this patch on top of hyperv-next. It does not
> apply as-is.

Sent  https://lkml.kernel.org/r/20210510210841.370472-1-parri.andrea@gmail.com

Thanks,
  Andrea