Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp2951018pxj; Mon, 10 May 2021 14:46:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwDmx8O4HMn02m0PbdfaaaK7kpKjHvCjfv7NRYogvAetSNxZXa4+TCo2TylAgdGrwHpr20p X-Received: by 2002:a6b:e80f:: with SMTP id f15mr16778674ioh.64.1620683167207; Mon, 10 May 2021 14:46:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620683167; cv=none; d=google.com; s=arc-20160816; b=d2FZXnM8l2fsdxQEV6i4sBiUi8CmX/jlRzQJP8rnHlpjf3ZfS1UkY/HMGXgJ1Kygwl ncJhREjVd4zG7ET9RR6KfFetK4VJ5yE460bAvI5AY1ej9oYAfjMurzVp/goh6P+8Mugj wXzjq238CqETMyRzySuKmj7B1k4sAXtyBc8yKkZdiaf5vOuQdMGZJ+HD6SdSCwqjXpcC 8ehEskEbq9aJmOSZ5ic5t2C5bBHjTufrOGJE5LDlVZ/NeZfuXydSLXMLviQm27/NjfE2 hfcVZyI8aEvQZkMhZzw6kZWV+Lg69aLsmBB4IUVnWqrriQg+vyvlB9W36OiZjdeu0vd6 +IDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:references :in-reply-to:subject:cc:to:dkim-signature:dkim-signature:from; bh=lpZHZILIVURBA4uZge0VeiF3/MxcG74g/FLqlaAURhc=; b=awLe/vSGHH3XqpSPUn+3P2DQyIrq0ukqkhKGQxRYy3kEQA31dDVrSFGr0vyVi9byOF r41sUtenHSExQM5zzxdYJf3IJ090XRu/RIlWNd5/Swdkt0mH27EqDOCVZWc5T7dIis05 PGxTXsLqFXj1rqN7PfezQuzdku9uJg+WPs7Y4vmWUQeiHHuiaBWeRme6qsABav87TE3I RzGPoOgGWLY2Tz7mlFJF7FdjW7QinifdA2dk2MYDwKYJqbDOhOoXb8LKn50K94TyxoW5 hOjsR29ZrMSrhta8GCPiy1tS2QhPOh4jgNQ6K2XTDx2uDdCeL34blmqItGIGmEdLN1IW FnGg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linutronix.de header.s=2020 header.b=YxBeXXWE; dkim=neutral (no key) header.i=@linutronix.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o14si20947746iow.26.2021.05.10.14.45.53; Mon, 10 May 2021 14:46:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@linutronix.de header.s=2020 header.b=YxBeXXWE; dkim=neutral (no key) header.i=@linutronix.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232257AbhEJVpM (ORCPT + 99 others); Mon, 10 May 2021 17:45:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48970 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231434AbhEJVpM (ORCPT ); Mon, 10 May 2021 17:45:12 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CF621C061574 for ; Mon, 10 May 2021 14:44:06 -0700 (PDT) From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1620683043; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lpZHZILIVURBA4uZge0VeiF3/MxcG74g/FLqlaAURhc=; b=YxBeXXWEQgJ5X2nX0hY5xOeOa3vM2NwSDUlf24gr0P2uW0IVZj7jbroySMJALdl1aB+GgU yMje+laDS5hdkKtebyV2b/0n8S0slU+nvIPz+uqLHAoKHjyatn9jDj140h78nlVT/pFm7F OhzUi3EZ0R2nz09WVlq7/Afy0zNoQ/8WRVvBxrsHF1T58uk/a0sJK8USA4mslBDM++/0zU Vw7rYPQbrlux3UuQal3XHl6IyDQ0kThJRKkuACtr5g374Kq3dN8gP9hG1QwguV6ZWKev/N 2SaLetL0SWWrxP5D580sfEQ3411R3wnrEbLHfw3jvNyx/6UFpROuIKQToaz9gw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1620683043; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lpZHZILIVURBA4uZge0VeiF3/MxcG74g/FLqlaAURhc=; b=3t+psbvTUJjOUoaFVqIThGokCXoG0I38L+HBKfPA1LyRnCAoIZa0bVRAsVnwK9Iqv94ZUp CCb1MJOFYPbOTtCA== To: "Saripalli\, RK" Cc: linux-kernel@vger.kernel.org, x86@kernel.org, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, Jonathan Corbet , bsd@redhat.com, Josh Poimboeuf , Kees Cook Subject: Re: [PATCH v5 1/1] x86/cpufeatures: Implement Predictive Store Forwarding control. In-Reply-To: References: <20210505190923.276051-1-rsaripal@amd.com> <20210505190923.276051-2-rsaripal@amd.com> <87wnsamvaa.ffs@nanos.tec.linutronix.de> Date: Mon, 10 May 2021 23:44:03 +0200 Message-ID: <87h7jagt7g.ffs@nanos.tec.linutronix.de> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 10 2021 at 06:10, RK Saripalli wrote: > On 5/7/2021 10:13 AM, Thomas Gleixner wrote: >> What's wrong with just treating this in the same way in which we treat >> all other speculative vulnerabilities and provide a consistent picture >> to the user? >> >> Something like the below. You get the idea. > > Thomas, thank you very much for the comments. > > I provided the links to the original patches which treat PSF similar to other > speculative vulnerabilities. > > Could you review them please?. The first patch is the cover letter. > > https://lore.kernel.org/lkml/20210406155004.230790-1-rsaripal@amd.com/ > https://lore.kernel.org/lkml/20210406155004.230790-2-rsaripal@amd.com/ > https://lore.kernel.org/lkml/20210406155004.230790-3-rsaripal@amd.com/ > https://lore.kernel.org/lkml/20210406155004.230790-4-rsaripal@amd.com/ > https://lore.kernel.org/lkml/20210406155004.230790-5-rsaripal@amd.com/ > https://lore.kernel.org/lkml/20210406155004.230790-6-rsaripal@amd.com/ They are going into the right direction, i.e. detection and reporting. Vs. mitigation control the question is whether we need the full machinery of prctl/seccomp and so forth especially under the aspect that the SSBD mitigation already covers the PSF issue. So for the start a simple on/off might be good enough. Kees, any opinions? Thanks, tglx