Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp2981364pxj; Mon, 10 May 2021 15:35:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJweuEAebk/J1lJMwEGyNIHhp6eL9LAlJ5LpnGqy7Q9qAbDUHRTPHnZsiLSpyJyvcJ9bGjbh X-Received: by 2002:a5d:8147:: with SMTP id f7mr20045147ioo.135.1620686157361; Mon, 10 May 2021 15:35:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620686157; cv=none; d=google.com; s=arc-20160816; b=01Gr/Z3C3NjqfEeprJmkXYL+LeBLYpSsQcb/aCZgpNBxfkVX4JmlUDCLBilFxn0yYj r4zvn24T3SWGoOFZnU7LTLj6iC7W5AFyz4sx1YDBWmo9m0iwxO8Px1dRD6QiOWGzRbzp 5nTdPSC9UD5xvvuxK2ETWq5xt75GhFCF6DndeAbqKUFwDaZmkAtgbOxhbZo4Zr+yhImV yPxMkjvIeKuIk66XhMmEO+EXXfUW13ePZMJ82wEuJdj4kpDnzi9djuEYVg3So51g4jW9 wWAJGwlDjZMDLxVGw4xr8PSWSDFA6zAUXLbRHYiwkeVxYlRrKZa+6w2coEFAX/DL7wgj aDDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=9GhutQNehYBAmzOzGjF9GzKnWEwK9dadMDkrgc0W7xg=; b=azR65bTFhyA47QSDvADXfbjcYJX3YC0u/B0+sLXRfhDb/np4dgumLnkNW09xVlcMF1 XRZ3PXcMzKREmqns1/3JH7wVaj4IjU0CZ5fpgNY5RQ0dlY1hVS21yYn7ssLU2DW4ustJ 5W/IdJsNRxcO3/h7ZrLXRse3kewVWYT7a8YVu9+S5A22BXB9M9Dpj1u9sXwblSSjwUPU h0hRHtdUurw+ugj2a1LY/OqXswcUEJddWnSptgpBF+P6eQHP/ZzIpzy5l0TV/XbLo5eV N/QtRFArxxmYWhF9EFJmILDn13e+mgDSrAU2XXirrL7SvaD/b0MfOnNurZF3pLpX4h5M 1oNA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b="mRR/P06s"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a5si17572369ilq.155.2021.05.10.15.35.44; Mon, 10 May 2021 15:35:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b="mRR/P06s"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231277AbhEJWfK (ORCPT + 99 others); Mon, 10 May 2021 18:35:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60246 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231205AbhEJWfJ (ORCPT ); Mon, 10 May 2021 18:35:09 -0400 Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D542CC061574 for ; Mon, 10 May 2021 15:34:03 -0700 (PDT) Received: by mail-pl1-x636.google.com with SMTP id h20so9868001plr.4 for ; Mon, 10 May 2021 15:34:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=9GhutQNehYBAmzOzGjF9GzKnWEwK9dadMDkrgc0W7xg=; b=mRR/P06sNQFUcyLyWrTzy7HSz9Fxt8KQr9qNoeo64i5SY7/iGcRMx2UOBfBKCD5Khz 0+BvznE5OntLiU8EGOdqRYUh3fsWA/CjCWOnSzbn1LG1ig++laWccU2Yw0p8TkU71Pnr uayeESg+XGLKg5zSNQVaQ4d1z62KE8ruvXOOQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=9GhutQNehYBAmzOzGjF9GzKnWEwK9dadMDkrgc0W7xg=; b=f0FpvXV6HDzaDs429NbVTI/a+p1zTPyia4oNodzH7iG2OW2ke5m6102zpaBiaHEFAQ kWs+ka55kD2Ssp7/ucIX1+2rwv6HQVrBd28GwdZ28eEmoXklgJAdaPES3WAZzk50ijQ7 urDzodBJ/MLPq5VAabOatMrn/ntUMgUA4hoaLzXbmndnWjV6swmN7QAQg1w8ampE3yup 9S9gZOpQGrn3ZV4PncgCUDqUThD6etJp19ru+IGN0en2o6ScEiWgfmiumUthiJoDKdYL 1htXv7ll3xiJDzXbJ6ZnYFNnfEXXYIp6aqiL1hmzfJCwG/DyVsCjhYOqI+6iDu+/ntP7 teeg== X-Gm-Message-State: AOAM5335SG/Ribvjp76Ug0IbmE4wCrAt6TjbsDTinXZzR3Y4poPRboW1 H3fVn/Z//sVcXhzzPr8ixfHT4A== X-Received: by 2002:a17:90a:6e5:: with SMTP id k92mr1559175pjk.198.1620686043374; Mon, 10 May 2021 15:34:03 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id z18sm11863989pfa.39.2021.05.10.15.34.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 May 2021 15:34:02 -0700 (PDT) Date: Mon, 10 May 2021 15:34:01 -0700 From: Kees Cook To: Thomas Gleixner Cc: "Saripalli, RK" , linux-kernel@vger.kernel.org, x86@kernel.org, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, Jonathan Corbet , bsd@redhat.com, Josh Poimboeuf , Andi Kleen , Andrea Arcangeli Subject: Re: [PATCH v5 1/1] x86/cpufeatures: Implement Predictive Store Forwarding control. Message-ID: <202105101529.F628137@keescook> References: <20210505190923.276051-1-rsaripal@amd.com> <20210505190923.276051-2-rsaripal@amd.com> <87wnsamvaa.ffs@nanos.tec.linutronix.de> <87h7jagt7g.ffs@nanos.tec.linutronix.de> <202105101508.BC6CC99FAD@keescook> <878s4mgrqz.ffs@nanos.tec.linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <878s4mgrqz.ffs@nanos.tec.linutronix.de> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 11, 2021 at 12:15:32AM +0200, Thomas Gleixner wrote: > On Mon, May 10 2021 at 15:09, Kees Cook wrote: > > On Mon, May 10, 2021 at 11:44:03PM +0200, Thomas Gleixner wrote: > >> Kees, any opinions? > > > > I agree: if PSF is a subset of SSBD, there's no need for the additional > > machinery. > > > > On a related topic, what happened to Andi's patch to switch the seccomp > > defaults? I can't find it now... > > You mean this one: > > https://lore.kernel.org/r/20200312231222.81861-1-andi@firstfloor.org > > If so, then it has lacks a follow up. Ah-ha, found it. I misremembered the author. :) https://lore.kernel.org/lkml/20201104235054.5678-1-aarcange@redhat.com/ Specifically these two patches: https://lore.kernel.org/lkml/20201104235054.5678-1-aarcange@redhat.com/ https://lore.kernel.org/lkml/20201105001406.13005-2-aarcange@redhat.com/ And, Thomas, while I have your attention, I'd really like this to go in for -rc2, if you can snag it: https://lore.kernel.org/lkml/20210419231741.4084415-1-keescook@chromium.org/ :) Thanks! -- Kees Cook