Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp3093784pxj; Mon, 10 May 2021 18:41:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyuf2Rd3H9uTlcuZCHOuXHP4eJ9kvOJF/dJ/mINxZRtbm8GyDecSBLDSKXC3LHtwvQ4iEEa X-Received: by 2002:a02:90cd:: with SMTP id c13mr24152098jag.18.1620697265986; Mon, 10 May 2021 18:41:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620697265; cv=none; d=google.com; s=arc-20160816; b=mVs/kQHyL6zAxVyjQh0vynevs31TosOW2Ip2INJ8KzL/qd57iIucsqBhBVl7mILua0 K6P1liUtrdACLyXRfQn6Zwbxjznhzd8VSBE6sGBS4qjJVFmpNMcrvWGnljWLGoHt9MAq bZ9Jyqzdnlk7ywvyrqJ/zGo0g1vJhFgvAi37j55Ky5F+ctcmv5xXs/CdNsPGchk2axOq jYkgiT+hY00NKKd00rRQbT/cqLvf0kq6WATy6yYzKUallNY9FP1FrZXmnaLLw4h7j/OC 0pwIk2NhS2PyiwdRA9vJz0KEyrICKvV6eOV3xbMnRX8+MruaKO0kFSHHuCfWVKYTo3Sf 7/3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=UewUIUnZEU+WLxgt73DD3mXzDpZZk6Udya01I4ZEHrw=; b=kuZ8PDded//Ics6m/d8w9vWQBtdfWOskIYRW4itzMi0LwxhCBpNrk92+uorC3QTSCQ Oww0qUQBiR0s1gXL+Z/bKhnfPAQGFcePZOJUNTW4+/Aw734UY+1LmOluKqUEC3BF+QzB 2z95ewwrfaC0tVskTxmuYXXTavb8tVx6V2TDofademkWMd3gc/hYNnjoxm1QTdmbNQ6j Khs/Es7dfHrU3KQtRQAluyeUJGo9FkN+fBnfkUY5biLIng/LanY9FsN7tr5yy4SD/xE6 qJos6ezhkPDxxHlOOv4lXRZsl4hBmu6vLKOnrEqjry093aSjCTZ46I6vFJmCy36g7HKm yCRQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@paul-moore-com.20150623.gappssmtp.com header.s=20150623 header.b=kswNC8Bf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l2si18874517ios.47.2021.05.10.18.40.53; Mon, 10 May 2021 18:41:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@paul-moore-com.20150623.gappssmtp.com header.s=20150623 header.b=kswNC8Bf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230176AbhEKBl3 (ORCPT + 99 others); Mon, 10 May 2021 21:41:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45294 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230023AbhEKBl2 (ORCPT ); Mon, 10 May 2021 21:41:28 -0400 Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [IPv6:2a00:1450:4864:20::52c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3F464C061574 for ; Mon, 10 May 2021 18:40:23 -0700 (PDT) Received: by mail-ed1-x52c.google.com with SMTP id di13so20934970edb.2 for ; Mon, 10 May 2021 18:40:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=UewUIUnZEU+WLxgt73DD3mXzDpZZk6Udya01I4ZEHrw=; b=kswNC8BfZzTXjrd6CNTModmWLgnAvrz8jFPHApeblmQg6rKJTfpByfO00OR0Pz90U7 j1h5wLO98+mXFSkHIGaBBPFlGFIlVgszWA4z5S//jxNs7j6V5k7SvxLs2BACJNEA6cY6 DdJk9F38VUmJZBUbe9y0G/3gP+BARMhWvICBTY4L0I+bRubNxCVz0PQMxcRQKAw3iRiO 9MY1YMyzrEx57GDbBf8hCIEs3/VeMBEt//BpG/7jKlbyR/3VUWpUVsq//ToDHX33Pe2D UrYTX7tsSokm+E8dtjV5qW0tm9osyXnMLHx2HdZLyQm8oWzBGAc9Z9pL9D7wg9NU6CQ0 vTOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=UewUIUnZEU+WLxgt73DD3mXzDpZZk6Udya01I4ZEHrw=; b=duTfF7tcUECVlR3S+gTuEJ+5zD4w16eT6qy8OfYvJUBXHpuE9us+2uGbb0WgrLsrYi KKywZGDLdQ6G4gTwdIDHvgGnX6LDw+yP5wxSDEa26q/HlLccBXGfwZ9MIj9WOKTZ/CiJ G5oLy9SDicADk6nX2YafYNzhw16VoMQ8d8hjljpF1W72YJpY91wFp4F/YW1ZpE7UIQ/H GXzX1yPlYmBFkd++RqW3FCL/xFCZmhaHDKXnA3b4t+Z4rljpv/UhtsVGvwy1fRIDhl7e r4XQ0tIyUwfhxh9QeQyl22zO/d+HjdZY39HWAjMTkY9VLF1MObw2tmdhJT/znhtZ9JkG Rdbg== X-Gm-Message-State: AOAM5324NSY+cQeb6FYuUMEsXYiAxKGbRddph1dCANl9IC+Hupuv7NG+ FcM8ZaNWNZwqzCa38LPPEsekCjHHvFUVoSeaRXM0 X-Received: by 2002:a05:6402:177c:: with SMTP id da28mr32267501edb.135.1620697221981; Mon, 10 May 2021 18:40:21 -0700 (PDT) MIME-Version: 1.0 References: <20210409054841.320-1-hbut_tan@163.com> In-Reply-To: <20210409054841.320-1-hbut_tan@163.com> From: Paul Moore Date: Mon, 10 May 2021 21:40:11 -0400 Message-ID: Subject: Re: [PATCH 2/2] selinux:Delete selinux_xfrm_policy_lookup() useless argument To: Zhongjun Tan Cc: steffen.klassert@secunet.com, herbert@gondor.apana.org.au, davem@davemloft.net, kuba@kernel.org, James Morris , Serge Hallyn , Stephen Smalley , Eric Paris , keescook@chromium.org, gregkh@linuxfoundation.org, ebiederm@xmission.com, kpsingh@google.com, dhowells@redhat.com, christian.brauner@ubuntu.com, zohar@linux.ibm.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-security-module@vger.kernel.org, selinux@vger.kernel.org, Zhongjun Tan Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 9, 2021 at 1:52 AM Zhongjun Tan wrote: > > From: Zhongjun Tan > > seliunx_xfrm_policy_lookup() is hooks of security_xfrm_policy_lookup(). > The dir argument is uselss in security_xfrm_policy_lookup(). So > remove the dir argument from selinux_xfrm_policy_lookup() and > security_xfrm_policy_lookup(). > > Signed-off-by: Zhongjun Tan > --- > include/linux/lsm_hook_defs.h | 3 +-- > include/linux/security.h | 4 ++-- > net/xfrm/xfrm_policy.c | 6 ++---- > security/security.c | 4 ++-- > security/selinux/include/xfrm.h | 2 +- > security/selinux/xfrm.c | 2 +- > 6 files changed, 9 insertions(+), 12 deletions(-) Merged into selinux/next, thanks. -- paul moore www.paul-moore.com