Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp3098928pxj; Mon, 10 May 2021 18:50:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzh59VMMx+832lT7vTgBtCNbcciU77svQ/d+P45AxeGO0WNa3NYYdBOtxla5/roIpwPUb0R X-Received: by 2002:a5d:8c82:: with SMTP id g2mr20230307ion.34.1620697827395; Mon, 10 May 2021 18:50:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620697827; cv=none; d=google.com; s=arc-20160816; b=Y1FYsFOdOyJERpAMlK6TU7zI/nUeKDo9n7t4KioY4Wf1ff3azunCU2LDxW9LZf4BLH vhzGnK6zo4WTwoWZGhk+Z+49sY7Cw6+yJjP1HqNUGQ9a3lq7L4YDtf7UixB039Nrdvf/ DoBW0sF5jJRfFtkxwYAuPNc9Of9Cu5rkN9DJrR5hchozzyGcAsXBoRrrlrjNOOzv4EE0 XxpoNJxR/s+EKAVo10Qy3VZ2u12TnMYYhSb0wEuiSlyLzYheUyYdUgxJd/OnXdfaqhGT jGg8m5YPX5lOFWSyWyWnj1XBGqghFRsUpLbB3OgFHm2ylIgf8KPDeOhsyRnmtxR4XVEA 2slg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=GC+jcwYuSlGwJ2d485mepP4KelpwOyaTe94c08xajfQ=; b=uxEdMDQ9qlENhi2/nygF840jzimBdLPpWLQ5Ssq9v3PMJI+M6PzQW/FZhx2yQ3EMVy P6HOu3p0z5xqabXfWhBBaga45ySuvBOCbb3TkbybYui0ErrT7RPjIEgSXS1aRamdEfSn yml3tGTqbFMTWn3O1XxGU6Es/71y6Jp5IR93CJVKqa2pfrEQJy4XjxbOxHKIgMmpP84m 8+eCNyhvwZe6iz5yaImtdLBOk27LOWmWEeen/RLhvtn/GSvuzMdF6X/H9icbxuodQnsZ P3aLvHLsL3h6uetFi4xe/0SPpQX9JQMepu6FjDNVOlch4iHsjXzz5hmRC/9MM0HSRMi/ u69A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@paul-moore-com.20150623.gappssmtp.com header.s=20150623 header.b=xZeeTRD1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l2si18874517ios.47.2021.05.10.18.50.14; Mon, 10 May 2021 18:50:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@paul-moore-com.20150623.gappssmtp.com header.s=20150623 header.b=xZeeTRD1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230023AbhEKBun (ORCPT + 99 others); Mon, 10 May 2021 21:50:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47370 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230334AbhEKBun (ORCPT ); Mon, 10 May 2021 21:50:43 -0400 Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [IPv6:2a00:1450:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8EFD3C061574 for ; Mon, 10 May 2021 18:49:36 -0700 (PDT) Received: by mail-ed1-x535.google.com with SMTP id y26so20944727eds.4 for ; Mon, 10 May 2021 18:49:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=GC+jcwYuSlGwJ2d485mepP4KelpwOyaTe94c08xajfQ=; b=xZeeTRD1Py3Ep5O8bkGrjjCbMORAPBblaI9SG5G7RNQvcwF81lU7VKMHEEx/RZbbis H+eTlm5BQh3XW4suI5xn6He5ui1geRSvdmxGw4kDXGHZMKzThcUNQBrc+QPsOjF7ecNi X3Ks+DVHKy+IDRyoi+WPFcJLy86hLZar9QnLg9lHmteELQIN38+03VEyGnZOpOfUBFEr iibOmzhCeqDu4tLZCsCNDGf622ynCiSOu+5B6xFKtD7kxriPKDFGNwFqs8a/FQOAV/PT eoJMf0C+Q7LrtUzVpQk4L8TK50IWSjEPOjPhbzqV2bBicMp2n2Ty6nLRMnISFyJfAxqm huCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GC+jcwYuSlGwJ2d485mepP4KelpwOyaTe94c08xajfQ=; b=YovvBN/1yTjVB3Ff9IvGgj+w1HNcmHzEf572fUKTbepJL7cr+Gsyl0b7fZNwz+r2Yf hgMAT/NGxJlsfFx8JBNGoRBwmLVKYoa2g4nK4NnvisQnwYBf6HOFLoBR7JMPYVc+lcV1 mJN0MX4oWDkCzcBLbZgoVF+XmkLI+1hgBxPOPjOnXYlXoj7ITCaNVPCRGTWTNjyCl1Km Q5yThEfeBlTytTK0VKJToHYVydIGLB4iUN1efn9sp2nolFaHPyh0EEH7EXTcNiS8oY4r WcUvD5g95f1XigvGh1zK9SXasUukoFIdFffPDmfR8x5cjognUBmky1Url1t5UnswDlQA GMLQ== X-Gm-Message-State: AOAM530Vbj86LF3xa8yOyEAlJdSqw+pS39BxAq3hGU/R+BdlGBdu0Qj4 LSJTTypyNU8nF0Gl/+QfoPONgQVfUSyOQdUrvR8P X-Received: by 2002:aa7:de9a:: with SMTP id j26mr10088284edv.269.1620697775288; Mon, 10 May 2021 18:49:35 -0700 (PDT) MIME-Version: 1.0 References: <1619604015-117734-1-git-send-email-jiapeng.chong@linux.alibaba.com> In-Reply-To: <1619604015-117734-1-git-send-email-jiapeng.chong@linux.alibaba.com> From: Paul Moore Date: Mon, 10 May 2021 21:49:24 -0400 Message-ID: Subject: Re: [PATCH] selinux: Remove redundant assignment to rc To: Jiapeng Chong Cc: Stephen Smalley , Eric Paris , selinux@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 28, 2021 at 6:00 AM Jiapeng Chong wrote: > > Variable rc is set to '-EINVAL' but this value is never read as > it is overwritten or not used later on, hence it is a redundant > assignment and can be removed. > > Cleans up the following clang-analyzer warning: > > security/selinux/ss/services.c:2103:3: warning: Value stored to 'rc' is > never read [clang-analyzer-deadcode.DeadStores]. > > security/selinux/ss/services.c:2079:2: warning: Value stored to 'rc' is > never read [clang-analyzer-deadcode.DeadStores]. > > security/selinux/ss/services.c:2071:2: warning: Value stored to 'rc' is > never read [clang-analyzer-deadcode.DeadStores]. > > security/selinux/ss/services.c:2062:2: warning: Value stored to 'rc' is > never read [clang-analyzer-deadcode.DeadStores]. > > security/selinux/ss/policydb.c:2592:3: warning: Value stored to 'rc' is > never read [clang-analyzer-deadcode.DeadStores]. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong > --- > security/selinux/ss/policydb.c | 1 - > security/selinux/ss/services.c | 4 ---- > 2 files changed, 5 deletions(-) Merged into selinux/next, thanks. -- paul moore www.paul-moore.com