Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp3139469pxj; Mon, 10 May 2021 20:10:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwGKG9Bg6t9WGrRtPIg4SXm8cpKm3h0YfEfptV53TakHaSdUMplDQ7LAXnVwgHWoACpPUdp X-Received: by 2002:a17:906:38c5:: with SMTP id r5mr27732861ejd.230.1620702641700; Mon, 10 May 2021 20:10:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620702641; cv=none; d=google.com; s=arc-20160816; b=N0T8+aWb8ZDOJJJoC+kwv/Etc4b+uPdQQ+NsTFksmLCOH18eX6zVPmC2iU9xrHX6l8 bMvtLWIkbvShld15go62JJNLEw2wb3YRgd4RyXToy6YIqIsRC9TwK7gT/KC1oYHuyEdp f3kzH0NUgw+ckDaje3MiC6c31ZvyQJbKLB442ixtKEMIg05uiFvOqkScGjR8lUY00I10 I4euEtxYPJzL43H6QmTkMoPr+oOlzmrKCO3HToK9vG8tUahzduf2dGUpRz9HJkrSZrCv bdT+Q6ohxzRLpLPAN3mswk04geMojNUABSGJN/x0Ux7r1Zb8RlZirh4GcSccqGwT4gWi rdwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=vDycCYZUMZTRqclL05OsIOu92QLf1/h6CaOCTWyUtQo=; b=fBCxrmxDLFKD63fcEWPlNG8nsQxx8QUD3P0Bt0Ho+1a8O6K4CKNX0xAQM4ouPXlJ32 Da03yTn8Oy8/JvQfjI29Sf88F0lj57ZM/oZP2mxkOL+mSeCbHO2FasLmKfoi2O4YakQX Fs7nzTIs9PSjaFg/pY7kwysJccxk13k3lWNEdhuplNSkjTZkGZjtM9DZGkduJA/3bwS2 ql95xvha0SxhpR4C3JHLxnqOVGurIkH7s5EruHLEPEyi3TxI282BZ0vsPWx1ANu2YcX/ VAD5cEpG5j+V/kmORBzupuUl1FNhXDWieHSrEGHWKblJKZjQfh46ie/kbI/v3fWw6uYx L2PQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="Dhn/Bhsz"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h13si14566195ejj.292.2021.05.10.20.10.17; Mon, 10 May 2021 20:10:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="Dhn/Bhsz"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229736AbhEKDKQ (ORCPT + 99 others); Mon, 10 May 2021 23:10:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36794 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229465AbhEKDKP (ORCPT ); Mon, 10 May 2021 23:10:15 -0400 Received: from mail-pg1-x531.google.com (mail-pg1-x531.google.com [IPv6:2607:f8b0:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7E815C061574 for ; Mon, 10 May 2021 20:09:09 -0700 (PDT) Received: by mail-pg1-x531.google.com with SMTP id j12so8688666pgh.7 for ; Mon, 10 May 2021 20:09:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=vDycCYZUMZTRqclL05OsIOu92QLf1/h6CaOCTWyUtQo=; b=Dhn/BhszXa2kmPxmeAjJZYOD5Q7FN+5J43AnvUof7WBdQWttlGaEwkvQQgWAjXaE9u qJOZ/yX1ulX4HuW7ajZ6GdoCulDHmG8cQswpAnl3+iJL8DOgHsVLW1YyYB4LYdGJZNwM AcMlHdcxwlaDuwr0hSzgL6r2fUoWKQ/77/FmOpBUh49HQv/HDBJmTIoO5nqiqGYhn9zb ywTZkmiylk4imwnye5wkH+Sp5f92j9gZCLkOTO97qVPSmpbMp8Ei60l4a+1k+LDg+b9T Ki3KkwIZB6ZLy124T1rtAfmH9ZUwN7k1Uj6aql+DKdQae9U7Q0dML4K8qQvKwamwtO78 Cf0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=vDycCYZUMZTRqclL05OsIOu92QLf1/h6CaOCTWyUtQo=; b=kgXzl90uTUcHDAqPkvswT7PA5QX7akpLVP89VqrcDAjE2526GS76d7LPSiixyNquVH xXDeEIeSFNBNDkHqyZBI8x3IYosQ35oAkzdI3aghOQxkPrEYtym/Y3l6Z1WH0W9w/d+x q3FpSBNV8Dx5BjzOszPO0uOFqudfHGmBxn1XxWo8xOTLRbfpwp808ue+SxCQXu1oGDuC 49ZoKq7UvogCZVa5uth6blrEP7usxFxBZ8AZgt3PpM19S8Cn4I4E45YUCNWxwuEfnF0d dnCPp+DH7aTPw9uQZc05aSN2ghpa5XkFDA/OYt2/NRNomtfxzm2iVpDRkkhS1U2NNLgg f8Aw== X-Gm-Message-State: AOAM53066/zY3zgBBvJ7MnWZQ5h32/WkmIzK/Ympqjb6qRRQ79cpRcNE YdakQyXy20OhY/y/n5yW5oY= X-Received: by 2002:a62:1c0c:0:b029:2b7:6dd2:adb3 with SMTP id c12-20020a621c0c0000b02902b76dd2adb3mr12703106pfc.44.1620702548963; Mon, 10 May 2021 20:09:08 -0700 (PDT) Received: from hyeyoo ([183.99.11.150]) by smtp.gmail.com with ESMTPSA id 33sm12156742pgq.21.2021.05.10.20.09.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 May 2021 20:09:08 -0700 (PDT) Date: Tue, 11 May 2021 12:09:03 +0900 From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: Christoph Lameter Cc: Vlastimil Babka , Matthew Wilcox , penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] mm: kmalloc_index: make compiler break when size is not supported Message-ID: <20210511030903.GA105690@hyeyoo> References: <20210508221328.7338-1-42.hyeyoo@gmail.com> <20210510135857.GA3594@hyeyoo> <9d0ffe49-a2e2-6c81-377b-4c8d2147dff8@suse.cz> <20210510150230.GA74915@hyeyoo> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 10, 2021 at 05:15:23PM +0200, Christoph Lameter wrote: > I guess this needs to be reviewed and tested by the users of architectures > that can use large MAXORDER pages such as powerpc and Itanium. as Vlastimil Babka said, I think it's fine too. because KMALLOC_SHIFT_HIGH can't be bigger than 25 regardless of MAX_ORDER