Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <978a829103c768a01ed8a1b37ea607ea5fb0ddb0.camel@fi.rohmeurope.com>
Subject: Re: [PATCH 4/4] extcon: extcon-max8997: Fix IRQ freeing at error
 path
From:   Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Reply-To: matti.vaittinen@fi.rohmeurope.com
To:     Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc:     Chanwoo Choi <cw00.choi@samsung.com>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
        MyungJoo Ham <myungjoo.ham@samsung.com>,
        Hans de Goede <hdegoede@redhat.com>,
        Marek Szyprowski <m.szyprowski@samsung.com>,
        linux-kernel@vger.kernel.org
In-Reply-To: <edf3ff4d-8bd7-17cf-0d7c-96b4f704dddd@canonical.com>
References: <cover.1620633360.git.matti.vaittinen@fi.rohmeurope.com>
         <9047a741b4c4d97e721ed8b48cc4b434a46acba3.1620633360.git.matti.vaittinen@fi.rohmeurope.com>
         <edf3ff4d-8bd7-17cf-0d7c-96b4f704dddd@canonical.com>
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
Date:   Tue, 11 May 2021 06:32:20 +0300
User-Agent: Evolution 3.34.4 (3.34.4-1.fc31) 
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Krzysztof,

On Mon, 2021-05-10 at 10:21 -0400, Krzysztof Kozlowski wrote:
> On 10/05/2021 04:12, Matti Vaittinen wrote:
> > If reading MAX8997_MUIC_REG_STATUS1 fails at probe the driver exits
> > without freeing the requested IRQs.
> 
> The driver frees IRQ on probe failure, so maybe you meant missing IRQ
> mapping dispose?

No. The commit 3e34c8198960 ("extcon: max8997: Avoid forcing UART path
on drive probe") introduced a return w/o IRQ freeing if reading the
MAX8997_MUIC_REG_STATUS1 fails at the end of the probe. This is not
visible in the patch though - as the return is Ok after the IRQs and
work-queue cancellation are managed by devm.

Best Regards
	--Matti Vaittinen