Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210510053125.1595659-1-pihsun@chromium.org> <20210510053125.1595659-2-pihsun@chromium.org>
In-Reply-To: <20210510053125.1595659-2-pihsun@chromium.org>
From:   Hsin-Yi Wang <hsinyi@chromium.org>
Date:   Tue, 11 May 2021 12:34:09 +0800
Message-ID: <CAJMQK-jYb_0+AA_bBrvkJ4JaT1mQTr6uGZQbbpnyA1CJ_NLKuw@mail.gmail.com>
Subject: Re: [PATCH v3 2/2] drm/bridge: anx7625: add suspend / resume hooks
To:     Pi-Hsun Shih <pihsun@chromium.org>
Cc:     Tzung-Bi Shih <tzungbi@google.com>,
        Andrzej Hajda <a.hajda@samsung.com>,
        Neil Armstrong <narmstrong@baylibre.com>,
        Robert Foss <robert.foss@linaro.org>,
        Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
        Jonas Karlman <jonas@kwiboo.se>,
        Jernej Skrabec <jernej.skrabec@siol.net>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>, Xin Ji <xji@analogixsemi.com>,
        Sam Ravnborg <sam@ravnborg.org>,
        "open list:DRM DRIVERS" <dri-devel@lists.freedesktop.org>,
        open list <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, May 10, 2021 at 1:31 PM Pi-Hsun Shih <pihsun@chromium.org> wrote:
>
> Add suspend / resume hooks for anx7625 driver, that power off the device
> on suspend and power on the device on resume if it was previously
> powered.
>
> Signed-off-by: Pi-Hsun Shih <pihsun@chromium.org>

Tested-by: Hsin-Yi Wang <hsinyi@chromium.org>

Tested on a mt8183 juniper device.

> ---
>
> Changes from v2:
> * No change.
>
> ---
>  drivers/gpu/drm/bridge/analogix/anx7625.c | 27 +++++++++++++++++++++++
>  1 file changed, 27 insertions(+)
>
> diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
> index e1bf31eafe22..b165ef71e00f 100644
> --- a/drivers/gpu/drm/bridge/analogix/anx7625.c
> +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
> @@ -1705,7 +1705,34 @@ static int __maybe_unused anx7625_runtime_pm_resume(struct device *dev)
>         return 0;
>  }
>
> +static int __maybe_unused anx7625_resume(struct device *dev)
> +{
> +       struct anx7625_data *ctx = dev_get_drvdata(dev);
> +
> +       if (!ctx->pdata.intp_irq)
> +               return 0;
> +
> +       if (!pm_runtime_enabled(dev) || !pm_runtime_suspended(dev))
> +               anx7625_runtime_pm_resume(dev);
> +
> +       return 0;
> +}
> +
> +static int __maybe_unused anx7625_suspend(struct device *dev)
> +{
> +       struct anx7625_data *ctx = dev_get_drvdata(dev);
> +
> +       if (!ctx->pdata.intp_irq)
> +               return 0;
> +
> +       if (!pm_runtime_enabled(dev) || !pm_runtime_suspended(dev))
> +               anx7625_runtime_pm_suspend(dev);
> +
> +       return 0;
> +}
> +
>  static const struct dev_pm_ops anx7625_pm_ops = {
> +       SET_SYSTEM_SLEEP_PM_OPS(anx7625_suspend, anx7625_resume)
>         SET_RUNTIME_PM_OPS(anx7625_runtime_pm_suspend,
>                            anx7625_runtime_pm_resume, NULL)
>  };
> --
> 2.31.1.607.g51e8a6a459-goog
>