Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: eYDM7yZN8vfYRIwg697Tha/N3pMh8/n8epDDu8OTxC+ZuDPvY7vyia2v9CKz2UgjwqcAifMJvd
 Ql3Ii+4J+Tmw==
IronPort-SDR: RZyI3NqDyiLi8q2VUwWMZEZvwDk4gq3uFE3eY95VmnEM1S6ryfZAzq4MvxZvKjzFm/e6ZZYy50
 guf7gc/3R4hg==
From:   "Winkler, Tomas" <tomas.winkler@intel.com>
To:     Guenter Roeck <linux@roeck-us.net>
CC:     Arnd Bergmann <arnd@arndb.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] mei: Drop unnecessary NULL check after container_of
Thread-Topic: [PATCH] mei: Drop unnecessary NULL check after container_of
Thread-Index: AQHXRiHYJEv7njgv4kuJ2lTX3NAWS6rdvT9A
Date:   Tue, 11 May 2021 05:16:41 +0000
Message-ID: <42c7b18dae6648d69346cc6b77e92178@intel.com>
References: <20210511045512.2376580-1-linux@roeck-us.net>
In-Reply-To: <20210511045512.2376580-1-linux@roeck-us.net>
Accept-Language: en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-reaction: no-action
dlp-version: 11.5.1.3
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Precedence: bulk


> 
> The result of container_of() operations is never NULL unless the embedded
> element is the first element of the data structure, which is not the case here.
> The NULL check is therefore unnecessary and misleading. Remove it.
> 
> This change was made automatically with the following Coccinelle script.
> 
> @@
> type t;
> identifier v;
> statement s;
> @@
> 
> <+...
> (
>   t v = container_of(...);
> |
>   v = container_of(...);
> )
>   ...
>   when != v
> - if (\( !v \| v == NULL \) ) s
> ...+>
> 
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Acked-by: Tomas Winkler <tomas.winkler@intel.com>
> ---
>  drivers/misc/mei/main.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/misc/mei/main.c b/drivers/misc/mei/main.c index
> 28937b6e7e0c..9001c45f6fc4 100644
> --- a/drivers/misc/mei/main.c
> +++ b/drivers/misc/mei/main.c
> @@ -50,8 +50,6 @@ static int mei_open(struct inode *inode, struct file *file)
>  	int err;
> 
>  	dev = container_of(inode->i_cdev, struct mei_device, cdev);
> -	if (!dev)
> -		return -ENODEV;
> 
>  	mutex_lock(&dev->device_lock);
> 
> --
> 2.25.1