Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 11 May 2021 11:07:56 +0300
From:   Pekka Paalanen <ppaalanen@gmail.com>
To:     Alex Deucher <alexdeucher@gmail.com>,
        Werner Sembach <wse@tuxedocomputers.com>
Cc:     Dave Airlie <airlied@linux.ie>,
        LKML <linux-kernel@vger.kernel.org>,
        amd-gfx list <amd-gfx@lists.freedesktop.org>,
        "Leo \(Sunpeng\) Li" <sunpeng.li@amd.com>,
        Maling list - DRI developers 
        <dri-devel@lists.freedesktop.org>,
        "Deucher, Alexander" <alexander.deucher@amd.com>,
        Christian Koenig <christian.koenig@amd.com>
Subject: Re: [PATCH] drm/amd/display: Expose active display color
 configurations to userspace
Message-ID: <20210511110756.7e754c30@eldfell>
In-Reply-To: <CADnq5_O7uuSj-nmKXRvGVTb9n1e+Bb-SU3Psi7BVhN4AOYhHsQ@mail.gmail.com>
References: <20210507192718.35314-1-wse@tuxedocomputers.com>
        <CADnq5_O7uuSj-nmKXRvGVTb9n1e+Bb-SU3Psi7BVhN4AOYhHsQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
 boundary="Sig_/HEwpQv.ZV+VGiXcatNUIIMr"; protocol="application/pgp-signature"
Precedence: bulk

--Sig_/HEwpQv.ZV+VGiXcatNUIIMr
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

On Mon, 10 May 2021 17:47:01 -0400
Alex Deucher <alexdeucher@gmail.com> wrote:

> On Fri, May 7, 2021 at 3:27 PM Werner Sembach <wse@tuxedocomputers.com> w=
rote:
> >
> > xrandr --prop and other userspace info tools have currently no way of
> > telling which color configuration is used on HDMI and DP ports.
> >
> > The ongoing transsition from HDMI 1.4 to 2.0 and the different bandwidth
> > requirements of YCbCr 4:2:0 and RGB color format raise different
> > incompatibilities. Having these configuration information readily
> > available is a useful tool in debuging washed out colors, color artefac=
ts
> > on small fonts and missing refreshrate options. =20
>=20
> I think we would ideally want these as generic connector properties
> rather than AMD specific ones since they are not really AMD specific.
> I believe there is already a generic drm property (max_bpc) for the
> color depth.  At this point, I think having a generic RGB vs YCbCr
> property would make sense.  I'm not sure about the color space.

Hi,

I believe that userspace will definitely want to know what exactly is
going on on the monitor cable, so I think exposing more information is
good, but I agree that it needs to be done with generic KMS properties
as much as possible. Userspace is not going to bother having explicit
code for driver-specific properties.

I think a major use case will be Wayland color management, where a
Wayland compositor will want to make sure that the video signal
parameters have not changed since the monitor was last measured
(profiled). If the signal configuration is different, the measured
color profile may be invalid and therefore the end user needs to be
warned. See some ideas in
https://gitlab.freedesktop.org/wayland/weston/-/issues/467
under the heading "Color calibration auditing system".

About the color space: is that something a kernel driver will decide
on its own? I mean in the same sense as the driver will negotiate
HDMI/DP link parameters, perhaps falling back to smaller requirements
if higher requirements signal does not seem to work.

We only need readback properties for things that generic userspace
won't or cannot control explicitly, e.g. because the kernel driver has
room to make a choice rather than fail.


Thanks,
pq

--Sig_/HEwpQv.ZV+VGiXcatNUIIMr
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEJQjwWQChkWOYOIONI1/ltBGqqqcFAmCaO1wACgkQI1/ltBGq
qqeF0A/7B6wXH1lcVQjMdfy0O2DC2PdZFUqoKmKJ44jPH2BH8MTFrvc/Bp1XPkcc
Kj6HZL6VrmMnPxniVgqLZ7kH5xK8cw3SvAWBadcbJ5T6r27i+Q6BvefLCIFz9B06
GXKAFIQ6aCqaSqIRSSRqK8KYJ5Jz+fguAhfmCxK+Scd3arW8bwX/uLQnLvRmLr3K
+8WhLFMzXRCNDOHCCSEqrT231uQyWzr1dBgXJ4BMl7Pz6MRF4U+VlJD2DoVez54c
lOpPRBcpQ6Omt68JofVoQ/oxjzlIZpo5N3WSMYWKoikM8E3Tm/sd+acnsnXdFlKJ
vofGNg6GaOUU4gCi1LZh9Bt9BwVRD8/qpcnJaOk2sX1+hLRcrPdl5zXXFTXkg0lY
nwBRcAyBgooJOci/tFj0UugD7/EwHw9TxCZYLtw7d3CZfEtY90lJSO/ADNis3sFw
X3EgLbTH591llu73BwFYUuQ7X1f/15OyBFrWOH/mpjeIZMSem8Q5nifiOxaXFw+J
j3oTH8WCXLRm1LYOm+ushVQl57FUxVD/sSAdvgo4jwX6uO/s29Lp3h5TO5jKPneV
siY2ycHLXPszJHxjT0dUKTgwgxD9AmLWW7SrYwnswSQZpqW07d2waK08SKjj+a1s
7HBBWQQeV71V/5f1HIws7SRNOddVqpbYgHyfKvJZA/y0fhQf8EY=
=24IE
-----END PGP SIGNATURE-----

--Sig_/HEwpQv.ZV+VGiXcatNUIIMr--