Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Fabrizio Castro <fabrizio.castro.jz@renesas.com>
To:     Rob Herring <robh@kernel.org>,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>
CC:     "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Ramesh Shanmugasundaram <rashanmu@gmail.com>,
        "linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
        "linux-renesas-soc@vger.kernel.org" 
        <linux-renesas-soc@vger.kernel.org>
Subject: RE: [PATCH] dt-bindings: media: renesas,drif: Use graph schema
Thread-Topic: [PATCH] dt-bindings: media: renesas,drif: Use graph schema
Thread-Index: AQHXRdv/jnc1n9IF/0+AWGHP9QP/dKrd+MIw
Date:   Tue, 11 May 2021 08:51:26 +0000
Message-ID: <OSAPR01MB27373779BEED96CA812710BEC2539@OSAPR01MB2737.jpnprd01.prod.outlook.com>
References: <20210510203514.603471-1-robh@kernel.org>
In-Reply-To: <20210510203514.603471-1-robh@kernel.org>
Accept-Language: en-GB, en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: bf61f38c-3531-4277-83ca-08d91459f679
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 May 2021 08:51:26.7530
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: X4SCgC41IRxHCmhn6LfU5e504wBoTEzwR8gw5+p9tOankVHPjUj7jPsnSIX2IDhVJiXoh+LBczDDBeiP67TGuBPO9CYYkxEOFRAKyUj0uKM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: OS3PR01MB6292
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Rob,

thank you for your patch.

> From: Rob Herring <robh@kernel.org>
> Sent: 10 May 2021 21:35
> Subject: [PATCH] dt-bindings: media: renesas,drif: Use graph schema
>=20
> Convert the renesas,drif binding schema to use the graph schema. The
> binding referred to video-interfaces.txt, but it doesn't actually use any
> properties from it as 'sync-active' is a custom property. As 'sync-active=
'
> is custom, it needs a type definition.
>=20
> Cc: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
> Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
> Cc: Ramesh Shanmugasundaram <rashanmu@gmail.com>
> Cc: linux-media@vger.kernel.org
> Cc: linux-renesas-soc@vger.kernel.org
> Signed-off-by: Rob Herring <robh@kernel.org>

Reviewed-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com>

Best regards,
Fab

> ---
>  .../bindings/media/renesas,drif.yaml          | 20 +++++++------------
>  1 file changed, 7 insertions(+), 13 deletions(-)
>=20
> diff --git a/Documentation/devicetree/bindings/media/renesas,drif.yaml
> b/Documentation/devicetree/bindings/media/renesas,drif.yaml
> index f1bdaeab4053..ce505a7c006a 100644
> --- a/Documentation/devicetree/bindings/media/renesas,drif.yaml
> +++ b/Documentation/devicetree/bindings/media/renesas,drif.yaml
> @@ -99,32 +99,26 @@ properties:
>        Indicates that the channel acts as primary among the bonded
> channels.
>=20
>    port:
> -    type: object
> +    $ref: /schemas/graph.yaml#/properties/port
> +    unevaluatedProperties: false
>      description:
> -      Child port node corresponding to the data input, in accordance wit=
h
> the
> -      video interface bindings defined in
> -      Documentation/devicetree/bindings/media/video-interfaces.txt.
> -      The port node must contain at least one endpoint.
> +      Child port node corresponding to the data input. The port node mus=
t
> +      contain at least one endpoint.
>=20
>      properties:
>        endpoint:
> -        type: object
> +        $ref: /schemas/graph.yaml#/$defs/endpoint-base
> +        unevaluatedProperties: false
>=20
>          properties:
> -          remote-endpoint:
> -            description:
> -              A phandle to the remote tuner endpoint subnode in remote
> node
> -              port.
> -
>            sync-active:
> +            $ref: /schemas/types.yaml#/definitions/uint32
>              enum: [0, 1]
>              description:
>                Indicates sync signal polarity, 0/1 for low/high
> respectively.
>                This property maps to SYNCAC bit in the hardware manual.
> The
>                default is 1 (active high).
>=20
> -        additionalProperties: false
> -
>  required:
>    - compatible
>    - reg
> --
> 2.27.0