Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210415032958.740233-1-ikjn@chromium.org> <20210415032958.740233-2-ikjn@chromium.org>
 <CAFqH_53GXdCfPCke_UN3fqrDxHZ_scd21ZekVzrYoVWbmLUmrw@mail.gmail.com> <CAL_JsqJ0mqqK69m_iFKTqGzu_TYvR7WdsuKw-ead74Sc=6msDw@mail.gmail.com>
In-Reply-To: <CAL_JsqJ0mqqK69m_iFKTqGzu_TYvR7WdsuKw-ead74Sc=6msDw@mail.gmail.com>
From:   Ikjoon Jang <ikjn@chromium.org>
Date:   Tue, 11 May 2021 16:55:25 +0800
Message-ID: <CAATdQgAUGUntdZCwyP_7gdqD+sXYPubitwEHOfdvmZ=F3wmzHw@mail.gmail.com>
Subject: Re: [PATCH v5 1/2] mfd: google,cros-ec: add DT bindings for a
 baseboard's switch device
To:     Rob Herring <robh+dt@kernel.org>, Jiri Kosina <jikos@kernel.org>
Cc:     Enric Balletbo Serra <eballetbo@gmail.com>,
        Linux Input <linux-input@vger.kernel.org>,
        devicetree <devicetree@vger.kernel.org>,
        Dmitry Torokhov <dtor@chromium.org>,
        Hsin-Yi Wang <hsinyi@chromium.org>,
        Benson Leung <bleung@chromium.org>,
        Enric Balletbo i Serra <enric.balletbo@collabora.com>,
        Guenter Roeck <groeck@chromium.org>,
        Lee Jones <lee.jones@linaro.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, Apr 16, 2021 at 9:30 PM Rob Herring <robh+dt@kernel.org> wrote:
>
> On Fri, Apr 16, 2021 at 12:37 AM Enric Balletbo Serra
> <eballetbo@gmail.com> wrote:
> >
> > Hi Ikjoon,
> >
> > Thank you for your patch.
> >
> > Missatge de Ikjoon Jang <ikjn@chromium.org> del dia dj., 15 d=E2=80=99a=
br.
> > 2021 a les 5:32:
> > >
> > > This is for ChromeOS tablets which have a 'cros_cbas' switch device
> > > in the "Whiskers" base board. This device can be instantiated only by
> > > device tree on ARM platforms. ChromeOS EC doesn't provide a way to
> > > probe the device.
> > >
> > > Signed-off-by: Ikjoon Jang <ikjn@chromium.org>
> > >
> > > ---
> > >
> > > Changes in v5:
> > >  - Add missing blank lines and change the description property's posi=
tion.
> > >  - Add a note to description: "this device cannot be detected at runt=
ime."
> > >
> > > Changes in v4:
> > > Define cros-cbase bindings inside google,cros-ec.yaml instead of
> > > a separated binding document.
> > >
> > >  .../bindings/mfd/google,cros-ec.yaml          | 20 +++++++++++++++++=
++
> > >  1 file changed, 20 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/mfd/google,cros-ec.yam=
l b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml
> > > index 76bf16ee27ec..8dcce176b72e 100644
> > > --- a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml
> > > +++ b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml
> > > @@ -114,6 +114,22 @@ properties:
> > >        - "#address-cells"
> > >        - "#size-cells"
> > >
> > > +  cbas:
> > > +    type: object
> > > +
> > > +    description:
> > > +      This device is used to signal when a detachable base is attach=
ed
> > > +      to a Chrome OS tablet. This device cannot be detected at runti=
me.
> > > +
> > > +    properties:
> > > +      compatible:
> > > +        const: google,cros-cbas
> > > +
> > > +    required:
> > > +      - compatible
> > > +
> > > +    additionalProperties: false
> > > +
> > >  patternProperties:
> > >    "^i2c-tunnel[0-9]*$":
> > >      type: object
> > > @@ -180,6 +196,10 @@ examples:
> > >              interrupts =3D <99 0>;
> > >              interrupt-parent =3D <&gpio7>;
> > >              spi-max-frequency =3D <5000000>;
> > > +
> > > +            base_detection: cbas {
> >
> > nit: Rob, shouldn't this be just cbas?
>
> Yes.

Sorry, I'm a bit confused here.
'base_detection: cbas' in example should be just 'cbas'?
Maybe that's because cbas doesn't need to have a phandle or just by
its definition in schema?

Please let me upload v6 if this needs to be fixed.

Thanks for reviewing!


>
> >
> > > +                compatible =3D "google,cros-cbas";
> > > +            };
> > >          };
> > >      };
> > >
> > > --
> > > 2.31.1.295.g9ea45b61b8-goog
> > >
> >
> > Acked-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>