Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 11 May 2021 18:10:33 +0800
From:   Jisheng Zhang <Jisheng.Zhang@synaptics.com>
To:     Vitaly Wool <vitaly.wool@konsulko.com>
Cc:     Jisheng Zhang <jszhang3@mail.ustc.edu.cn>,
        Paul Walmsley <paul.walmsley@sifive.com>,
        Palmer Dabbelt <palmer@dabbelt.com>,
        Albert Ou <aou@eecs.berkeley.edu>,
        linux-riscv <linux-riscv@lists.infradead.org>,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] riscv: code patching only works on !XIP_KERNEL
Message-ID: <20210511181033.580c1eba@xhacker.debian>
In-Reply-To: <CAM4kBBJqF=AxTu50PF=EshLSyqn0=yeC2dwf4JJj_Grsi_Tccg@mail.gmail.com>
References: <20210511002838.7b3cb1e7@xhacker>
        <CAM4kBBJqF=AxTu50PF=EshLSyqn0=yeC2dwf4JJj_Grsi_Tccg@mail.gmail.com>
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from xhacker.debian (192.147.44.204) by BYAPR07CA0035.namprd07.prod.outlook.com (2603:10b6:a02:bc::48) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.25 via Frontend Transport; Tue, 11 May 2021 10:10:40 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: d0794d99-d938-46f9-67bb-08d914650966
X-MS-TrafficTypeDiagnostic: BN9PR03MB6140:
X-Microsoft-Antispam-PRVS: <BN9PR03MB6140DB6712221F0F6D0854CAED539@BN9PR03MB6140.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: RrjntnvAMncP0lT+wGqzDQFlYhhbPjmEDobQovAMiR/x/rASUC/AK56IGUqbPV7c4JYSp1iyLcDdtSdwZrUUe5TthTxT7k2JIQPs2zSrrSYYzXsl1dRKOG7MXpIUQ6vuUsbeJGyLb/FpsBBCUZDCcyj1+qcOr5wWkJYe5ZCuC9OKyEwO21QT8j/WqIMONSKpPddRS0t6vgqQYiIQWgVNXpN+yhIQhyOzFBooteDxVYuqGR6Wx/aH2p8dF+cW3mWQFvdQAtKFiSU/3sqldyHDbhF0Xvwpw/ioVehVk+5rArSq3V+9n0oSn2URZ6QsQfT8dLVNyS/w+KBvYQsUXRHg42T3pDnut8w+3eLrs2zlZC9SxL9vDKzDnlenTaExl7muRGoL4dZDtJFHCY9i2PF9SjHWDFTbYXtNB2lRfqerPslxE0EolsgHM+JrXcOdt1c15STZaiaHOOQLqy+2aDwU+2NLJXXNnqkAYqFSa55mzvgC/M3CXspAEXRRmHraBogcDvO7VVt1ts6d6dNReMRaEvZ9zxJ34Jo6uvdCbsTfnWpZLssQQvrQU00TUpUwoCDcNWKy15eV39mq18EXW1Eebgc8/fmOBtkserR8Oj1bhYjhY/72hNQTdocaXbLOo5SelrcBtZ1dfzp0wpyIEkPQQBtOG13pTn0a6oSVkaNqzj8=
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR03MB6058.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(136003)(346002)(39840400004)(366004)(376002)(396003)(956004)(9686003)(7696005)(53546011)(6506007)(83380400001)(38100700002)(55016002)(2906002)(38350700002)(52116002)(316002)(26005)(66556008)(4326008)(478600001)(66476007)(6666004)(66946007)(86362001)(1076003)(8676002)(186003)(54906003)(16526019)(5660300002)(6916009)(8936002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?jnHjzx3kBXGCvn4k0R3absuASyZm2VzDbELGkgOOgsWkuaXkNY2UEKUXcjon?=
 =?us-ascii?Q?mVGzfrXGxycbxetSgmn24sYX7MxcCZNdW+JHXLpz+8pJHgBYrwdyqgxg6slN?=
 =?us-ascii?Q?CxNKhXn9aw/nQ33WSGYs/3cRJhYDFgUcGqMb157w1Eh67+dzkswKHU3iTEND?=
 =?us-ascii?Q?acoE0iQY7MiIUVfrLbad1frjFFfxOJ4uV6LmbkEX7DyqlQg2itNesVpSdXH2?=
 =?us-ascii?Q?FdiDkUhJ5ABJydetSPuGN1urLJJ9ojL9N5UeP4G14FAHpMaouUiJgHkyegs1?=
 =?us-ascii?Q?2+Vagv5dvyr8uKY0VdIv9+ehi95aDL/JZnAvFw2iPUcH8bUv3pIb+rKkSMa5?=
 =?us-ascii?Q?+MygFRmeWn1WE/KRdriy9C19jcspmLUUY7C6ofB2eesU/FBx28VMRQLxwDIK?=
 =?us-ascii?Q?loeM9OiMk9euJZeeP/kgwH9Jdik0mdsnAil32Uml3vy5fYUxxC12QBPlvKVf?=
 =?us-ascii?Q?BkBskt5AoscdG+jZ+86RVjartCDLIA5akQthL9fQW9cjmsn3u968tjpFkcWV?=
 =?us-ascii?Q?nOIQSTNPPnAm58QaSmQNWmJnyjtv6Sa6JlQIWAWOvb/D9Vk/ke0SIOdyBh3W?=
 =?us-ascii?Q?Bce/tnVz6p3Yz2fWeNO+15TEB3c/Zm09seeHWOc3+ZeGWY3gnWifMv/FkUCs?=
 =?us-ascii?Q?XECwJCbrN1o+d2LxX8ONwUMiTaIkPeG2vlnvzESSHn19M3sTYX747+yomJZ5?=
 =?us-ascii?Q?maEAVrlZR1rYZzTifNe6XUc68s6GDG0F9YLDwbcuQym1C6jfd9dsxZa+QvPX?=
 =?us-ascii?Q?SoRP8MsgY5VRySxB7ZgDkkxzRRz22kBkaTgxoqdr3fiBpW1Vgeh4+V4GkMNT?=
 =?us-ascii?Q?OE+kdsRcHEdQOYxPpYbh5KOdU8Nibj99z2Dq1SUHHWnhzNtgmh8/vGTaxdEX?=
 =?us-ascii?Q?AYvQsJKJqn8XohHg854U/k00vd5oHAB4tq60WhNaT5S2lnvLW7TwWxIfP53G?=
 =?us-ascii?Q?hdkQo5NfTvD/PSq9YR+1dkKtStDzaivBeNRxYMSpg90Iph449536VrbomM+N?=
 =?us-ascii?Q?fJ5L3LpP+bV5AjuuExiiucTTGsSJZy+jgGgMF/s1zdrN7s9HLJTS816pGK/F?=
 =?us-ascii?Q?gVIYwuntG/dAwj4vgpPiaDPJ1lTLhIl4S4RE3y/6prIpIjEOx5U4e7COD6Qb?=
 =?us-ascii?Q?PQ2hGVi7ysSd7vsm4P2JIwRQaA9TyVSz8E/mQvt0f/gVvw0jk1TI/h3rDNbF?=
 =?us-ascii?Q?fbRCmU75/mTUmlno/hWXN2lbSsImeNnEsca90nrk6lz37kz5Oh/G985WTn8u?=
 =?us-ascii?Q?My7O8p2q4bIpfgk3vq1SCGGirvyei0QmA3LHOrGu1PgFKiENsl21Yu7fsYLe?=
 =?us-ascii?Q?o4buLId5v76LX2h2AcR5gLPw?=
X-OriginatorOrg: synaptics.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d0794d99-d938-46f9-67bb-08d914650966
X-MS-Exchange-CrossTenant-AuthSource: BN9PR03MB6058.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 May 2021 10:10:43.2560
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335d1fbc-2124-4173-9863-17e7051a2a0e
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1aRagtcTEQao9gxBFMoWg92CNaGbGgAfeAJn0vwJV10uG5Hf3qFx3QzQp82myOmAPEqWFrcTkBmrIRak5OCTFg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR03MB6140
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 10 May 2021 20:19:30 +0200 Vitaly Wool <vitaly.wool@konsulko.com> wrote:


> 
> 
> On Mon, May 10, 2021 at 6:35 PM Jisheng Zhang <jszhang3@mail.ustc.edu.cn> wrote:
> >
> > From: Jisheng Zhang <jszhang@kernel.org>
> >
> > Some features which need code patching such as KPROBES, DYNAMIC_FTRACE
> > KGDB can only work on !XIP_KERNEL. Add dependencies for these features
> > that rely on code patching.  
> 
> Since we can define extra RW sections to place some tiny code bits in

I knew this discussion on maillist recently, that's the
reason why ERRATA_ALTERNATIVE related part isn't touched

> RAM, I would suggest that you hold back this patch for a while.
> I am not going to support the idea of e. g. compiling KGDB support
> into a XIP kernel, but disabling the whole HAVE_ARCH_JUMP_LABEL is
> hardly the way to go.
> 

I'm not sure whether the solution "extra RW sections to place some tiny code
bits" can work for JUMP_LABEL or not. But obviously, in JUMP_LABEL users
such as static keys, the patching is taken on the .text section unless
patching the common implementation kernel/jump_label.c. IMHO it's impossible.

However, I can hold back this patch for a while as you suggested.

Thanks