Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp3387148pxj; Tue, 11 May 2021 03:25:22 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyDYQPdf3nsmjhllhhRvCo5uAf+5fN5a2sTZ0CqQM0G9AgDqnwoT8+AwyWTbiqo72anZxFf X-Received: by 2002:a50:ab1d:: with SMTP id s29mr34333831edc.203.1620728722375; Tue, 11 May 2021 03:25:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620728722; cv=none; d=google.com; s=arc-20160816; b=URyCl4p6oSEdTpw1WPpYPgbxT7G9wfMeFTvMD6F3moAvLM0ThGkeOWzsUYlG55ShYJ 8vXhF5zEwCAOvSl8oJEv3yv+P4RNNILxqnGtcTJ2nO6FOPaVFhyAZanYZOxta6Y5oeVP hGczLf6ebB47cIi2jSGM860VdZT+ipTL2HWBbrikcZf53DU7iaILnTZsBiezpY2vTMBg 96D0jtSopYSyJEUh0Sh1W7jrIAgEUNQB2UdOBM1bqIfR0hWcbo0IvVDx6CUo3+Kw0K6/ oBMrpFhB8UZE+BxG1NYHDa+S3TTg2Iv1h7uzuJRjcYsEwc7p2bBTNr/tnY/DStFNrBHn bvuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=G0adrujpDKweoPEjP1QQ9qf3v1VudDZ63lGTmNiMcrI=; b=FFlFYZ9Jy9ZD4TO30+0/a0dcMVpoogJgGp7nQEIwe3N9g51GI99nAz5C9UC0JhnLfA awX1rUEe2b+bDbB/UDhgyn27VyqFZFDmJEWvaDYr7CjXIu/GmJAQJd5xMH/kMjlxGTMT 55nzOcFdY7zjcvE6d/TkiLawC1xpMKdX0YkpEUlJyodtxiZNoBDox4h9b6sF55+MYyMg ybn/sAa4VyF7CvQ0xH7gGAjPZA/0GA96p91Hw9UHhta0X2II7+VfzEh+D4JzNBSWGJBd xyP8TYEaBG8rOxJRza4Mpt7MOsunIlntj84sDKJ+u/KqpZIL3bm+Kynd7Os497DIjEEH kTgg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=XIwT+5IO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g27si8911378ejb.616.2021.05.11.03.24.57; Tue, 11 May 2021 03:25:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=XIwT+5IO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231340AbhEKKY3 (ORCPT + 99 others); Tue, 11 May 2021 06:24:29 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:24643 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230481AbhEKKY2 (ORCPT ); Tue, 11 May 2021 06:24:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620728600; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=G0adrujpDKweoPEjP1QQ9qf3v1VudDZ63lGTmNiMcrI=; b=XIwT+5IOqNPtHwJocydOTitvF8vbFuON6hWMvGJVznM4bRVDnGznjL/meoV/+RkJ3MwA4e 8aJ4N5OXDIV4qQJV1gDPd/SLEQ8jAJwmS8pjqkeJkI0/gCnxHL+9/bceW//IkvC1Rnjzwu CoS1yPOgHBRnqrulKAPk6DIVH1R6DiY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-360-Rsk5ItyUN_-KF78s2Vmb2g-1; Tue, 11 May 2021 06:23:17 -0400 X-MC-Unique: Rsk5ItyUN_-KF78s2Vmb2g-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id EAB8A1006C84; Tue, 11 May 2021 10:23:16 +0000 (UTC) Received: from localhost (ovpn-112-6.ams2.redhat.com [10.36.112.6]) by smtp.corp.redhat.com (Postfix) with ESMTP id 557D2100164C; Tue, 11 May 2021 10:23:13 +0000 (UTC) Date: Tue, 11 May 2021 11:23:12 +0100 From: Stefan Hajnoczi To: Connor Kuehl Cc: virtio-fs@redhat.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, virtualization@lists.linux-foundation.org, Miklos Szeredi , Vivek Goyal Subject: Re: [PATCH] virtiofs: Enable multiple request queues Message-ID: References: <20210507221527.699516-1-ckuehl@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="A7V9ozvfxmSnLtjw" Content-Disposition: inline In-Reply-To: <20210507221527.699516-1-ckuehl@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --A7V9ozvfxmSnLtjw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, May 07, 2021 at 05:15:27PM -0500, Connor Kuehl wrote: > @@ -1245,7 +1262,8 @@ __releases(fiq->lock) > req->in.h.nodeid, req->in.h.len, > fuse_len_args(req->args->out_numargs, req->args->out_args)); > =20 > - fsvq =3D &fs->vqs[queue_id]; > + fsvq =3D this_cpu_read(this_cpu_fsvq); Please check how CPU hotplug affects this patch. If the current CPU doesn't have a vq because it was hotplugged, then it may be necessary to pick another vq. Stefan --A7V9ozvfxmSnLtjw Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhpWov9P5fNqsNXdanKSrs4Grc8gFAmCaWxAACgkQnKSrs4Gr c8gaYQf/ZbGTh/PBCw1PB2OJDsg9sJ/qLNSeJAXsrq1soajsgMZNL5qaCxFxca96 7Ct1XtEelrvOEivymGbnjYFnL3kDuTeYhPzlyPBwG9heVxBReVxmKaC18hm5GwKk Qd481XSuaAF2gVk1B55pgfK4NwX/smvCgHpWvkP8vakZttXFUgMYcXM7Mi7V9XcJ 4f3EWA0m0iaWAkVJY2R+luPJtvc403igrv4QpUrw0kgn7iYw424W9O819g+Na4dO 8QdFtUmFHQsgwNVy6hKMnbhc7V0m3Hdwr2JVNXb2cd+yXqwVX+8xP3KeZOvBb5gX hUibZHl+yf0GfluxoJUfjT8JXVtBDg== =VnK4 -----END PGP SIGNATURE----- --A7V9ozvfxmSnLtjw--