Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: H4LLrThFVEcjymsKoy1QP6oz/ylLrrN7ai0y61DQG2MxY/FLqyXwPizbOUEHGVYGVmbvW+SMXY
 mG3DsvDxgHKg==
IronPort-SDR: NQRM/ZbnuICiyMsTks3kjEe2l5Fnm5WqS9YJWO4D+Xze/wSq3NEQ62EAUfezPbfJDGiblVSGqm
 zCUDwWt2zsjA==
Date:   Tue, 11 May 2021 15:55:01 +0300
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Mark Brown <broonie@kernel.org>
Cc:     linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
        Linus Walleij <linus.walleij@linaro.org>,
        Liguang Zhang <zhangliguang@linux.alibaba.com>,
        Jay Fang <f.fangjian@huawei.com>,
        Sven Van Asbroeck <thesven73@gmail.com>,
        Xin Hao <xhao@linux.alibaba.com>
Subject: Re: [PATCH v1 1/1] spi: Assume GPIO CS active high in ACPI case
Message-ID: <YJp+pV1mmIxY3LLX@smile.fi.intel.com>
References: <20210510141022.56499-1-andriy.shevchenko@linux.intel.com>
 <20210511111330.GH4496@sirena.org.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210511111330.GH4496@sirena.org.uk>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Tue, May 11, 2021 at 12:13:30PM +0100, Mark Brown wrote:
> On Mon, May 10, 2021 at 05:10:22PM +0300, Andy Shevchenko wrote:
> 
> > +			bool value = has_acpi_companion(&spi->dev) ? !enable : activate;
> 
> Please write normal conditional statements to improve legibility.

OK!

> >  			if (spi->cs_gpiod)
> > -				/* polarity handled by gpiolib */
> > -				gpiod_set_value_cansleep(spi->cs_gpiod, activate);
> > +				/* Polarity handled by GPIO library */
> > +				gpiod_set_value_cansleep(spi->cs_gpiod, value);
> >  			else
> >  				/*
> > -				 * invert the enable line, as active low is
> > +				 * Invert the enable line, as active low is
> >  				 * default for SPI.
> 
> The change would be clearer with the documentation formatting changes
> split out from the rest of it.

Will remove these changes from a fix in v2.

P.S> something is odd about the series I have submitted, i.e. half of the
patches simply didn't make it. I would wait with any new submission until it
will be clarified, otherwise it's a chance to miss more patches without any
reason why.

-- 
With Best Regards,
Andy Shevchenko