Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-PHdr: A9a23:UvSagRLrnJcVNDrqTtmcuZUyDhhOgF28FhQS9Z4ujb4Icq254Z34M
 ArS6eg+xFPKXICO7fVChqKWtq37QmUP7N6Ht2xKa51DURIJyKB01wwtCcKIEwv3efjtaSFpB
 sNdUFZj8ze7OFJLEdzyIVDevy764TsbAB6qMw1zK6z8EZLTiMLi0ee09vixKwVFjTawe/V8N
 hKz+A7QrcIRx4BlL/VZ9w==
IronPort-HdrOrdr: A9a23:nVt7ea4iGMc5mpqPeAPXwQmBI+orL9Y04lQ7vn2ZFiY1TiXIra
 6TdaoguiMc0AxhJ03Jmbi7Sc69qADnhOBICO4qTPSftWjdySuVxeRZjbcKrAeQYBEWmtQtsJ
 uINpIOdOEYbmIKz/oSgjPIaerIqePvmMvD6IuurAYOcegpUdAc0+4TMHf8LqQCfng/OXNPLu
 vk2iMonUvFRZ0/VLXKOlA1G8z44/HbnpPvZhALQzQ97hOVsD+u4LnmVzCFwxY3SVp0sPIf2F
 mAtza8yrSosvm9xBOZ/XTU9Y5qlNzozcYGLNCQi/ISNi7nhm+TFcBcsvy5zXcISdOUmQ8Xee
 r30k8d1gNImijsl1SO0F3QMs/boWwTAjHZuAKlaDDY0L3ErXoBerl8bMRiA0fkA45KhqAj7E
 qNtFjp6Ka/RCmw7hjV9pzGUQpnmVGzpmdnmekPj2ZHWY9bc7NJq5cDlXklXqvosxiKobzPPd
 MeQP003swmPm9yrkqp9VWHy+bcH0jb3i32D3Tqn/blmwS+sEoJuHfw9fZv1EvorqhNP6Wsz9
 60RJiAuos+O/MrUQ==
From:   "Gopalakrishnan Santhanam -X (gsanthan - Altran ACT S.A.S at Cisco)" 
        <gsanthan@cisco.com>
To:     Alan Stern <stern@rowland.harvard.edu>,
        "Daniel Walker (danielwa)" <danielwa@cisco.com>
CC:     "HEMANT RAMDASI (hramdasi)" <hramdasi@cisco.com>,
        Christian Engelmayer <christian.engelmayer@frequentis.com>,
        "xe-linux-external(mailer list)" <xe-linux-external@cisco.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] fsl-usb: add need_oc_pp_cycle flag for 85xx also
Thread-Topic: [PATCH] fsl-usb: add need_oc_pp_cycle flag for 85xx also
Thread-Index: AQHXQ2WrrZKg9g8qfkiceh4bDTF8bKrYSF6AgAYAVFA=
Date:   Tue, 11 May 2021 13:19:35 +0000
Message-ID: <DM6PR11MB45943EA963111B0FE6A85C1CC8539@DM6PR11MB4594.namprd11.prod.outlook.com>
References: <20210507172300.3075939-1-danielwa@cisco.com>
 <20210507173659.GA784066@rowland.harvard.edu>
In-Reply-To: <20210507173659.GA784066@rowland.harvard.edu>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 500e1113-c1b4-4b46-42d0-08d9147f6bd6
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 May 2021 13:19:35.0609
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 5ae1af62-9505-4097-a69a-c1553ef7840e
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: RooTAtgMMYBkOrGkK52aeMD+/C+OpfkSwOBGZDM7/bZ3xneC+9WKDUOKzaEfNfPGueErapIsiCgRx7/Qnpd2Xw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1101MB2234
X-OriginatorOrg: cisco.com
X-Outbound-SMTP-Client: 173.37.102.22, xbe-rcd-007.cisco.com
X-Outbound-Node: alln-core-4.cisco.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Alan

Thanks for the review !

Yes we have to change the comment as well.

We will update the comments and resend.

Regards,
Gopal

-----Original Message-----
From: Alan Stern <stern@rowland.harvard.edu>=20
Sent: Friday, May 7, 2021 11:07 PM
To: Daniel Walker (danielwa) <danielwa@cisco.com>
Cc: HEMANT RAMDASI (hramdasi) <hramdasi@cisco.com>; Christian Engelmayer <c=
hristian.engelmayer@frequentis.com>; Gopalakrishnan Santhanam -X (gsanthan =
- Altran ACT S.A.S at Cisco) <gsanthan@cisco.com>; xe-linux-external(mailer=
 list) <xe-linux-external@cisco.com>; Greg Kroah-Hartman <gregkh@linuxfound=
ation.org>; linux-usb@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fsl-usb: add need_oc_pp_cycle flag for 85xx also

On Fri, May 07, 2021 at 10:23:00AM -0700, Daniel Walker wrote:
> From: Gopalakrishnan Santhanam <gsanthan@cisco.com>
>=20
> Commit e6604a7fd71f9 ("EHCI: Quirk flag for port power handling on=20
> overcurrent.") activated the quirks handling (flag need_oc_pp_cycle)=20
> for Freescale 83xx based boards.
> Activate same for 85xx based boards as well.
>=20
> Cc: xe-linux-external@cisco.com
> Signed-off-by: Gopalakrishnan Santhanam <gsanthan@cisco.com>
> Signed-off-by: Daniel Walker <danielwa@cisco.com>
> ---
>  drivers/usb/host/ehci-fsl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/usb/host/ehci-fsl.c b/drivers/usb/host/ehci-fsl.c=20
> index 6f7bd6641694..c7d74c1a23f5 100644
> --- a/drivers/usb/host/ehci-fsl.c
> +++ b/drivers/usb/host/ehci-fsl.c
> @@ -387,7 +387,7 @@ static int ehci_fsl_setup(struct usb_hcd *hcd)
>  	/* EHCI registers start at offset 0x100 */
>  	ehci->caps =3D hcd->regs + 0x100;
> =20
> -#ifdef CONFIG_PPC_83xx
> +#if defined(CONFIG_PPC_83xx) || defined(CONFIG_PPC_85xx)
>  	/*
>  	 * Deal with MPC834X that need port power to be cycled after the=20
> power
-------------------------^

Shouldn't this comment be changed as well?

Alan Stern

>  	 * fault condition is removed. Otherwise the state machine does not
> --
> 2.25.1
>=20