Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp3650806pxj; Tue, 11 May 2021 08:56:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJztqHJEDfX5sMROoj0cd0pmQZnuYSZ3PalEQibhzd94LuqK0edpuigeOVpGykohlFAFMptP X-Received: by 2002:a17:906:58d6:: with SMTP id e22mr32560616ejs.216.1620748613498; Tue, 11 May 2021 08:56:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620748613; cv=none; d=google.com; s=arc-20160816; b=WzgWYG7ZErtP7zmeSmsiJVySISuJoYQxGAB/xjO58kMgc5ttyNd9pRdxRjbRPFLBj0 y8GZqLaBLjO+vr8gB6RaKOsS4d8tqUKnF3AXxercas5VtqgLgNy2wecN34PBQXULJ4a0 KC6Egd6B8TMcUeqdtTFB7kont6mj+pzFSKo7lJ+ck9iG01ssOn69KPVXgL7ipBGgAJbf JcapazVxe52/s546tnLmb3fOh39jFWloWtk+8Q4CG/TWWk5YpG71di4j+MKGtO/21nKh Vg1JiMn854bcbL9EsC9vuOqyxLj3wio0/0e3TuYN+jafWcz2xkxRCLZ1diKWw7GdxOy9 Z8gQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-language:content-transfer-encoding :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:ironport-sdr:ironport-sdr; bh=fnxIy1DPoLzOXd7QL1iWVrb2gRy/9OgoLFm63GGepNQ=; b=ow5BrkHYcqct+STUQ5FPw1i8iGMyVg5QZMmhBwxjVsjo8ZaVyX6NMumygATZMFLzzJ ZZx4IBd1q6/tybzu+Or/mTQWo5/mOhAuRO7FZ5v+80+BA/wuNUWNgos40O5rOgjrvBji 3m5ce5O0+GelHZG3xOb6PRPUpy5T2zBsQ+ynyaV867uIf8nzQR6jO5FqaJo7n4id5BMo xtzpZdq5XgdQtK0hZ3FbKJigZq7V07xdWcLnYylqT5LMIJ5JUw5gz3XKFCyGWE5h9tbQ ANopBwy7hJLzWxhTrxVuosYUz+H1kaRJeWHmDHuy8JxHZyP2nKNvWNWmzqRSprkBj+AB ff1w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id fy8si16238043ejb.54.2021.05.11.08.56.28; Tue, 11 May 2021 08:56:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231792AbhEKPx5 (ORCPT + 99 others); Tue, 11 May 2021 11:53:57 -0400 Received: from mga02.intel.com ([134.134.136.20]:21768 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231764AbhEKPxy (ORCPT ); Tue, 11 May 2021 11:53:54 -0400 IronPort-SDR: CdA/CeACSiTvlqb5ePMGvJSVZ6oVIAk6xnSY9LgqMr/iqx16lnw8yGTwfhepMl9pJHB/ojKYRd 3UoXNQuDRwYQ== X-IronPort-AV: E=McAfee;i="6200,9189,9981"; a="186611066" X-IronPort-AV: E=Sophos;i="5.82,291,1613462400"; d="scan'208";a="186611066" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 May 2021 08:52:44 -0700 IronPort-SDR: WE8qhOsKVmDOaVNf4taofiisTfVuocFI5boy3ekZvCq94mKOng3ZklGTKjKgMQmc/bmnZj+mkN a4WmZKIoWbJQ== X-IronPort-AV: E=Sophos;i="5.82,291,1613462400"; d="scan'208";a="434610762" Received: from akleen-mobl1.amr.corp.intel.com (HELO [10.212.131.161]) ([10.212.131.161]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 May 2021 08:52:43 -0700 Subject: Re: [RFC v2 16/32] x86/tdx: Handle MWAIT, MONITOR and WBINVD To: Dan Williams , Dave Hansen Cc: Kuppuswamy Sathyanarayanan , Peter Zijlstra , Andy Lutomirski , Tony Luck , Kirill Shutemov , Kuppuswamy Sathyanarayanan , Raj Ashok , Sean Christopherson , Linux Kernel Mailing List References: <0e577692-101e-38f7-ebe2-2e7222016a9f@linux.intel.com> <43e0a5cc-721a-04f1-50b6-b1319da10bac@intel.com> From: Andi Kleen Message-ID: <01b0e007-6af6-ca2e-2a0d-7ff4ca2a2927@linux.intel.com> Date: Tue, 11 May 2021 08:52:42 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > The 'default' case in this 'switch' prints the exit reason and faults, > can't that also trigger a backtrace that dumps the exception stack and > the faulting instruction? In other words shouldn't this just fail with > a common way to provide better debug on any unhandled #VE and not try > to continue running past something that "can't" happen? It will use the #GP common code which will do all the backtracing etc. We didn't think we would need anything else than what #GP already does. -Andi