Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 11 May 2021 08:55:24 -0700
User-Agent: K-9 Mail for Android
In-Reply-To: <87im3pfix2.ffs@nanos.tec.linutronix.de>
References: <20210511005531.1065536-1-hpa@zytor.com> <20210511005531.1065536-6-hpa@zytor.com> <87im3pfix2.ffs@nanos.tec.linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PATCH 5/6] x86/irq: WARN_ONCE() if irq_move_cleanup is called on a pending interrupt
To:     Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Andy Lutomirski <luto@kernel.org>
CC:     Steve Wahl <steve.wahl@hpe.com>, Mike Travis <mike.travis@hpe.com>,
        Dimitri Sivanich <dimitri.sivanich@hpe.com>,
        Russ Anderson <russ.anderson@hpe.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
From:   "H. Peter Anvin" <hpa@zytor.com>
Message-ID: <6B00421C-8B00-45FB-BE54-EED082494D8C@zytor.com>
Precedence: bulk

You are, of course, correct =E2=80=93 or 2 and 3 can be reversed, I believe=
=2E

On May 11, 2021 7:23:53 AM PDT, Thomas Gleixner <tglx@linutronix=2Ede> wro=
te:
>On Mon, May 10 2021 at 17:55, H=2E Peter Anvin wrote:
>> From: "H=2E Peter Anvin (Intel)" <hpa@zytor=2Ecom>
>>
>> The current IRQ vector allocation code should be "clean" and never
>> issue a IRQ_MOVE_CLEANUP_VECTOR IPI for an interrupt that could still
>> be pending=2E This should make it possible to move it to the "normal"
>> system IRQ vector range=2E This should probably be a three-step
>process:
>>
>> 1=2E Introduce this WARN_ONCE() on this event ever occurring=2E
>> 2=2E Move the IRQ_MOVE_CLEANUP_VECTOR to the sysvec range=2E
>> 3=2E Remove the self-IPI hack=2E
>
>Actually 2+3 must be combined because _if_ this ever happens then the
>self-IPI loops forever=2E
>
>Thanks,
>
>        tglx

--=20
Sent from my Android device with K-9 Mail=2E Please excuse my brevity=2E